From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-eopbgr1310090.outbound.protection.outlook.com [40.107.131.90]) by sourceware.org (Postfix) with ESMTPS id 03A40385141D for ; Mon, 8 Mar 2021 04:30:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 03A40385141D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cipunited.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yunqiang.su@cipunited.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lrxKWQZLcQ+1teSIdTvksuEEAqI6wByy4qtledu3idCSTHL0jB4tEUWymC+3r58TUH5qaAV0tVRroA6Rkxof41i2hNwYsLlmokMIn9OmxyJClHOG15j+gdwhkYch/KNxn5Fjtmv6ZsvWoEW/rBvIO3lTz8TRsUC/0VrllujNpAhmTNNTYB2xEDzgqc2ZBJu1Y6rxtwp7fWo731UJCnI4+aLU6PqiPP/7Y5xSk/rmgv3oB6IhAnEUzYrf1cY06o/lpta9/xKOBlpPTTEhl7QLnaYp71zZekRQhmOHs5mXn5bBLwsfJnlY50pCr5SjA+XHZIhCC74+M93UY0OJTcz8Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DcvJTvSQF+O39XOMDqswfbjIqvF8xxZ71Or1ZyxhmVE=; b=UeuvgHSjd9d6owsCRTk2wU4N3q5D77A+xz9Tk16ynUW5XNDwY6wY5nfcWzzBybMc5gqr41BAQo//5WkXlzbLMUJ8NQVSws7sww4WiF1F1XQ6ft/aZc/Lbeyb/NSRUIMjZI5xRv/L4WRUy2sNmiaaUmcSgyoM4fXzI0qQ6ToUtPUtlvCz2zr8blZojN0OD9cHoAYo8D32VItDqihn34jAi7pd8rXZx4trUtfTJ5Pc4bjYeq2W1vi7gMUhQwldxqwcMq605SgcGKJ/mF3rAKaBtjHLMMTLycp6863luZ7lPys7Nx6AkJ3kC2df2n3Fr3/pt4FDOyD649OKAozAvW2ccQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cipunited.com; dmarc=pass action=none header.from=cipunited.com; dkim=pass header.d=cipunited.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipunited.onmicrosoft.com; s=selector1-cipunited-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DcvJTvSQF+O39XOMDqswfbjIqvF8xxZ71Or1ZyxhmVE=; b=j1GsY0TiaEdBGteqTeACTpd1RZosew9eqUmpePWuksmY/cWRWX9uvfIGNCyMCUCd7r9uilUAwBGjo+WYMObUaOFi/gloyj3d8GZAdbs/EEZLZhAYbjl7+1bafaIHj+ASbaTwErVnC3VQto5aJUzuvu0cQaluJQQ+pKJbprgGvMo= Authentication-Results: flygoat.com; dkim=none (message not signed) header.d=none;flygoat.com; dmarc=none action=none header.from=cipunited.com; Received: from HKAPR04MB3956.apcprd04.prod.outlook.com (2603:1096:203:d5::13) by HK0PR04MB3042.apcprd04.prod.outlook.com (2603:1096:203:83::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.23; Mon, 8 Mar 2021 04:30:30 +0000 Received: from HKAPR04MB3956.apcprd04.prod.outlook.com ([fe80::b5d5:d70f:ed37:984c]) by HKAPR04MB3956.apcprd04.prod.outlook.com ([fe80::b5d5:d70f:ed37:984c%6]) with mapi id 15.20.3890.037; Mon, 8 Mar 2021 04:30:30 +0000 From: YunQiang Su To: jiaxun.yang@flygoat.com, macro@orcam.me.uk Cc: binutils@sourceware.org, syq@debian.org, YunQiang Su Subject: [PATCH 1/3] MIPS: Fix test failure with FPXX GCC Date: Mon, 8 Mar 2021 04:30:14 +0000 Message-Id: <20210308043016.11511-1-yunqiang.su@cipunited.com> X-Mailer: git-send-email 2.20.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [60.247.76.83] X-ClientProxiedBy: HK2PR02CA0150.apcprd02.prod.outlook.com (2603:1096:202:16::34) To HKAPR04MB3956.apcprd04.prod.outlook.com (2603:1096:203:d5::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (60.247.76.83) by HK2PR02CA0150.apcprd02.prod.outlook.com (2603:1096:202:16::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Mon, 8 Mar 2021 04:30:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fab143a2-bbfa-46ae-3108-08d8e1eae7c6 X-MS-TrafficTypeDiagnostic: HK0PR04MB3042: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LxWK5rwugOMF5XM0BmUDGT2A2NeZILxEiah+hhoIfTUUTSWo7W93xZGmqK4ZGzeKmKnjfIfG5PvGctLsxCBRfSIf0YTwhPB0oNSpZdVifo2G26ArRRFWIjJbbCTwrftddQLW0hjE2+2fGEMYYhrSalBDWBl66oVydXaP3yPFsRFNUhuS5FEM/u1Jk6yjM8iE/ZfAvXdkYWVHg5BREVlcaK+zcoQLnM37W2jg6eYTJcL7NLZhh8gaQIWWcZo3M4rnutfV/99OgjFy0g8uwNEqTjL7BuOJYkLv9r+ONWsKY7dyXrIa76LS/jS2bz34R9PoUH1eGP5t34eI84i2LO0AK9rAR8QEd/Z6F7UzZ3xBpMg2Z5LVDpy528/2aJbGE9NCFvHad7JvrtWdbGSRICKz+/PxGDFh7GehejLfbGOBIIq1LSNKwO96ytN/UThoGHz6c5kHxLCcvSjNZffCiJupvDSGcVA1+rXtFqsWEJSJcIewasGjS8WILZKCuJYESs7bmDQ0UHT+0BSiKL2evDBd2b9UAgtbi2m0WmiZhfRTSBV1Cx3r38+LO0x+loHRai8GIlhIguoHkG+PSIbK2TMfSA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HKAPR04MB3956.apcprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(366004)(136003)(346002)(39830400003)(396003)(6666004)(36756003)(2616005)(66476007)(6486002)(86362001)(52116002)(8936002)(66556008)(66946007)(69590400012)(4326008)(107886003)(6506007)(6512007)(186003)(2906002)(26005)(478600001)(16526019)(8676002)(5660300002)(956004)(1076003)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?BxKeAog6NT5Dvsk+ty9V56eNJ4Wu1geVIY6wUKE9UANHvUey/UnDZlD2agom?= =?us-ascii?Q?PBJjtOUhBZdNvyr1grXz7xRmAjiwT6mKJJXfTI/wWihYugJrzOD/XiE+CrZM?= =?us-ascii?Q?qIseoukNGIqaop46yEGBJzks7LhrWoMGoopbprhzhhjkuOH6COTIYlJSLAWZ?= =?us-ascii?Q?jTJFTKFi2ySze+D03bWVQ/WN4JTc4JMdhK6xjF99k9E7M10QEGK4M2NKb4vA?= =?us-ascii?Q?MaAc7qAdYtWSNB8HMB1y9EeS56FeD8I86oRQvBE8N2e9c3DbJs26bhjULP36?= =?us-ascii?Q?ObxvisXNv592rqgfH0SyugR+OgltjRBV7HfFigUH4/zXsSL5mGORnTBa4ruO?= =?us-ascii?Q?HBn+zQNMRKrRnHKY1hsCAExekHYGwCR7VJMvy6+8XabWcT+Xb8geK7bxGwDr?= =?us-ascii?Q?tpeF/FqMuYJVKwO9LBbB23cOzvxSL2X1+yV2K3nBc04wS8Der6XN1JgKNO55?= =?us-ascii?Q?DXYGt3NqYPR4SP92Dt0W+qWXVUv/LyLQIKHAmj3HtLa1EOEGIkqrv5sbA1Jf?= =?us-ascii?Q?Ivc5Gai0h87YMAu5giKjtCNJm7iTVadr6xUWKq8bvVXteJQ6N95oAlW2fIdW?= =?us-ascii?Q?LxfkIpdA/yM2I8J/endP1DG3RuVHDyyQ9aSlI8ysqOaVFTD679PoWqr3VhE0?= =?us-ascii?Q?TVg1iT6r8+pc5LThX89n9IwbcQuSuibSInd/PhI58+RhiXb8Dgl1dfv2fpGA?= =?us-ascii?Q?0pOMgM5zdMf3QZeMfuRm1i+odhgOpuPIP8bzPT75I3/ymRSQc5DOvnRik4nV?= =?us-ascii?Q?/9S9K5mk7TbHmvWSESumZ6J8c8C201EOJXY7FaO7t5/9iqMkl6VFYWdJ5mUo?= =?us-ascii?Q?C8C5gHKyeub1nD/ErZ+Nfq4IMtx0Wtp1PwBVuTH5L4+UqIo+fyacpHYRxCsL?= =?us-ascii?Q?hYla/CNyq4nEV29xGVyj1GXn0/v3kj2ULRB/z5CKWVPYLmY4yO0qst+de2+B?= =?us-ascii?Q?b1KWkHr0SbiwVkajjvTGKcxcvGxZ4Ytx1XwzqTLfJlj1A0xtHIr0dkqDuhGs?= =?us-ascii?Q?oARAcp4NG72O3omVffcqJ7vvzzJ02WuPlPU45qKr/RgILECt+oL5t1rn++KW?= =?us-ascii?Q?aJXTtVHAOvY9NtNNafP4fcqPyWa3iKLf9vPjsLwZ2GteYCRqPSbqKAxBO/d0?= =?us-ascii?Q?hEC0bqcRk9AwIeHceN9RJeO8yZkKSJ82EbLAYO00KgFxiV86n4CH+BRlnbrH?= =?us-ascii?Q?Xpuz42Pir0/pEo7u/z564Hhg5gDH6OjeW1V3CZcAtT75KO0y4/SIrRjVazw9?= =?us-ascii?Q?MXmQ3qaJ0py0ojsoS9lshurPs5VFs1TV4Nw9Q1w2nIldXY1vyzNbXwewvZhC?= =?us-ascii?Q?pKsEyrb4YJe3sU7BvVuwnNw5?= X-OriginatorOrg: cipunited.com X-MS-Exchange-CrossTenant-Network-Message-Id: fab143a2-bbfa-46ae-3108-08d8e1eae7c6 X-MS-Exchange-CrossTenant-AuthSource: HKAPR04MB3956.apcprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 04:30:30.5852 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e31cf5b5-ee69-4d5f-9c69-edeeda2458c0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ORFODuBA/6OK3wwyYFZaP/Gvzek5q2M2VRt/Mv71KC0tr4jsjYNyuJzjr3o9A26XqVL/jptlId3HHgSh2gzb73xhN1ApzdE2ZRAXWx1sdKc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR04MB3042 X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2021 04:30:40 -0000 GCC can be configured as FPXX default, which requires MIPS II. This make `as' (default to MIPS I) fails to run some test. To fix this, we pass -mfp32 option to GCC. ChangeLog: 2021-03-08 YunQiang Su * ld/testsuite/ld-elf/elf.exp: Set "-mfp32" CFLAGS for mips32 * ld/testsuite/ld-elf/shared.exp: Likewise * ld/testsuite/ld-elf/tls.exp: Likewise * ld/testsuite/ld-elfvers/vers.exp: Likewise --- ld/testsuite/ld-elf/elf.exp | 8 ++++++++ ld/testsuite/ld-elf/shared.exp | 5 +++++ ld/testsuite/ld-elf/tls.exp | 12 ++++++++++++ ld/testsuite/ld-elfvers/vers.exp | 7 +++++++ 4 files changed, 32 insertions(+) diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp index e98bffc0c5..37d49faa3c 100644 --- a/ld/testsuite/ld-elf/elf.exp +++ b/ld/testsuite/ld-elf/elf.exp @@ -421,6 +421,13 @@ run_cc_link_tests [list \ ] \ ] +set old_cflags $CFLAGS +if { [istarget "mips-*-*"] + || [istarget "mipsel-*-*"] } { + # the default target of as is MIPS I, which has no ldc1/sdc1 + # the gcc may be set as fpxx/fp64 default, which require mips2+ + append CFLAGS " -mfp32" +} run_ld_link_tests [list \ [list \ "Build pr26391-5.o" \ @@ -446,6 +453,7 @@ run_ld_link_tests [list \ "-ffunction-sections" \ ] \ ] +set CFLAGS $old_cflags run_ld_link_exec_tests [list \ [list \ diff --git a/ld/testsuite/ld-elf/shared.exp b/ld/testsuite/ld-elf/shared.exp index 6bf49785a5..ef67e3b8e2 100644 --- a/ld/testsuite/ld-elf/shared.exp +++ b/ld/testsuite/ld-elf/shared.exp @@ -941,6 +941,10 @@ run_cc_link_tests [list \ ] \ ] +set old_CFLAGS $CFLAGS +if { [istarget "mips-*-*"] || [istarget "mipsel-*-*"] } { + append CFLAGS " -mfp32" +} run_ld_link_tests [list \ [list \ "pr22269-1 (static pie undefined weak)" \ @@ -953,6 +957,7 @@ run_ld_link_tests [list \ "-fPIE -O2 $NOSANITIZE_CFLAGS" \ ] \ ] +set CFLAGS $old_CFLAGS set run_tests [list \ [list "Run normal with libfoo.so" \ diff --git a/ld/testsuite/ld-elf/tls.exp b/ld/testsuite/ld-elf/tls.exp index 1351a274cc..dfa3f50ecb 100644 --- a/ld/testsuite/ld-elf/tls.exp +++ b/ld/testsuite/ld-elf/tls.exp @@ -39,6 +39,15 @@ if [istarget "sparc*-*-*"] { append AFLAGS_PIC " -K PIC -Av9" } +set old_CFLAGS $CFLAGS +set old_ASFLAGS $ASFLAGS +if [istarget "mips*-*"] { + # FIXME: gcc's bug, it always generate `rdhwr' + # even for target that has no such instrcution + append CFLAGS " -mfp32 -mips32r2 -mabi=32" + append ASFLAGS " -mips32r2" +} + run_ld_link_tests [list \ [list \ "Build pr22263-1" \ @@ -51,3 +60,6 @@ run_ld_link_tests [list \ "-fPIE -O2 $NOSANITIZE_CFLAGS" \ ] \ ] + +set CFLAGS $old_CFLAGS +set ASFLAGS $old_ASFLAGS diff --git a/ld/testsuite/ld-elfvers/vers.exp b/ld/testsuite/ld-elfvers/vers.exp index 8a1383fe84..63127a46d2 100644 --- a/ld/testsuite/ld-elfvers/vers.exp +++ b/ld/testsuite/ld-elfvers/vers.exp @@ -777,6 +777,11 @@ if { [istarget x86_64-*-linux*] \ set pic "no" } +set old_CFLAGS $CFLAGS +if { [istarget "mips-*-*"] || [istarget "mipsel-*-*"] } { + append CFLAGS " -mfp32" +} + # # Basic test - build a library with versioned symbols. # @@ -1006,3 +1011,5 @@ build_vers_lib_pic "vers31" vers31.c vers31 "" vers31.map vers31.ver vers31.dsym # Test #32 -- linker --defsym build_vers_lib_pic "vers32a" vers32a.c vers32a "" vers32.map vers32a.ver vers32a.dsym "" build_vers_lib_pic_flags "vers32b" vers32b.c vers32b "vers32a.so" vers32.map vers32b.ver vers32b.dsym "" "--defsym foo=0" + +set CFLAGS $old_CFLAGS -- 2.20.1