public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] elf: Set p_memsz to p_filesz for loadable PT_NOTE segment
@ 2021-04-08 14:05 H.J. Lu
  2021-04-14 10:46 ` Nick Clifton
  0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2021-04-08 14:05 UTC (permalink / raw)
  To: binutils

Since p_memsz of the loadable PT_NOTE segment should be the same as
p_filesz, set p_memsz on the loadable PT_NOTE segment when updating
p_filesz.

bfd/

	PR binutils/27708
	* elf.c (assign_file_positions_for_non_load_sections): Set
	p_memsz to p_filesz for the loadable PT_NOTE segment.

binutils/

	PR binutils/27708
	* testsuite/binutils-all/x86-64/pr27708.dump: New file.
	* testsuite/binutils-all/x86-64/pr27708.exe.bz2: Likewise.
	* testsuite/binutils-all/x86-64/x86-64.exp: Run binutils/27708
	test.
---
 bfd/elf.c                                     |   5 +++
 .../binutils-all/x86-64/pr27708.dump          |  33 +++++++++++++++
 .../binutils-all/x86-64/pr27708.exe.bz2       | Bin 0 -> 5815 bytes
 .../testsuite/binutils-all/x86-64/x86-64.exp  |  38 ++++++++++++++++++
 4 files changed, 76 insertions(+)
 create mode 100644 binutils/testsuite/binutils-all/x86-64/pr27708.dump
 create mode 100644 binutils/testsuite/binutils-all/x86-64/pr27708.exe.bz2

diff --git a/bfd/elf.c b/bfd/elf.c
index 276fa14c0dd..e762e8d0f23 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -6300,6 +6300,11 @@ assign_file_positions_for_non_load_sections (bfd *abfd,
 		    {
 		      p->p_filesz = (sect->filepos - m->sections[0]->filepos
 				     + hdr->sh_size);
+		      /* NB: p_memsz of the loadable PT_NOTE segment
+			 should be the same as p_filesz.  */
+		      if (p->p_type == PT_NOTE
+			  && (hdr->sh_flags & SHF_ALLOC) != 0)
+			p->p_memsz = p->p_filesz;
 		      break;
 		    }
 		}
diff --git a/binutils/testsuite/binutils-all/x86-64/pr27708.dump b/binutils/testsuite/binutils-all/x86-64/pr27708.dump
new file mode 100644
index 00000000000..e9123df9c42
--- /dev/null
+++ b/binutils/testsuite/binutils-all/x86-64/pr27708.dump
@@ -0,0 +1,33 @@
+
+Elf file type is DYN (Shared object file)
+Entry point 0x5f0
+There are 11 program headers, starting at offset 64
+
+Program Headers:
+  Type           Offset   VirtAddr           PhysAddr           FileSiz  MemSiz   Flg Align
+  PHDR           0x000040 0x0000000000000040 0x0000000000000040 0x000268 0x000268 R   0x8
+  INTERP         0x0002a8 0x00000000000002a8 0x00000000000002a8 0x00001c 0x00001c R   0x1
+      [Requesting program interpreter: /lib64/ld-linux-x86-64.so.2]
+  LOAD           0x000000 0x0000000000000000 0x0000000000000000 0x000938 0x000938 R E 0x1000
+  LOAD           0x000da0 0x0000000000001da0 0x0000000000001da0 0x000278 0x000279 RW  0x1000
+  DYNAMIC        0x000db0 0x0000000000001db0 0x0000000000001db0 0x000210 0x000210 RW  0x8
+  NOTE           0x0002e8 0x00000000000002e8 0x00000000000002e8 0x000030 0x000030 R   0x8
+  NOTE           0x0002c4 0x00000000000002c4 0x00000000000002c4 0x000078 0x000078 R   0x4
+  GNU_EH_FRAME   0x0008ec 0x00000000000008ec 0x00000000000008ec 0x00004c 0x00004c R   0x4
+  GNU_STACK      0x000000 0x0000000000000000 0x0000000000000000 0x000000 0x000000 RW  0x10
+  TLS            0x000da0 0x0000000000001da0 0x0000000000001da0 0x000000 0x000009 R   0x8
+  GNU_RELRO      0x000da0 0x0000000000001da0 0x0000000000001da0 0x000260 0x000260 RW  0x8
+
+ Section to Segment mapping:
+  Segment Sections...
+   00     
+   01     .interp 
+   02     .interp .note.ABI-tag .note.gnu.property .note.gnu.build-id .dynsym .dynstr .gnu.hash .hash .gnu.version .gnu.version_r .rela.dyn .rela.plt .init .plt .text .fini .rodata .eh_frame .eh_frame_hdr 
+   03     .fini_array .init_array .dynamic .got .got.plt .data .bss 
+   04     .dynamic 
+   05     .note.gnu.property 
+   06     .note.ABI-tag .note.gnu.property .note.gnu.build-id 
+   07     .eh_frame_hdr 
+   08     
+   09     .tbss 
+   10     .fini_array .init_array .dynamic .got 
diff --git a/binutils/testsuite/binutils-all/x86-64/pr27708.exe.bz2 b/binutils/testsuite/binutils-all/x86-64/pr27708.exe.bz2
new file mode 100644
index 0000000000000000000000000000000000000000..94063c6c2852dcb6e782807d13422d2345b72137
GIT binary patch
literal 5815
zcmV;o7D(wrT4*^jL0KkKSt3l@>i`x@fB*mg|NsC0|NsC0|NsC0|NsC0|K9)l*8ly-
z|NsC0|Nr0>FS)qO0N(X9!ca9mXTI&(-QR7Q=`Lv6W9%DdWDIF*vp@g}05mnSL3g2%
z5RD0mrX<8Y0-l>HpOZ>{LrLk0r8lXmvk6aX6ZI#l`kO(OJsyoD(VnNNqt!oBZ&dWe
z$`47Vk5T16RP{Yg8InCFo~NngjWTHbs1Hv{Jdac~(<iB+>NGu1(m|=BWW*W}ObIhY
z^rz~ciRee^1bIWyn^0%~$)Gd?BSS#Y007Wwrhouw00w{n0000027nC)nh`XOCMKZT
zlOgG$F)<j@JpusG14B&%Oh6hMG6P0{Xwyc301XC!$)M2CXahq)00001qd*y{5^7~n
z)jdpr3=EI~paV@ZWW+RR00D>^0078fnqYv?FpUP9XaE2W27oeRXc(FUMvM`FIshI}
z0001J0000000000000000000D0000000000002mlGzbZhX`mGHG6JWHev{OPspBen
zsigf)p-lkM<qVtEJfH{anI4)=KU4vYKn8%w10XbdfB*mh27mw>4Fhx=%igPpI-*XV
zKw29P<HHd=?&U)nhZ0*v`w8vn3y^&k1AHaOj&vT*m!=ri84SLNt_Jz^d&Me^C8Zf{
z71XxUDF~#e4F{cO7f$U=+&uD&!FCvi61SjA6XUCj*HlxhI9ytVXIM`INlwgGU?#AN
zuJ+TTG%X^`Cd5V;Yr9UAILF#ub}@2m!j1fhq2zrnc8E6p&f^ZgZ5-i0H6m-G$j8|*
z&%iKtPaclIHhQ{=)+c1A)Vh@rsT&j49btB=F@l*cS=ndO0?wd_?<v6au+zQ?w+7-7
zDl4ov88T~fQHLb-EM8v84400M7;$e<3ku3{GqC0L%6GV#ixI9s<;Q~hOiC@e6k$F2
zG5Q3Bf_oBraaggLWS9-zuvv>rRHtdoL<)J8qG1*{4!E);=o*4lkg98Ob}-VXX-JA&
zt<Dx&_T^AwFgQ$oHmbP^n30=U8I4e2ES3zV;P0cu)&o~!MVj^y;v%^u)JjxFaE`kf
zgIde_@}A938<e8+h&V9LNQgjFDug@ocs+zR!1OeGro`4sXV&g0pC`($(|=!`%$>ic
z%cm2uv8Ro#%}u4MxIF$c%P37P?C0QBvqz#;(5o(c?LV8gw4U8DRgr+>yrVyyqyRS=
zTc!XEfP{cbCtkZtnJg*xF0PK}wvAJr<@%9H1}YK<)j$E*AP1s=k_K85I5$cFwo7!N
zlbKe_+sU)14!fZK$JeUpBwr)b#hs;a3HV9cC}Dc}ghxx%aAKhL**Aub{1Ox%rFN<Y
zCll$)uY>0JN+tw7tx}ROyQL&yAr;89bc_I)=t3a`Y)}!z%&uVku2M+RxHxqVem0T^
ze=8HJ*APYs2y%nWYh)(>zf&143UFib;o{x>&UcAm{9|E30u9@+q$mp+Tqy>P$Lky%
zXjkT%br_st#!F$ViajVTHGaQW<LY5C({3N{d3lUUyqh_-8(iuIm8(trP1O<xA%nsY
zCV?aki3zQW*AgU1kagLt5_)2!3S$pQ!9(jXhS(<%BY<s4kpof_aHS0}ZQ~G{5Smg#
zOcD`Bk|1Ctbw-5)4=7?(X;#uE(gwi;XhsGEFr23^FJ0LpjI4^}q{SvhqeFyZj|G8Z
z@q+-sfTc>FA!1r+su+@}uwucD)D<-Bp@GfL5d;iz4HF_j+=NM>xuBZ_*cCLYVk%(_
zCdn{G%xsZBsuieI$SfrRNmzCcVwnUGK?D#)MOz9K$x#$Tkmk@bQ2-Nx%up#<#0pUm
zC=!4YpjBp(1r*6tMIclWCLpks>2s!TWkIQdBE*R(O0_k~G^R0%k*F62CjwR4I}IZV
z#>jOzhE0m?C$YKNRqU|3mCkaG+f};QmkSG+U}zh$fk)n^fcmegfgfVfNu@%(cMXcU
zDWv}KrRkeF;2cPrS^{Ia3DpxS!%G5Sq{X3$8vT9kHF!1FfmhIkkV&K^^{f&Ln1sBx
zlH3}*S&wRP*7Zpt7cfHWG_7Jpno1ah);*?zZF*KDYB2{vpffaY3=EQkQ8BRy%+R`x
zA$UnpfCbCZ+maRr2CER4v2{ZmVF@7iNuv`8!vGD4tJ!`mglT-Ie6T4juGS5%|LP4=
zO`@C7QHkM;GR6v^0>B^*yB9ADJ$oT^`f$&Z)HE`&Y&F8<Zl5ha#|NPua8p9p5jSfC
zBhRm7>5*YASXDKw<u}ep)=hWJ7A&z0JKL|vG=oMlN4dIve%(!F3WQfBRFihi-zaK;
zDI*haj@xB#ptrW9DbqSe3L46>7{+#_LaNxcnXAojli#Kkqf4H^VIv$G(Qg}9i()u&
zIrkM<FWW_7(pITb3M54vprHVLPZQ-?6Nv;t_?pqyc&iG&GdFB)Gg1IGYtqX9Z4rG0
zYOYic(522l7#TM;fatT-a-inC4p9j3I`B!2u0ae?(y9HcM}Nkb)%3ll3JkDiC9Ajc
z|EuTOad6mJgRkwNCj2Zgm423~K$jQlK9UX27Dp!g(&W7}<Ltf_+kpNn+ibZvcf4PC
z$9zpyk9p$y{Qt=VD{s@3&G4o&8N*9@rt06oojRU!A{fI|oU&5NrQCkmhdH7!w9t*6
z&rt9H007`=n|H>yKf}3ttCi)f<ng+XqT09Z@8))_rr3uik^r#V>|t;qtAv06x+HQ8
z7?dX+)q#AZmy;sUU&Ai!;A5i`^+kQ?OhCarzp@?zJsSe<32tZ&)DdCShU{fl<AA%f
z9z(bp*<qQZ3sZhM1481KS4$5^&9SW{mlf&|X)-agQ^DaD5fBK;t9^B}1vAb7RJ`TQ
zBk>LNE)YB)Arw@CO;b64XdKZd3(T+trSNz`O_GQW&3#s&@qt_yhp@M!BEeRI29cpk
z(@ybM2rf8R%}MG7SRjH63lQr&CM~89Hd}W6eNm(ug#b=MM_eY?Qna04qfo#Ac?d6{
z0T4+xn@M!AD6hdFCfiMd<6=i(KOzEb1&qr5(r%H0X#!{(V3G&fnOqK!CyPV{2`K1m
zy@fN>R2$aS4hNm`nfKkz$G+ua+3YxZI__R&JWJ_ya;s33LO|Jnh)9!2+-N(+A*cZ7
z1yRmx`&`w-2jmi7rh<gjtf8#`m6393s}ZpYg2)gx;OnB&klmzh*t+&|X}tLNv9(x=
zVYv;yYR`E0BYf*9k+e}oMG>{tprUjG?F~Q|q!2hb)NE#fN#pBmE@!zH{OsJHB1YRc
z=5{_?J+4f<D9~BG_IzJS?J(T?G?OWm5irbIZ6~P3t<lbat``%Io<BRO0i^Jg6dquW
zq@cL`HMzAtK_#wAGw0d?pw;XENtF7@J7K{QMTOJN$F|Aeb0z=SUfrEETSo@>?Cmi0
zR`-}eU^t#k;et_|x7SIZeUNK2?1CIs<EX-7O&qWpotJOagz?aUU8HSV*7SF|XpCSL
zf!X?G14D77jJKIhfC{7%LlL6nH932~Gx)~~PJ7~vA>~15OV+rk$xvrvq9Xwu8I){K
zGyr<aF@L3;qYEL}Of^f(<)i|zjG*xSy=P%P;HixD&#lsO=>|0>fq>i*#$aHgLk%ce
zMr#-nkp`C9D~Lu$8(zT?bjQsi86@G4BRZ1s<V6D$;;^Zjf!C}qnRW;y(O6Xe>QI{E
zar#n`Q#>h28}or&Hj7z#(?4f2J*lk+Axe-)5(ErUN<|-N%?nEN_WK>F0k*_?Xp3uv
zs-y_?%nMnef$myW{mfzWoFL$uBR|(A=>kFtZw!G4lFA{TOY4F?wxT=W6yYaD0}%;h
zd`)xMeJ+SgjZqr(nD_QQhnQ?Jo*-yYkSuJ{%?d;mMAK;{K$z>lqy~}=)|G4!N-4iU
z+6Nz+BiIhSkQc`vsw2VkvP5iTCP$OH<JBnA#Q+z!fMB4S5}cqgEcI+O`c(ua8tYJU
zNyF!-{NO0shd`W|C<l!sD6j1-m`Lvs%h#wD`din;y=`ZQHi?dh)vZVk1-ry55$c-v
zY$KhsvOlJxWT6r5a;P!KNz`?G;E+<9Z;=c$;UOZA+Q1ND8b3E<+DdHhf`b}kV@>w@
zxO93r$Ejgyj`=A@W$su`VrjLeKHK%Zy;I9{E10pdnJQ$jd5HPy1|v^g;cZke)zZ<s
zcrYl5>J9tyZ`A`TW#eBOtqeV+M~rw%fT4ZR##o?MAV4CPZpg}U=WjXqZ5YU&PUG6>
zb+UeLRDBhUJ^3mG{QCnUywg&HL89)FfygrzZ#oVLelw+k;h!g)1;RA39tQ0MI(^)2
zmHqfd03wA|Rad?K)N10i+I!m4dp^%!-S|B>97o@P{YH8nlYk2keHz6SE(`+JBUKHv
zOfq3ntu_L<#R*FjP0|*;jv)0m>2MtzG3W(rpncH=scb(vgl!M1H<we#-+AyE1H$wT
zd0&PWnHz2KI0&YmR_~1|z52R-;%4jS^?Y1zR52`wBqCgNFGg$NG2w#R0@W*FJc>Dn
zM>hKucN!&@?3OZKbGP+(8hoot_n_in%Is(5YG8;n=qr6-B#j{Git%6&G?HfSPAHv-
z*e;sEVie<*FoWh8Hbv27Y@q?OhG(G$)9Wg5_7#)5J)U{+{)pl5d6+a|90vm$W0DqK
z{-Af;U&;~)G<bdo1KNlCrY?Mn(=tRh=7ZU^ply{ht=o7Utcp=9CWHZFpua(b!&ik=
zJUh&VTk5rEqOo8|5r()f4DwcH$`d?dEL^da?dqwf83X75OIXp%DZrGCo*6jlV)wdq
zP&9T-EP+r1gAYP%)5>LdW0N(ZP;`;nz#K=6ZPRzQ5-02bqu{($tkwKN1KfF;B*Tn3
zfy8IX7YDp=?YjeOO(Yy4udW#Rp#4B#+`B6Ht_i*W<fQ;NgCKV%Z{P6h#_Xmr=mt>O
z4}=d7O~dKb7~i1{^}d^DbUMOiNmg<u6CU{<j5<KW5F1(dwWDvxeKVt=I75s$!D<<K
zL;ubW2gTKGpllmPgHSMr$Z`jcW-YT`HKbxqbzuWyAhWNlZ~%1>D=5|;vY%xQAluRX
z4400m)eB*EYqJp0+-IkW{L~If2x`$#b&xbmMzdU(Z4O>?1sN2yp8^RL8ZAd<f9zfF
zEH|I}7Q1iFOh|n9WJsdi#O~?8dF6YU!37QG(}X)~hExEN4yT1PbPTPHxvgT*FmNRm
z=)lOV+eD1O&glPm0pgLPT{0Mpx{K5$@shT+5CSxwd1v^!7_hh+LFvFX$pjB|?X8uo
zq0~NCpOJyeyR3SoA_NGDC?VIeL7huY<_Nj~)B~B-Z)*`O>0+*?orM5uIy>it+Q|MD
zglJ1+r;*5|iPTiYo_$I|ng|3RHsKHf&d`S<VMfiVw{d+|44wLr@$sKepr2Bz=_GPb
z7Pk$v%hrrH#%nm>?1h1&hv35Qhky~lbtDmds_PB#-^&aY81=#)MBK8i6Yq@5_B4l(
zFbHWL&``6H0eJPDsjWVLF;S&@bnK>tG3d1StQ9Q8y6LLf7t)neBb-EtSV55+IdgRa
zT7E^&D-gT3m&8_fOde|ppRTbsx-=brxpsmNG5R9vNqlMDn7?Ffs+jE$lB4xg`3v7{
zf#36^yqnK)aWe}6Ac2x62;PL|dO(LQvyg|x!*vYOID=v%=!9)mz(Bsdf|QRnM0Xzx
z$>s6KJG?T>nnKv!AmI-%G_CSz)UVU}nG@v$32X!bFyL*bA+i?`OxZLW2VmKTnc@d7
zMWqQV?pVtt1p!c|a?-9}XbXZ$@HRY+Jhdv(lxox7a`=UG0i#(yYX-tq8kwudtdwQC
z*#--t6lWVYw|nZSu$ref@Ye~7_*E>u>7=X-X)U8No?7N*y-QGID+%OCf!UFfhFR8`
ziIoF}y<kkkimPuP3?NsHBx~B1i;RF;T057m3yfnY468Qfz{ZeG7l%`=%iT_xuhrbx
zh2srmoagNJX{o(wpuW|8jj^?S;EE*G*UOMBFr~&=k!e9jdZ;Yt&M6W!WeO~d91?T_
z(QA;ZFIei`Fbgf^4B;%-7AvXCb-a{JFDu`t&o#oO;=ba1;Aaq8YJ)HXRrUCyBviIo
z-iIWzoRgH{kb}QW>vAY78xhXHmbUH9upqTi%qiX*BE%{g3uLW`1AB{!=|qi{gux29
z#o|GXtf24ZSA)%hZ@Trp6^xk#8;KppWuqquOBl2T0<9s6Duxjd*!M`#Pgn0l3dJeT
zvVz!{W4L3Kk))Z`4vJP4WGsja9exHSjK(l&g?zw#!E2x`OxIM42sGjN?oJKhGz}$J
zD?fKE_z_vchBCsOTX730T+-gH9{5%$MMM~ifN)G=iHKaRKbQhjG*=)*s-_MJm<w2W
z$?vQe4=OJ&#%m35%z;Z#p{Pp?m1iX8@+#RKKTqrAEP+xD$tYP{WGI9@w@HsmVR@1i
zD$$TtC?;rR2xSXl0<D~eWy;Q)u)@`7W)i@_(!?<+Fc^eLC0KODW(UQJTvaX9RJX^#
z4JBU5ZWFvWjAk|>g{fGYOp>U?d-P90yqPFBOU7U_C0a&7kYIz8Nz32a&OEzoKG}BK
z+?7ci0Bmk>@%Y>OCcXzDjg6{h6mB(mG=?)MQoMjrlCH6?B7}`+l%HTLnA+I5ieg)4
z*epeq)_@?yF+?`Oj83z06N9;HDJ8i68Iu{hjv^{g2pRI0!k(+#10Ai6RA#yuG!~mc
z!z_tZwj`3XF|f5wwAJP@S4awpK+A<xrnT?Lv+Iab7P5_~p#YSqhz(yH*MU~8*#f;X
z%#Oseq7_o^H2Crv|K3;Ta9U7h!o`Wr1j&i40Cx~!)eWE=5GAXLLRMar8b$II`l`Oh
z5Wreltc{Zrvk_T&L2Z~)k#c2H42mn*=5tCD;5BJz6HNDd2C1iWc_PajZ#8Q=)F)|T
z*t5A#veJdN75UmRgZsUk`S{knXln>efEx}7yg&}lQmJY?Sm5$Vu+nP;RAkE<bf5)Z
znU!YN?+*zEKJtN6C$evhWrQHxXAW$^n@-lQJ!d9XOgWDtf$W@Z8=(^q^X3h_bLa&j
zW|(B6o)`{ty-K<k=V6|mw}jzk_psn?(*)#<<5-X`r^(#V-=0my45V!Uh|A#<N%(W{
zB?Vxz@nZ|gJ{Vwnb-dG?5v#rt=Rq}vgOQffNSa{6AWcDbC@7CjmCV)dFVoOKriv62
zfoE#9IYz4p+$^BxYs0C(kRB0cwN<=9ODO~>t5H^oQm|?Q(v0gRQlzS%OA?gCkbQa+
zI~FD^L!ojQYfOFlif%CRu`s}pllVHbY9_a2*Gp@rA#b6NK`DsYLS#=QAdYn#``j)l
zDYPPix8+_!$4vg32I$Voh!GJH9tT~aI{hc$YNli>iTNZ4j6oA%1dEjE-$Eiv5x$({
zS8pLNKz8QiqUItTIaP$p#P=1D(;y8NJ_Jih&TNE)9Enq3oAK7{s^yp4O{=9$Dpn^-
z(@Om#D(ZHojI3CUj@0WOkboA|pvg{ka-~a7(4Gu!tt-y<k9~Pa-^|)zH?oQZP_<u&
z9!$uwc(d>-ca7cn{~K+a?*D#AWixSU{Hb%>ywAgN2pMJ60BjLZ2zzj!PBiNZTWmC@
zfh=?p0|VFX<?j0wNeKzRd02{{#Rpc}g7X?QdpxWJ!K$f^*jWGZcO+AV2?8X|uCR9x
BoQ(hg

literal 0
HcmV?d00001

diff --git a/binutils/testsuite/binutils-all/x86-64/x86-64.exp b/binutils/testsuite/binutils-all/x86-64/x86-64.exp
index 90fcc84c4f5..29ba1f029c4 100644
--- a/binutils/testsuite/binutils-all/x86-64/x86-64.exp
+++ b/binutils/testsuite/binutils-all/x86-64/x86-64.exp
@@ -58,3 +58,41 @@ if {[catch "system \"bzip2 -dc $t > $tempfile\""] != 0} {
 	}
     }
 }
+
+set t $srcdir/$subdir/pr27708.exe.bz2
+# We need to strip the ".bz2", but can leave the dirname.
+set test $subdir/[file tail $t]
+set testname [file rootname $test]
+verbose $testname
+if {[catch "system \"bzip2 -dc $t > $tempfile\""] != 0} {
+  untested "bzip2 -dc ($testname)"
+} else {
+    send_log "$STRIP $tempfile -o ${tempfile}.strip\n"
+    verbose "$STRIP $tempfile -o ${tempfile}.strip" 1
+    set got [catch "system \"$STRIP $tempfile -o ${tempfile}.strip\""]
+    if { [lindex $got 0] != 0 || ![string match "" [lindex $got 1]]} then {
+	fail $testname
+    } else {
+	send_log "$READELF -lW ${tempfile}.strip > tmpdir/pr27708.out 2> /dev/null\n"
+	verbose "$READELF -lW ${tempfile}.strip > tmpdir/pr27708.out 2> /dev/null" 1
+	set got [catch "system \"$READELF -lW ${tempfile}.strip > tmpdir/pr27708.out 2> /dev/null\""]
+
+	if { [lindex $got 0] != 0 || ![string match "" [lindex $got 1]]} then {
+	    fail $testname
+	} else {
+	    send_log "cmp tmpdir/pr27708.out $srcdir/$subdir/pr27708.dump\n"
+	    verbose "cmp tmpdir/pr27708.out $srcdir/$subdir/pr26808.dump" 1
+	    set status [remote_exec build cmp "tmpdir/pr27708.out $srcdir/$subdir/pr27708.dump"]
+	    set exec_output [lindex $status 1]
+	    set exec_output [prune_warnings $exec_output]
+
+	    if [string match "" $exec_output] then {
+		pass "strip ($testname)"
+	    } else {
+		send_log "$exec_output\n"
+		verbose "$exec_output" 1
+		fail "strip ($testname)"
+	    }
+	}
+    }
+}
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] elf: Set p_memsz to p_filesz for loadable PT_NOTE segment
  2021-04-08 14:05 [PATCH] elf: Set p_memsz to p_filesz for loadable PT_NOTE segment H.J. Lu
@ 2021-04-14 10:46 ` Nick Clifton
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2021-04-14 10:46 UTC (permalink / raw)
  To: H.J. Lu, binutils

Hi H.J.

> bfd/
> 
> 	PR binutils/27708
> 	* elf.c (assign_file_positions_for_non_load_sections): Set
> 	p_memsz to p_filesz for the loadable PT_NOTE segment.
> 
> binutils/
> 
> 	PR binutils/27708
> 	* testsuite/binutils-all/x86-64/pr27708.dump: New file.
> 	* testsuite/binutils-all/x86-64/pr27708.exe.bz2: Likewise.
> 	* testsuite/binutils-all/x86-64/x86-64.exp: Run binutils/27708
> 	test.

Approved - please apply.

Cheers
   Nick


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-14 10:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 14:05 [PATCH] elf: Set p_memsz to p_filesz for loadable PT_NOTE segment H.J. Lu
2021-04-14 10:46 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).