From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 09A72385F02C for ; Fri, 9 Jul 2021 07:28:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09A72385F02C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pj1-x102f.google.com with SMTP id b5-20020a17090a9905b029016fc06f6c5bso5574279pjp.5 for ; Fri, 09 Jul 2021 00:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=amQTTfIlfNwwmD1xl2QmU7WjdYoa5o+KV4F1ANhvR1Q=; b=HV0lw0QHODhu5nz3Bth2A01dMA/OwcQbbi7L6QiDEsmPAJ11KSobudwiSPY0lyXM9Q TdR2Zy5i8iTNFyD0u0fxI5MJdbehKvgHundbXhffnZlIQyEyZ5PQhKdMaKa47pQxLz7e nI3wCrvGTXlUdD7Q1POBm/uOJqClGK2iRnhFswz6ChoHWcSuD+V8Ss9Bzwc9e4B3ES4h vHG3S+CZpxpf1uwweTMpGcM3KygJhoQr87isx1fCLBNWLt03F9UFPb5McmAjK/ImpklE 5aHYuOYicj8lplGmU2w8YMPTMAcYVKL/wRShjKS6nwI58qCdaRzE+VHV9op+SZkDcePp 81/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=amQTTfIlfNwwmD1xl2QmU7WjdYoa5o+KV4F1ANhvR1Q=; b=aRjR59fkXyDzozv+onN5DTQEt6hkrkt/bUXwou/s3v+bzyCZaAKqJrfZJpgTiDmbjN GzBuZo9n8BCVNkb5cYRCRCydA0hCxF4OmYtLznQAntl+LfLkrNt1azALPuucRAguy+RC a5qjYgdJPbd/9DLptxfes15/C/ly85gFcgtnfCxUNm30oEEWaRlHAEDxI4cv4lWqPjPO qvRBqyuoeOWDyiPIsIvgo7KXdaDuXE4NArxYqfoQN73amEbbhR3vN8FVcplngsj4gsGL 60GWHgczBeXKCn2vr4Ot2AFRbvlg76FxO90lKxRNAAGDN6sKQuBLgppiDy4EAwJuNd2K f1aA== X-Gm-Message-State: AOAM53359Vv9hwUVvng693dRh/neum/5HnwD3AWMXNAnrCKNyhP1jS+U Eh7AyTPadsx7SbjsroRxic7skpuG9kL9B1SS X-Google-Smtp-Source: ABdhPJx9RmG3KPAJ8qJYTh+tBYTeazKojHWptmwDsn9O7xB3y97UC3+Ejrb1YOQvkzOUUXn3/mxrzw== X-Received: by 2002:a17:902:768c:b029:128:b109:d0d8 with SMTP id m12-20020a170902768cb0290128b109d0d8mr29640747pll.19.1625815709915; Fri, 09 Jul 2021 00:28:29 -0700 (PDT) Received: from gamma00.internal.sifive.com ([64.62.193.194]) by smtp.gmail.com with ESMTPSA id l2sm5130900pfc.157.2021.07.09.00.28.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Jul 2021 00:28:29 -0700 (PDT) From: Nelson Chu To: binutils@sourceware.org, gdb-patches@sourceware.org, jimw@sifive.com, andrew.burgess@embecosm.com, kito.cheng@sifive.com, palmer@dabbelt.com, andrew@sifive.com Subject: [PATCH v2 1/3] RISC-V: Enable elf attributes when default configure option isn't set. Date: Fri, 9 Jul 2021 00:28:23 -0700 Message-Id: <20210709072825.13709-2-nelson.chu@sifive.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210709072825.13709-1-nelson.chu@sifive.com> References: <20210709072825.13709-1-nelson.chu@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jul 2021 07:28:35 -0000 Since gcc commit, 3c70b3ca1ef58f302bf8c16d9e7c7bb8626408bf, we now enable elf attributes for all riscv targets by default in gcc. Therefore, I think binutils should have the same behavior, in case users are writing assembly files. ChangLog: binutils/ * testsuite/binutils-all/readelf.s: Add comments for riscv. * testsuite/binutils-all/readelf.s-64: Likewise. * testsuite/binutils-all/readelf.s-64-unused: Likewise. * testsuite/binutils-all/readelf.ss: Likewise. * testsuite/binutils-all/readelf.ss-64: Likewise. * testsuite/binutils-all/readelf.ss-64-unused: Likewise. gas/ * configure.ac: If --enable-default-riscv-attribute isn't set, then we enable the elf attributes for all riscv targets by default. * configure: Regenerated. --- binutils/testsuite/binutils-all/readelf.s | 3 ++- binutils/testsuite/binutils-all/readelf.s-64 | 2 ++ binutils/testsuite/binutils-all/readelf.s-64-unused | 2 ++ binutils/testsuite/binutils-all/readelf.ss | 1 + binutils/testsuite/binutils-all/readelf.ss-64 | 1 + binutils/testsuite/binutils-all/readelf.ss-64-unused | 1 + gas/configure | 9 +-------- gas/configure.ac | 9 +-------- 8 files changed, 11 insertions(+), 17 deletions(-) diff --git a/binutils/testsuite/binutils-all/readelf.s b/binutils/testsuite/binutils-all/readelf.s index 6ae4dc756b9..ff37acb4da8 100644 --- a/binutils/testsuite/binutils-all/readelf.s +++ b/binutils/testsuite/binutils-all/readelf.s @@ -11,9 +11,10 @@ Section Headers: #... +\[ .\] .* +PROGBITS +00000000 0000(3c|40|44|48|50) 0000(04|10) 00 +WA +0 +0 +(.|..) +\[ .\] .* +NOBITS +00000000 0000(40|44|48|4c|60) 000000 00 +WA +0 +0 +(.|..) -# ARM targets put .ARM.attributes here +# ARM targets put .ARM.attributes here. # MIPS targets put .reginfo, .mdebug, .MIPS.abiflags and .gnu.attributes here. # v850 targets put .call_table_data and .call_table_text here. +# riscv targets put .riscv.attributes here. #... +\[..\] .symtab +SYMTAB +00000000 0+.* 0+.* 10 +.. +.+ +4 +\[..\] .strtab +STRTAB +00000000 0+.* 0+.* 00 .* +0 +0 +1 diff --git a/binutils/testsuite/binutils-all/readelf.s-64 b/binutils/testsuite/binutils-all/readelf.s-64 index 92ec05f0376..4c957f7a938 100644 --- a/binutils/testsuite/binutils-all/readelf.s-64 +++ b/binutils/testsuite/binutils-all/readelf.s-64 @@ -14,10 +14,12 @@ Section Headers: +\[ 4\] .bss +NOBITS +0000000000000000 +000000(4c|50|54|58|68) +0000000000000000 +0000000000000000 +WA +0 +0 +.* # x86 targets may put .note.gnu.property here. +# riscv targets put .riscv.attributes here. #... +\[ .\] .symtab +SYMTAB +0000000000000000 +0+.* # aarch64-elf targets have one more data symbol. # x86 targets may have .note.gnu.property. +# riscv targets have .riscv.attributes. +0+.* +0000000000000018 +(6|7) +(3|4) +8 +\[ .\] .strtab +STRTAB +0000000000000000 +0+.* +0+.* +0000000000000000 .* +0 +0 +1 diff --git a/binutils/testsuite/binutils-all/readelf.s-64-unused b/binutils/testsuite/binutils-all/readelf.s-64-unused index a1e6cd1bbd8..771439411a0 100644 --- a/binutils/testsuite/binutils-all/readelf.s-64-unused +++ b/binutils/testsuite/binutils-all/readelf.s-64-unused @@ -14,10 +14,12 @@ Section Headers: +\[ 4\] .bss +NOBITS +0000000000000000 +000000(4c|50|54|58) +0000000000000000 +0000000000000000 +WA +0 +0 +.* # x86 targets may put .note.gnu.property here. +# riscv targets put .riscv.attributes here. #... +\[ .\] .symtab +SYMTAB +0000000000000000 +0+.* # aarch64-elf targets have one more data symbol. # x86 targets may have .note.gnu.property. +# riscv targets have .riscv.attributes. +0+.* +0000000000000018 +(6|7) +(6|7) +8 +\[ .\] .strtab +STRTAB +0000000000000000 +0+.* +0+.* +0000000000000000 .* +0 +0 +1 diff --git a/binutils/testsuite/binutils-all/readelf.ss b/binutils/testsuite/binutils-all/readelf.ss index 5fbb5d002e3..b81c016e9e7 100644 --- a/binutils/testsuite/binutils-all/readelf.ss +++ b/binutils/testsuite/binutils-all/readelf.ss @@ -9,6 +9,7 @@ Symbol table '.symtab' contains .* entries: +.: 00000000 +0 +NOTYPE +LOCAL +DEFAULT +[34] static_data_symbol # v850 targets include extra SECTION symbols here for the .call_table_data # and .call_table_text sections. +# riscv targets add .riscv.attribute symbol here... #... +[0-9]+: 00000000 +0 +NOTYPE +GLOBAL +DEFAULT +1 text_symbol +[0-9]+: 00000000 +0 +NOTYPE +GLOBAL +DEFAULT +UND external_symbol diff --git a/binutils/testsuite/binutils-all/readelf.ss-64 b/binutils/testsuite/binutils-all/readelf.ss-64 index 99a732f71f5..c6ffb0fc523 100644 --- a/binutils/testsuite/binutils-all/readelf.ss-64 +++ b/binutils/testsuite/binutils-all/readelf.ss-64 @@ -7,6 +7,7 @@ Symbol table '.symtab' contains .* entries: #... +.: 0000000000000000 +0 +NOTYPE +LOCAL +DEFAULT +3 static_data_symbol # ... or here ... +# riscv targets add .riscv.attribute symbol here... #... .* +.: 0000000000000000 +0 +NOTYPE +GLOBAL +DEFAULT +1 text_symbol +.: 0000000000000000 +0 +NOTYPE +GLOBAL +DEFAULT +UND external_symbol diff --git a/binutils/testsuite/binutils-all/readelf.ss-64-unused b/binutils/testsuite/binutils-all/readelf.ss-64-unused index f48a4b2bbd2..cf515aa60d0 100644 --- a/binutils/testsuite/binutils-all/readelf.ss-64-unused +++ b/binutils/testsuite/binutils-all/readelf.ss-64-unused @@ -10,6 +10,7 @@ Symbol table '.symtab' contains .* entries: #... +.: 0000000000000000 +0 +NOTYPE +LOCAL +DEFAULT +3 static_data_symbol # ... or here ... +# riscv targets add .riscv.attribute symbol here... #... .* +.: 0000000000000000 +0 +NOTYPE +GLOBAL +DEFAULT +1 text_symbol +.: 0000000000000000 +0 +NOTYPE +GLOBAL +DEFAULT +UND external_symbol diff --git a/gas/configure b/gas/configure index 110d707f079..7a528fd485e 100755 --- a/gas/configure +++ b/gas/configure @@ -12550,14 +12550,7 @@ _ACEOF if test ${ac_default_generate_riscv_attr} = unset; then - case ${target_os} in - elf) - ac_default_generate_riscv_attr=1 - ;; - *) - ac_default_generate_riscv_attr=0 - ;; - esac + ac_default_generate_riscv_attr=1 fi diff --git a/gas/configure.ac b/gas/configure.ac index 78efba88e23..e2374268c56 100644 --- a/gas/configure.ac +++ b/gas/configure.ac @@ -727,14 +727,7 @@ AC_DEFINE_UNQUOTED(DEFAULT_X86_USED_NOTE, properties by default.]) if test ${ac_default_generate_riscv_attr} = unset; then - case ${target_os} in - elf) - ac_default_generate_riscv_attr=1 - ;; - *) - ac_default_generate_riscv_attr=0 - ;; - esac + ac_default_generate_riscv_attr=1 fi AC_DEFINE_UNQUOTED(DEFAULT_RISCV_ATTR, -- 2.30.2