From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id 3C54E3858C60 for ; Fri, 24 Sep 2021 21:47:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3C54E3858C60 From: Hans-Peter Nilsson To: Alan Modra CC: In-Reply-To: (message from Alan Modra via Binutils on Wed, 22 Sep 2021 03:02:27 +0200) Subject: Committed: gas/testsuite/ld-elf/dwarf2-21.d: Pass -W (was: dwarf2 sub-section test) MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: Message-ID: <20210924214736.AD43D203CB@pchp3.se.axis.com> Date: Fri, 24 Sep 2021 23:47:36 +0200 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Sep 2021 21:47:39 -0000 > From: Alan Modra via Binutils > Date: Wed, 22 Sep 2021 03:02:27 +0200 > diff --git a/gas/testsuite/gas/elf/dwarf2-21.d b/gas/testsuite/gas/elf/dwarf2-21.d > new file mode 100644 > index 00000000000..16fa317be66 > --- /dev/null > +++ b/gas/testsuite/gas/elf/dwarf2-21.d > @@ -0,0 +1,18 @@ > +#name: DWARF2 21 > +#as: -gdwarf-2 > +#readelf: -wL ... > +CU: (.*/elf/dwarf2-21|tmpdir/asm)\.s: You (or perhaps I, running my autotester using a long-enough source-path, where this test fails) got bitten by readelf non-wide default re. "CU:" output. The same thing happened to H.J. 2020-12-02; see referred commit and back-and-forth email traffic at the time. Now, can we drop the readelf non-"-W" functionality completely? People can just truncate the output manually. ("Script compatibility" you say? They should be using -W!) Or at least just make -W the default? Or at least drop the quoted "|| strlen (directory) < 76" conditional in binutils/dwarf.c? The following was committed as obvious. ----------- Required for the expected "CU:" to be emitted for long source-paths. See binutils/dwarf.c: if (do_wide || strlen (directory) < 76) printf (_("CU: %s/%s:\n"), directory, file_table[0].name); else printf ("%s:\n", file_table[0].name); See also commit 5f410aa50ce2c, "testsuite/ld-elf/pr26936.d: Pass -W." gas/ChangeLog: * testsuite/ld-elf/dwarf2-21.d: Pass -W. --- gas/testsuite/gas/elf/dwarf2-21.d | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gas/testsuite/gas/elf/dwarf2-21.d b/gas/testsuite/gas/elf/dwarf2-21.d index 16fa317be664..66cd5a95ad13 100644 --- a/gas/testsuite/gas/elf/dwarf2-21.d +++ b/gas/testsuite/gas/elf/dwarf2-21.d @@ -1,6 +1,6 @@ #name: DWARF2 21 #as: -gdwarf-2 -#readelf: -wL +#readelf: -wL -W # Note that non-zero view numbers are allowed here. This doesn't really # make much sense, but DW_LNS_fixed_advance_pc is defined to not set the # view back to zero in contrast with all other changes in PC. A number -- 2.11.0 brgds, H-P