public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Vineet Gupta <vineetg@rivosinc.com>
To: gdb-patches@sourceware.org, binutils@sourceware.org
Cc: Nelson Chu <nelson.chu@sifive.com>,
	Kito Cheng <kito.cheng@sifive.com>, Jim Wilson <jimw@sifive.com>,
	Mike Frysinger <vapier@gentoo.org>,
	Vineet Gupta <vineetg@rivosinc.com>,
	Dylan Reid <dylan@rivosinc.com>
Subject: [PATCH] sim: riscv: fix build breakage with rvv changes
Date: Fri, 29 Oct 2021 12:28:56 -0700	[thread overview]
Message-ID: <20211029192856.3987778-1-vineetg@rivosinc.com> (raw)

changes to gas for riscv vector extensions need to be propagated to sim
otherwise gdb fails to build on users/riscv/binutils-integration-branch

This patch currently applies to that branch.

Fixes: 144cceb058e "(RISC-V/rvv: Add rvv v0.10 instructions.)"
Reported-by: Dylan Reid <dylan@rivosinc.com>
Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
---
 sim/riscv/ChangeLog-2021 | 4 ++++
 sim/riscv/sim-main.c     | 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/sim/riscv/ChangeLog-2021 b/sim/riscv/ChangeLog-2021
index e9aa74490f12..9ced6773bdd6 100644
--- a/sim/riscv/ChangeLog-2021
+++ b/sim/riscv/ChangeLog-2021
@@ -1,3 +1,7 @@
+2021-20-28  Vineet Gupta  <vineetg@rivosinc.com>
+
+	* sim-main.c (step_once): Fix match_func call per gas changes.
+
 2021-07-01  Mike Frysinger  <vapier@gentoo.org>
 
 	* configure: Regenerate.
diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c
index 0faf9395ae52..9b4f7c6c5aad 100644
--- a/sim/riscv/sim-main.c
+++ b/sim/riscv/sim-main.c
@@ -956,6 +956,7 @@ void step_once (SIM_CPU *cpu)
   sim_cia pc = cpu->pc;
   const struct riscv_opcode *op;
   int xlen = RISCV_XLEN (cpu);
+  const char *error = NULL;
 
   if (TRACE_ANY_P (cpu))
     trace_prefix (sd, cpu, NULL_CIA, pc, TRACE_LINENUM_P (cpu),
@@ -985,7 +986,7 @@ void step_once (SIM_CPU *cpu)
   for (; op->name; op++)
     {
       /* Does the opcode match?  */
-      if (! op->match_func (op, iw))
+      if (! op->match_func (op, iw, 0, /* check_constraints */ &error))
 	continue;
       /* Is this a pseudo-instruction and may we print it as such?  */
       if (op->pinfo & INSN_ALIAS)
-- 
2.30.2


             reply	other threads:[~2021-10-29 19:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 19:28 Vineet Gupta [this message]
2021-11-10  0:01 ` Vineet Gupta
2021-11-10  0:02 ` Vineet Gupta
2021-11-10  9:40 ` Andrew Burgess
2021-11-10 17:12   ` Vineet Gupta
  -- strict thread matches above, loose matches on Subject: below --
2021-10-28 20:54 Vineet Gupta
2021-10-29  2:59 ` Nelson Chu
2021-10-29  3:19   ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211029192856.3987778-1-vineetg@rivosinc.com \
    --to=vineetg@rivosinc.com \
    --cc=binutils@sourceware.org \
    --cc=dylan@rivosinc.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jimw@sifive.com \
    --cc=kito.cheng@sifive.com \
    --cc=nelson.chu@sifive.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).