public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] readelf: move FDO_PACKAGING_METADATA note type matching out of core section
@ 2021-12-01 15:44 luca.boccassi
  0 siblings, 0 replies; only message in thread
From: luca.boccassi @ 2021-12-01 15:44 UTC (permalink / raw)
  To: binutils

From: Luca Boccassi <luca.boccassi@microsoft.com>

It's an ELF library/executable note, rather than a core file one

Before:

Displaying notes found in: .note.package
  Owner                Data size 	Description
  FDO                  0x00000039	Unknown note type: (0xcafe1a7e)
    Packaging Metadata: {"type":"deb","name":"fsverity-utils","version":"1.3-1"}

After:

Displaying notes found in: .note.package
  Owner                Data size 	Description
  FDO                  0x00000039	FDO_PACKAGING_METADATA
    Packaging Metadata: {"type":"deb","name":"fsverity-utils","version":"1.3-1"}

Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
The patch on the mailing list shows the right context, maybe some fuzz due to
later merges? Anyway, a simple fix

https://sourceware.org/pipermail/binutils/2021-November/118584.html

 binutils/readelf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/binutils/readelf.c b/binutils/readelf.c
index 92aa788cca1..2225b7d9046 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -19220,8 +19220,6 @@ get_note_type (Filedata * filedata, unsigned e_type)
 	return _("NT_SIGINFO (siginfo_t data)");
       case NT_FILE:
 	return _("NT_FILE (mapped files)");
-      case FDO_PACKAGING_METADATA:
-	return _("FDO_PACKAGING_METADATA");
       default:
 	break;
       }
@@ -19238,6 +19236,8 @@ get_note_type (Filedata * filedata, unsigned e_type)
 	return _("func");
       case NT_GO_BUILDID:
 	return _("GO BUILDID");
+      case FDO_PACKAGING_METADATA:
+	return _("FDO_PACKAGING_METADATA");
       default:
 	break;
       }
-- 
2.30.2


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-12-01 15:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-01 15:44 [PATCH] readelf: move FDO_PACKAGING_METADATA note type matching out of core section luca.boccassi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).