[v2 PATCH 0/1] Fix ld error due to '-shared' not support

[v2 PATCH 0/1] Fix ld error due to '-shared' not support

[jiawei]

When target not support shared lib, these testcases peport error and not
work right. So add check condition in .exp to disable test when shared lib
not support.

V2: Thanks for Nelson Chu's comment! Merge all xfail cases into .exp
file to check.

jiawei (1):
  Fix ld error due to -shared not support.

 ld/testsuite/ld-ctf/ctf.exp    | 5 +++++
 ld/testsuite/ld-plugin/lto.exp | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.25.1

[v2 PATCH 1/1] Fix ld error due to -shared not support.

[jiawei]

ld/ChangeLog:

        * testsuite/ld-ctf/ctf.exp: Add shared lib check.
        * testsuite/ld-plugin/lto.exp: Add lto shared check.

---
 ld/testsuite/ld-ctf/ctf.exp    | 5 +++++
 ld/testsuite/ld-plugin/lto.exp | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/ld/testsuite/ld-ctf/ctf.exp b/ld/testsuite/ld-ctf/ctf.exp
index 0e74d6c569c..7f540072bf9 100644
--- a/ld/testsuite/ld-ctf/ctf.exp
+++ b/ld/testsuite/ld-ctf/ctf.exp
@@ -28,6 +28,11 @@ if ![is_elf_format] {
     return 0
 }
 
+if ![check_shared_lib_support] {
+    unsupported "CTF needs shared lib support"
+    return 0
+}
+
 if {[info exists env(LC_ALL)]} {
     set old_lc_all $env(LC_ALL)
 }
diff --git a/ld/testsuite/ld-plugin/lto.exp b/ld/testsuite/ld-plugin/lto.exp
index 51e01046a12..e63e7916531 100644
--- a/ld/testsuite/ld-plugin/lto.exp
+++ b/ld/testsuite/ld-plugin/lto.exp
@@ -233,7 +233,7 @@ set lto_link_tests [list \
    [list [list "nm" "$plug_opt" "pr26389.d"]]] \
 ]
 
-if { [at_least_gcc_version 10 0] } {
+if { [at_least_gcc_version 10 0] && [check_lto_shared_available] } {
     set lto_link_tests [concat $lto_link_tests [list \
 	[list "pr25355.o" \
 	 "" \
-- 
2.25.1

Re: [v2 PATCH 0/1] Fix ld error due to '-shared' not support

[Jim Wilson]

On Wed, Dec 22, 2021 at 10:20 PM jiawei <jiawei@iscas.ac.cn> wrote:

> jiawei (1):
>   Fix ld error due to -shared not support.
>
>  ld/testsuite/ld-ctf/ctf.exp    | 5 +++++
>  ld/testsuite/ld-plugin/lto.exp | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
>

This looks OK to me.  I don't think --shared is required by the ctf
support, maybe adding that just made the tests easier to write.  Meanwhile,
since they all use --shared it is OK to add the check to verify that
--shared is supported.  And the lto.exp change is trivially correct also.

Another way to fix this is to add the missing newlib support we need to
make riscv*-elf shared library support work, and then we can enable the
linker shared library support for riscv*-elf.  The linker support is fine.
it is just that all --shared tests will fail because of the newlib problem,
which then leads to confusing ld testsuite results.  But fixing newlib is
more of a long term issue, and in the short term we should fix the ld
testsuite.

Jim

Re: [v2 PATCH 0/1] Fix ld error due to '-shared' not support

[Nelson Chu]

On Tue, Dec 28, 2021 at 7:07 AM Jim Wilson <jim.wilson.gcc@gmail.com> wrote:
>
> On Wed, Dec 22, 2021 at 10:20 PM jiawei <jiawei@iscas.ac.cn> wrote:
>>
>> jiawei (1):
>>   Fix ld error due to -shared not support.
>>
>>  ld/testsuite/ld-ctf/ctf.exp    | 5 +++++
>>  ld/testsuite/ld-plugin/lto.exp | 2 +-
>>  2 files changed, 6 insertions(+), 1 deletion(-)
>
>
> This looks OK to me.  I don't think --shared is required by the ctf support, maybe adding that just made the tests easier to write.  Meanwhile, since they all use --shared it is OK to add the check to verify that --shared is supported.  And the lto.exp change is trivially correct also.

Thanks, committed.

> Another way to fix this is to add the missing newlib support we need to make riscv*-elf shared library support work, and then we can enable the linker shared library support for riscv*-elf.  The linker support is fine.  it is just that all --shared tests will fail because of the newlib problem, which then leads to confusing ld testsuite results.  But fixing newlib is more of a long term issue, and in the short term we should fix the ld testsuite.

Yeah, I remember we have similar pr in the sourceware that need to
support riscv shared newlib.
https://sourceware.org/bugzilla/show_bug.cgi?id=25527

Thanks
Nelson
>