From: "H.J. Lu" <hjl.tools@gmail.com>
To: binutils@sourceware.org
Subject: [PATCH] bfd: Don't check non-thin archive member file size
Date: Fri, 24 Dec 2021 15:46:04 -0800 [thread overview]
Message-ID: <20211224234604.229521-1-hjl.tools@gmail.com> (raw)
There is no need to check member file size for thin archive member.
* bfdio.c (bfd_bread): Don't check non-thin archive member file
size.
---
bfd/bfdio.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/bfd/bfdio.c b/bfd/bfdio.c
index 463b3879c52..9aa15c1ffa4 100644
--- a/bfd/bfdio.c
+++ b/bfd/bfdio.c
@@ -231,9 +231,11 @@ bfd_bread (void *ptr, bfd_size_type size, bfd *abfd)
}
offset += abfd->origin;
- /* If this is an archive element, don't read past the end of
+ /* If this is a non-thin archive element, don't read past the end of
this element. */
- if (element_bfd->arelt_data != NULL)
+ if (element_bfd->arelt_data != NULL
+ && element_bfd->my_archive != NULL
+ && !bfd_is_thin_archive (element_bfd->my_archive))
{
bfd_size_type maxbytes = arelt_size (element_bfd);
--
2.33.1
next reply other threads:[~2021-12-24 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 23:46 H.J. Lu [this message]
2021-12-27 6:56 ` Alan Modra
2021-12-27 13:31 ` H.J. Lu
2021-12-28 8:19 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211224234604.229521-1-hjl.tools@gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).