From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 545B6385E82D for ; Wed, 26 Jan 2022 00:19:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 545B6385E82D Received: by mail-pl1-x62c.google.com with SMTP id d7so20916016plr.12 for ; Tue, 25 Jan 2022 16:19:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=zjWh+nJyfY6YGQoKzuG/dd4a1YQE/ogWZhAJaz8m6KM=; b=pCeEaBQnR6NBncrWhzDfnPTNWxaPebTDZZMLy2HrrDWo/s6eFno5BRJFIRI88D820H CVpqo8ed2g4vViZuKjxHlZk9Z22PMYogb2NpoUOCL5eRobmu1oRiAvCWdj3bOeh5LtFW mltbxExMQRpS1B1IoMjOmOKWrolRx0UomNCA13lzpKzhMH5Gq35G6QzdYolg+v4phSNp ttYf8Pr95ec9O6/ZnMGguLDW1GzXeosQbHx/Tcs3xdW8DrWrpPuE4+l4//Pa+RAwTKBu 1i/YzxlgqUGnsAq4tuIV0Z4GjkE1Qjy7J4xsfnP5dRkZEI4V0knjyl48EFDQJmP3T9Zc aF9w== X-Gm-Message-State: AOAM532F2EkdUyEqZshFcim4CFv8oWQpNb3osN9eHceeSRl9/MW8gQHb NCGSlMnf6opBbu+ehoVAzP5IvmEeCAY= X-Google-Smtp-Source: ABdhPJyQk7xqbAWqNVraBr568VkjSjni2ND0fCIzM/6wdppPTtOvu8MdqDBCASkglESyWA07uhP15Q== X-Received: by 2002:a17:902:7b93:b0:14a:c443:bb28 with SMTP id w19-20020a1709027b9300b0014ac443bb28mr7825998pll.94.1643156395233; Tue, 25 Jan 2022 16:19:55 -0800 (PST) Received: from gnu-tgl-3.localdomain ([172.58.35.133]) by smtp.gmail.com with ESMTPSA id d9sm157992pfj.79.2022.01.25.16.19.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 16:19:54 -0800 (PST) Received: from gnu-tgl-3.. (localhost [IPv6:::1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id E14D6C05D9 for ; Tue, 25 Jan 2022 16:19:53 -0800 (PST) From: "H.J. Lu" To: binutils@sourceware.org Subject: [PATCH] elf: Don't set VER_FLG_WEAK Date: Tue, 25 Jan 2022 16:19:53 -0800 Message-Id: <20220126001953.652545-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3028.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2022 00:19:57 -0000 On Solaris, VER_FLG_WEAK indicates a weak version definition with no symbols associated with it. It is used to verify the existence of a particular implementation without any symbol references to the weak version. Don't set VER_FLG_WEAK since it is unused in binutils. PR ld/28814 * elflink.c (bfd_elf_size_dynamic_sections): Don't set VER_FLG_WEAK. --- bfd/elflink.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/bfd/elflink.c b/bfd/elflink.c index 2677561478d..ffb4506958f 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -6921,10 +6921,6 @@ bfd_elf_size_dynamic_sections (bfd *output_bfd, def.vd_version = VER_DEF_CURRENT; def.vd_flags = 0; - if (t->globals.list == NULL - && t->locals.list == NULL - && ! t->used) - def.vd_flags |= VER_FLG_WEAK; def.vd_ndx = t->vernum + (info->create_default_symver ? 2 : 1); def.vd_cnt = cdeps + 1; def.vd_hash = bfd_elf_hash (t->name); -- 2.34.1