Re: [RFC PATCH] bfd: Handle objcopy --only-keep-debug in _bfd_elf_init_private_section_data()

[Peilin Ye <yepeilin.cs@gmail.com>]

Hi Alan,

On Fri, Jan 28, 2022 at 11:22:36PM +1030, Alan Modra wrote:
> Do you have a testcase we could add to the binutils testsuite?

I just added a check [1] to
objcopy.exp:keep_debug_symbols_and_test_copy(), but unfortunately it is
not testing anything:

It seems that --only-keep-debug is broken for Linux kernel .ko modules,
but it works just fine on tmpdir/striprog (built from testprog.c) used
by this testsuite...

I will take another look tomorrow and try to figure out what is so
special about Linux modules, then come up with a better test.  Maybe we
should also mention this in the commit message of the fix.

Thanks,
Peilin Ye
<peilin.ye@bytedance.com>

[1]

diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp
index bb80c1f0b554..1ad90a776c48 100644
--- a/binutils/testsuite/binutils-all/objcopy.exp
+++ b/binutils/testsuite/binutils-all/objcopy.exp
@@ -890,6 +890,8 @@ proc strip_executable_with_saving_a_symbol { prog flags test1 test2 } {
 # Test keeping only debug symbols of an executable

 proc keep_debug_symbols_and_test_copy { prog1 flags1 test1 prog2 flags2 test2 } {
+    global READELF
+
     remote_file build delete tmpdir/striprog
     remote_download build tmpdir/copyprog tmpdir/striprog
     if [is_remote host] {
@@ -898,12 +900,45 @@ proc keep_debug_symbols_and_test_copy { prog1 flags1 test1 prog2 flags2 test2 }
 	set copyfile tmpdir/striprog
     }

+    set non_debug_sections {}
+    if [is_elf_format] {
+        set got [binutils_run $READELF "-S --wide ${copyfile}"]
+        while {[regexp \
+               {[^a-zA-Z]+([a-zA-Z0-9_\.]+)[ \t]+([A-Z]+)[ \t]+[0-9a-f]+ [0-9a-f]+ [0-9a-f]+ [0-9]+[ \t]+([A-Z]*)[ \t]+[0-9]+(.*)} \
+               $got all name type flag rest]} {
+            if {$type != "NOTE" && [regexp {[AG]} $flag]} {
+                lappend non_debug_sections $name
+            }
+            set got $rest
+        }
+    }
+
     set exec_output [binutils_run $prog1 "$flags1 ${copyfile}"]
     if ![string equal "" $exec_output] {
 	fail $test1
 	return
     }
-    pass $test1
+
+    set fails 0
+    if [is_elf_format] {
+        set got [binutils_run $READELF "-S --wide ${copyfile}"]
+        while {[regexp \
+               {[^a-zA-Z]+([a-zA-Z0-9_\.]+)[ \t]+([A-Z]+)[ \t]+[0-9a-f]+ [0-9a-f]+ [0-9a-f]+ [0-9]+[ \t]+[A-Z]*[ \t]+[0-9]+(.*)} \
+               $got all name type rest]} {
+            if {[lsearch -exact $non_debug_sections $name] >= 0 && $type != "NOBITS"} {
+                set fails 1
+                send_log "Expected SHT_NOBITS type for .$name\n"
+            }
+            set got $rest
+        }
+    }
+
+    if {$fails == 0} {
+        pass $test1
+    } else {
+        fail $test1
+        return
+    }

     set exec_output [binutils_run $prog2 "$flags2 ${copyfile}"]
     if ![string equal "" $exec_output] {