From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A8B44385843D for ; Fri, 25 Feb 2022 13:55:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8B44385843D Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-219-26ha-OblMRKUv1Ohp2P7nw-1; Fri, 25 Feb 2022 08:55:31 -0500 X-MC-Unique: 26ha-OblMRKUv1Ohp2P7nw-1 Received: by mail-wm1-f69.google.com with SMTP id n62-20020a1ca441000000b0038124c99ebcso209633wme.9 for ; Fri, 25 Feb 2022 05:55:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CpZ4D0P/PaRttOutN1+3LfF7URVJbZAk1K2xVqEvkMo=; b=Jf21FlNyEITtdK4rt7xN5zA7hc1xhDhhWViofcRO3aWQaRs5jDmEtGpSG2C/DJVl6j RObnSXfi2BdwMkSGPeoB/LTbCcbtx3a+2/NEId3Nj1Wljq5P8ERXExqaI0WYkzecheYO HEUENgS4F+XUmyjDg4GEEm/WsNqD6d+Y/YqRT/CpSMik2PBfiWAdkXw4E82J9Rj/nWOx RI4YOR8SsCvTEbdLmaouoU6wrT1oyAMNJzYVyx/t9FrGOkkoyElMAEVYbWe98xsHCJRP Jp1ans4NFgeYoPB5pKdZA5YLFqx1RMBPlNpDJR93fxuEkK44DbWowbLo/O9b+5sFAYIr ZIBA== X-Gm-Message-State: AOAM530kCy+I9HHB/XzIH03swvnbVvvDSoDIjHIRDkNvnDbtt+6pICR6 7dC4cgl/n7QkbdCCqSsS2tlBY028sKmv2GsQ4aM9GnGKRur9DEto0l4tBYj2yXzUIayfqaCqphB uXcyqr3GCH/x82VdfU51iOvRPp4Yb9ApIM3v+7qYEW/X668ZdTeKWOvDweliCDpHa0kOhxw== X-Received: by 2002:adf:f6d2:0:b0:1ee:6e5:2a0a with SMTP id y18-20020adff6d2000000b001ee06e52a0amr6014538wrp.517.1645797329748; Fri, 25 Feb 2022 05:55:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJzOHdUZ0kSVciyDtjrG2QEeiSmTK529Ij0G506vI6KbZdf47hGo5AWocFho84WNvhhAEwPhng== X-Received: by 2002:adf:f6d2:0:b0:1ee:6e5:2a0a with SMTP id y18-20020adff6d2000000b001ee06e52a0amr6014521wrp.517.1645797329432; Fri, 25 Feb 2022 05:55:29 -0800 (PST) Received: from localhost (host86-169-131-29.range86-169.btcentralplus.com. [86.169.131.29]) by smtp.gmail.com with ESMTPSA id n9-20020a05600c294900b00380f8be8ceesm5774531wmd.20.2022.02.25.05.55.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 05:55:18 -0800 (PST) Date: Fri, 25 Feb 2022 13:54:59 +0000 From: Andrew Burgess To: binutils@sourceware.org Subject: Re: [PATCHv3 0/3] Add Type.is_scalar and Type.is_signed properties Message-ID: <20220225135459.GA124242@redhat.com> References: MIME-Version: 1.0 In-Reply-To: X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 13:54:14 up 14 days, 3:33, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2022 13:55:34 -0000 Apologies, this was sent to the wrong list. Sorry for the noise. Andrew * Andrew Burgess via Binutils [2022-02-25 11:31:09 +0000]: > Thanks for all the feedback on V1, and V2. Additionally, Simon gave > some awesome suggestions on IRC > > The new V3 series is a complete rewrite, main points are: > > - New Type.is_scalar property in patch #1, > > - Now have a Type.is_signed property (patch #2), which is either > True or False. Attempting to read this property on a non-scalar > type will raise a ValueError. > > - Finally, patch #3 adds a test for to cover the 'char' is different > to 'signed char' and 'unsigned char' issue. This characteristic > should be detected by simply comparing types. > > Thoughts? > > Thanks, > Andrew > > --- > > Andrew Burgess (3): > gdb/python: add Type.is_scalar property > gdb/python: add Type.is_signed property > gdb/testsuite: add new test for comparing char types in Python > > gdb/NEWS | 8 +++ > gdb/doc/python.texi | 16 +++++ > gdb/python/py-type.c | 38 ++++++++++++ > gdb/testsuite/gdb.python/py-arch.exp | 15 ++++- > gdb/testsuite/gdb.python/py-type.c | 16 +++++ > gdb/testsuite/gdb.python/py-type.exp | 88 +++++++++++++++++++++++++++- > 6 files changed, 179 insertions(+), 2 deletions(-) > > -- > 2.25.4 >