From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by sourceware.org (Postfix) with ESMTPS id 7F6AC3858D28 for ; Fri, 8 Apr 2022 21:26:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F6AC3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f47.google.com with SMTP id u14so9799420pjj.0 for ; Fri, 08 Apr 2022 14:26:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=85biMRKQpnpvBbsnnhBPxlYxD2RdFiwIr6aBUrXFqvA=; b=I83iOZFwXNRu0VkkSmb/OiV75dIcE0cK6evU501fYzvqQhYN6TmICCymdWXaRC37R1 NI619DNPN+NLUW1dCEs0WrfD9jlD4GPvfBhnGjn0H035Ujp3nSHzdEjKsu4p97jsq7Lu xb9ugjsir4EM0jcul6JhhIGM7MAyjxI2pVPELQfhZp9/0/PIIO9qjyJ49kj3VboSbDUV aGoTq120yBI9E1CRX7/WxZEfGEtpHe7K58APG2nBHOQo5ex1m9Iz1QtzdDXmUrFBnyNi uG/Gv+8J9LEdv+VuhWXtLXDTMJlPHYwFz9xKaZ9AlrdQr6wrVe9KwOVFglCTifhGLAAl q48g== X-Gm-Message-State: AOAM530DI+xWw+oGXqfD9rc6YTrhuB0O4gLFqY1iEFFdx6l/PWe2axer AW79CzzZXfr+IRguA0+2FXpoR7P322k= X-Google-Smtp-Source: ABdhPJxcNI4f+TrljYoG20ID0lxBIlRW1M7DrY5Cp2RcZ9K3MEL/pdyzd2Y/2YSolKxTeNeFeZFAyQ== X-Received: by 2002:a17:902:8b83:b0:155:dcdc:509e with SMTP id ay3-20020a1709028b8300b00155dcdc509emr21557307plb.162.1649453174396; Fri, 08 Apr 2022 14:26:14 -0700 (PDT) Received: from localhost ([2620:15c:2d1:206:5f35:cb12:d8ea:3293]) by smtp.gmail.com with ESMTPSA id f4-20020a056a0022c400b004fb2292cd74sm27520035pfj.206.2022.04.08.14.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 14:26:13 -0700 (PDT) Date: Fri, 8 Apr 2022 14:26:13 -0700 From: Fangrui Song To: Alan Modra Cc: binutils@sourceware.org Subject: Re: [PATCH] gas: copy st_size only if unset Message-ID: <20220408212613.inzusw2b2eved25p@gmail.com> References: <20220331033729.1813121-1-i@maskray.me> <2b2801ff-0bc4-2680-2526-74dd87be3ea0@suse.com> <20220401013343.jeb5ptalaumk7cdq@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2022 21:26:18 -0000 On 2022-04-08, Alan Modra wrote: >Your patch regressed these tests. Please investigate. > >aarch64_be-linux-gnu_ilp32 +FAIL: ELF symbol size >aarch64-elf +FAIL: ELF symbol size >aarch64-linux +FAIL: ELF symbol size >alpha-linux +FAIL: ELF symbol size >alpha-netbsd +FAIL: ELF symbol size >alpha-unknown-freebsd4.7 +FAIL: ELF symbol size >hppa64-hp-hpux11.23 +FAIL: ELF symbol size >hppa64-linux +XPASS: .reloc against undefined local symbol (PR 27228) >hppa-linux +XPASS: .reloc against undefined local symbol (PR 27228) >nds32be-elf +FAIL: readelf -wiaoRlL dw5 >nds32le-linux +FAIL: readelf -wiaoRlL dw5 >riscv32-elf +FAIL: ELF symbol size >riscv64-linux +FAIL: ELF symbol size > >-- >Alan Modra >Australia Development Lab, IBM Sorry for the breakage. a3a7f5e1586467b137b8dcdcd2f74f5efa9f3919 should fix aarch64/alpha/hppa/riscv. I am puzzled by > nds32be-elf +FAIL: readelf -wiaoRlL dw5 > nds32le-linux +FAIL: readelf -wiaoRlL dw5 ../../configure CFLAGS='-O0 -g' CXXFLAGS='-O0 -g' --target=nds32be-elf make -j 50 all-binutils && make -j 50 check-binutils binutils/tmpdir/dw5.o does not change with "gas: copy st_size only if unset" > hppa64-linux +XPASS: .reloc against undefined local symbol (PR 27228) > hppa-linux +XPASS: .reloc against undefined local symbol (PR 27228) I am also puzzled by this. I confirm it passes on --target=hppa64-linux I'll need to investigate it. PS: is there a shortcut than building all-binutils/all-gas with various different --target= (especially these exotic ones like alpha/hppa/nds32)?