From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by sourceware.org (Postfix) with ESMTPS id 98B423858D28 for ; Fri, 8 Apr 2022 23:06:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 98B423858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f178.google.com with SMTP id y8so4495869pfw.0 for ; Fri, 08 Apr 2022 16:06:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kwb+AAEMThiox2P1+RrFa12IAIu9ttxQQsS1+3lvSHs=; b=zRSUxn8MRzuMEojQBOwFaUVLPYC7+Z7vkqMEw1+y0v8r5ewk3jKUwOib0l2lza1+Uj prbuxpgbmr76cQ3b6+o1IUhDeJ9wb3RBG0YSpJDh+FICC+tewFND1A2wA8T/ndpLUC5Q JzrUy6GgPbYw3RcphqfGalrOraScpGC9VFc0GGDlU7ABGIR4GAVblpJZ3vMOttib84/n eKRKAwUScpz8+qoF6qi7JmewMAYLDsto5nnC4biz9CX/nIRVMxzbt+pdSdP/NFCHWhvh Ez5xm2uV0lNJsIepsIFJu7GRdtDet8PBXAI8hQriXSUJjSVwB0OuFFFAAximc7WQk/o5 94+w== X-Gm-Message-State: AOAM533zBwjnduecxYV/t9RlR49HMAdWibgmj9z+hqaaJtG8Xc1RpUea i6FM+CzxHMK2ajO19gOuA+T2D2w/SDY= X-Google-Smtp-Source: ABdhPJxeOXtSXt9E0YPuGzONUnXHKoTc0l4FaOO/nOdCbGP6/ZeGcjCkvoXBL0hp+/6yFHatRBqyYg== X-Received: by 2002:a62:e518:0:b0:4fa:9333:ddbd with SMTP id n24-20020a62e518000000b004fa9333ddbdmr21877215pff.11.1649459181515; Fri, 08 Apr 2022 16:06:21 -0700 (PDT) Received: from localhost ([2620:15c:2d1:206:2daa:126f:86e4:e0a6]) by smtp.gmail.com with ESMTPSA id j13-20020a17090a840d00b001ca89db9e6esm13592535pjn.19.2022.04.08.16.06.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 16:06:21 -0700 (PDT) Date: Fri, 8 Apr 2022 16:06:20 -0700 From: Fangrui Song To: Alan Modra Cc: binutils@sourceware.org Subject: Re: [PATCH] gas: copy st_size only if unset Message-ID: <20220408230620.dvnsidv2tuatw3uw@gmail.com> References: <20220331033729.1813121-1-i@maskray.me> <2b2801ff-0bc4-2680-2526-74dd87be3ea0@suse.com> <20220401013343.jeb5ptalaumk7cdq@gmail.com> <20220408212613.inzusw2b2eved25p@gmail.com> <20220408230113.32uq4vep2b3pq5o6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20220408230113.32uq4vep2b3pq5o6@gmail.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2022 23:06:25 -0000 On 2022-04-08, Fangrui Song wrote: >On 2022-04-08, Fangrui Song wrote: >>On 2022-04-08, Alan Modra wrote: >>>Your patch regressed these tests. Please investigate. >>> >>>aarch64_be-linux-gnu_ilp32 +FAIL: ELF symbol size >>>aarch64-elf +FAIL: ELF symbol size >>>aarch64-linux +FAIL: ELF symbol size >>>alpha-linux +FAIL: ELF symbol size >>>alpha-netbsd +FAIL: ELF symbol size >>>alpha-unknown-freebsd4.7 +FAIL: ELF symbol size >>>hppa64-hp-hpux11.23 +FAIL: ELF symbol size >>>hppa64-linux +XPASS: .reloc against undefined local symbol (PR 27228) >>>hppa-linux +XPASS: .reloc against undefined local symbol (PR 27228) >>>nds32be-elf +FAIL: readelf -wiaoRlL dw5 >>>nds32le-linux +FAIL: readelf -wiaoRlL dw5 >>>riscv32-elf +FAIL: ELF symbol size >>>riscv64-linux +FAIL: ELF symbol size >>> >>>-- >>>Alan Modra >>>Australia Development Lab, IBM >> >>Sorry for the breakage. a3a7f5e1586467b137b8dcdcd2f74f5efa9f3919 should fix aarch64/alpha/hppa/riscv. >>I am puzzled by >> >>>nds32be-elf +FAIL: readelf -wiaoRlL dw5 >>>nds32le-linux +FAIL: readelf -wiaoRlL dw5 > >OK, I think this is related to Nick's >19c26da69d68d5d863f37c06ad73ab6292d02ffa >("Add code to display the contents of .debug_loclists sections which contain offset entry tables.") > >There is a diagnostic which has moved from somewhere in the middle to >the top: > > readelf: Warning: unable to apply unsupported type 208 to section .debug_loclists > >Adding #... as the first line will fix the test for nds32*, but I am >unsure whether the test should be adjusted to unsupport nds32*. > >>../../configure CFLAGS='-O0 -g' CXXFLAGS='-O0 -g' --target=nds32be-elf >>make -j 50 all-binutils && make -j 50 check-binutils >>binutils/tmpdir/dw5.o does not change with "gas: copy st_size only if unset" >> >>>hppa64-linux +XPASS: .reloc against undefined local symbol (PR 27228) >>>hppa-linux +XPASS: .reloc against undefined local symbol (PR 27228) >> >>I am also puzzled by this. I confirm it passes on --target=hppa64-linux >>I'll need to investigate it. I have tested that the XPASS->PASS is unrelated to this particular gas patch. >> >>PS: is there a shortcut than building all-binutils/all-gas with various >>different --target= (especially these exotic ones like >>alpha/hppa/nds32)?