From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 732363858C2C for ; Sat, 16 Apr 2022 17:48:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 732363858C2C Received: by mail-pl1-x633.google.com with SMTP id be5so9383020plb.13 for ; Sat, 16 Apr 2022 10:48:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=LCkN7jg8trelZsxvoKd6ftqjlJufiyJhfOVrKqLtuHE=; b=3G4QXCwAnj3WLvsLTzvQ8A7EgpBiXjfrtqsBgZ1iSL7gMTaEOYpN20c5gAF9TLdNQ4 jpjXvcL8Mcw3GTDehngyfv60NI+sMHlWnrf2s9wu7VOmCMM8ux3fpj5qGC3C3NtFl7pq 64giW3YrkNSn0o0LmZnsAdKKFwrM2mELMHIIbYfSGZ+DCfG8fANdFjGvPmQdf54LEM5t q48sw89s9bdGVjNKKcrtYVGebYm6y9qkBNvT83xTyKjhbbdrTATCkZPy4ceXZm4kblse N2Gq8BpfjaZy/lHABI5OCt/vqZZ4QeNKCDGZ0Iye6U8+Vr+zXH4VN41xVc/tyYXEfTF4 ZTtg== X-Gm-Message-State: AOAM533RXb5ThlVX/Zocm8sFzerbmHWofJpGaQrk1POgXyj9P1xIaZiL vrCKZTqzYuPAVy38BMCEl81Mo+xfWWA= X-Google-Smtp-Source: ABdhPJxh/wMnxC6lXMEESGEtxAAofqHWIsujG85C9O3Bwu3EJSqTfeZh3fEg+YMmlPhxv831vl3aog== X-Received: by 2002:a17:903:204:b0:157:e00:e0b2 with SMTP id r4-20020a170903020400b001570e00e0b2mr4428999plh.118.1650131323220; Sat, 16 Apr 2022 10:48:43 -0700 (PDT) Received: from gnu-tgl-3.localdomain ([172.58.35.133]) by smtp.gmail.com with ESMTPSA id g12-20020a056a001a0c00b004e1307b249csm6918952pfv.69.2022.04.16.10.48.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Apr 2022 10:48:42 -0700 (PDT) Received: from gnu-tgl-3.. (localhost [IPv6:::1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id A7769C011C for ; Sat, 16 Apr 2022 10:48:41 -0700 (PDT) From: "H.J. Lu" To: binutils@sourceware.org Subject: [PATCH] as: Reject unknown -gXXX option Date: Sat, 16 Apr 2022 10:48:41 -0700 Message-Id: <20220416174841.2450010-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3027.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Apr 2022 17:48:46 -0000 * as.c (parse_args): Reject unknown -gXXX option. * testsuite/gas/all/empty.s: New file. * testsuite/gas/all/pr29067.d: Likewise. * testsuite/gas/all/pr29067.err: Likewise. * testsuite/gas/all/gas.exp: Run pr29067. --- gas/as.c | 2 ++ gas/testsuite/gas/all/empty.s | 1 + gas/testsuite/gas/all/gas.exp | 1 + gas/testsuite/gas/all/pr29067.d | 2 ++ gas/testsuite/gas/all/pr29067.err | 2 ++ 5 files changed, 8 insertions(+) create mode 100644 gas/testsuite/gas/all/empty.s create mode 100644 gas/testsuite/gas/all/pr29067.d create mode 100644 gas/testsuite/gas/all/pr29067.err diff --git a/gas/as.c b/gas/as.c index f320bac89b5..0262a6fec98 100644 --- a/gas/as.c +++ b/gas/as.c @@ -836,6 +836,8 @@ This program has absolutely no warranty.\n")); versions/sections/options. */ if (startswith (old_argv[optind - 1], "-gdwarf")) as_fatal (_("unknown DWARF option %s\n"), old_argv[optind - 1]); + else if (old_argv[optind - 1][1] == 'g' && optarg != NULL) + as_fatal (_("unknown option `%s'"), old_argv[optind - 1]); if (md_debug_format_selector) debug_type = md_debug_format_selector (& use_gnu_debug_info_extensions); diff --git a/gas/testsuite/gas/all/empty.s b/gas/testsuite/gas/all/empty.s new file mode 100644 index 00000000000..6ac6c76e752 --- /dev/null +++ b/gas/testsuite/gas/all/empty.s @@ -0,0 +1 @@ +/* Empty input. */ diff --git a/gas/testsuite/gas/all/gas.exp b/gas/testsuite/gas/all/gas.exp index ae7957b2ee0..db927121f63 100644 --- a/gas/testsuite/gas/all/gas.exp +++ b/gas/testsuite/gas/all/gas.exp @@ -506,3 +506,4 @@ run_dump_test "pr27384" run_dump_test "pr27381" run_dump_test "multibyte1" run_dump_test "multibyte2" +run_dump_test "pr29067" diff --git a/gas/testsuite/gas/all/pr29067.d b/gas/testsuite/gas/all/pr29067.d new file mode 100644 index 00000000000..17a8eefe454 --- /dev/null +++ b/gas/testsuite/gas/all/pr29067.d @@ -0,0 +1,2 @@ +#as: -gsomething-not-already-a-long-option +#error_output: pr29067.err diff --git a/gas/testsuite/gas/all/pr29067.err b/gas/testsuite/gas/all/pr29067.err new file mode 100644 index 00000000000..e5a1b27d644 --- /dev/null +++ b/gas/testsuite/gas/all/pr29067.err @@ -0,0 +1,2 @@ +Assembler messages: +Fatal error: unknown option `-gsomething-not-already-a-long-option' -- 2.35.1