From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by sourceware.org (Postfix) with ESMTPS id 788793858C56 for ; Sat, 23 Apr 2022 21:50:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 788793858C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f176.google.com with SMTP id g9so10214721pgc.10 for ; Sat, 23 Apr 2022 14:50:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KJsr4C/2bjV80GSi8ASEbfhd5ndcOGYgfczeigc/hgk=; b=aRKvWueHW3hNsYXBE47PjwNp2TqhrSGcxHh5tVKBlpWywUJ4+g8qvGY+KCe1SXJwC/ SAS7TdIyxvnac+eSlatg73uVln2GEk2lycFHwuKwUHyP0OfABT803SapFxd5tdTo8fXd Ev4mMiuY2oP44cPwgLiD/X22uAOydeEXB5otq/kQLrt/y3Af/fvdKIf7eXC98QjlRuu8 ecFYE+5PtpKCqXAl58Ant1o84PooxOQqslxxc02j9Nl1iPjwYYCod9bBqYBXSZ7DCYpi KmPoiC8i14MknJWn3418+l2JsW7IlLO8JDYcvGXvV5Q6hHwcfevTrmn2L2AUza4yOlxe Z/Tg== X-Gm-Message-State: AOAM530XvVz4rEtjhCCvzjdd3T5Mgu9OHRYsrp0SIGINy+PQxPRz+9QY wqj+9qSB4PgL6h0NH+ZAp+OtX3Z5cY0= X-Google-Smtp-Source: ABdhPJzgHi0fm2SrZhE6s8aUlJjnHxwyEbMZAnWJn1JMUQFlUTRJSuNby9TspUXhibTDmI7ozrgA1Q== X-Received: by 2002:a63:185f:0:b0:386:1838:8d0 with SMTP id 31-20020a63185f000000b00386183808d0mr9283344pgy.161.1650750638530; Sat, 23 Apr 2022 14:50:38 -0700 (PDT) Received: from localhost ([2601:647:6300:b760:2799:dcd2:d943:7605]) by smtp.gmail.com with ESMTPSA id u9-20020a17090a4bc900b001d26f134e43sm10401917pjl.51.2022.04.23.14.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 14:50:38 -0700 (PDT) Date: Sat, 23 Apr 2022 14:50:37 -0700 From: Fangrui Song To: Alan Modra Cc: Luis Machado , binutils@sourceware.org Subject: Re: [PATCH, v2] [AArch64] Support AArch64 MTE memory tag dumps in core files Message-ID: <20220423215037.xopkysk3ugbkbqkm@gmail.com> References: <20220331140457.9237-1-luis.machado@arm.com> <20220421151841.127371-1-luis.machado@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Apr 2022 21:50:40 -0000 On 2022-04-23, Alan Modra via Binutils wrote: >On Thu, Apr 21, 2022 at 04:18:41PM +0100, Luis Machado wrote: >> v2: >> >> - Drop arch-specific fields from the generic section data structure. >> - Use the rawsize field of the section structure to store the original >> memory range of the memory-tagged area. >> - Implement the bfd_elf_modify_headers for aarch64, to adjust the values >> for the memory tag segment according to the Linux Kernel's format. > >This looks OK to me, except for defining PT_ARM_MEMTAG_MTE in >elf/common.h. That belongs in elf/aarch64.h. BTW, why isn't the >header called PT_AARCH64_MEMTAG_MTE? Using PT_ARM_ looks odd, >considering that we already have PT_ARM_EXIDX at LOPROC+1. Agree PT_LOPROC+1 is strange.