From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by sourceware.org (Postfix) with ESMTPS id D036B3856DD0 for ; Wed, 4 May 2022 14:37:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D036B3856DD0 From: Hans-Peter Nilsson To: Alan Modra CC: , In-Reply-To: (message from Alan Modra on Wed, 4 May 2022 10:39:58 +0200) Subject: Re: [PATCH] Don't define ARCH_cris for BFD64 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20220504075628.81292-1-luis.machado@arm.com> <88ada15d-c371-df10-368e-f1c9fb91c289@arm.com> Message-ID: <20220504143703.58AD620462@pchp3.se.axis.com> Date: Wed, 4 May 2022 16:37:03 +0200 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 14:37:06 -0000 > From: Alan Modra > Date: Wed, 4 May 2022 10:39:58 +0200 > On Wed, May 04, 2022 at 09:15:43AM +0100, Luis Machado wrote: > > On 5/4/22 09:08, Alan Modra wrote: > > > On Wed, May 04, 2022 at 08:56:28AM +0100, Luis Machado via Binutils wrote: > > > > I believe it is a mistake to define ARCH_cris when BFD64 is defined. It is > > > > a 32-bit architecture, so should be placed outside of the BFD64 block. > > > > > > No. cris may be 32-bit but the bfd support requires a 64-bit bfd. > > > See config.bfd. > > > > > > > Interesting, I missed that. So I suppose GDB will need to move these cris > > files from ALL_TARGET_OBS to ALL_64_TARGET_OBS. > > > > I see opcodes/Makefile.am also puts the cris files into > > TARGET32_LIBOPCODES_CFILES. Is that a mistake? > > Hmm, maybe config.bfd is wrong. I see cris files in bfd/Makefile.am > BFD32_BACKENDS. Hans-Peter, do you know what is going on here? I didn't remember that I had changed anything 32/64-related in that area, so I had to consult git blame. The most recent change I did was in 2017, so whatever 32/64-changes is probably related to 56fbd041853a "Fix gas/22304 by forcing a 64-bit bfd for cris*-*" (TL;DR: expressions overflow). That commit *could* be slightly wrong; perhaps it shouldn't be wrapped in #ifdef BFD64? Adding CRIS files to BFD32_BACKENDS happened when the port was added, back in 2000. If it's wrong for a 32-bit target to be there, then I don't want to be right! :) brgds, H-P