From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 9447C385B801 for ; Fri, 13 May 2022 08:58:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9447C385B801 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson-pc (unknown [111.9.175.10]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9AxatjEHX5iLBwUAA--.3052S2; Fri, 13 May 2022 16:58:46 +0800 (CST) Date: Fri, 13 May 2022 16:58:44 +0800 From: Huang Pei To: WANG Xuerui Cc: Zhensong Liu , binutils , Chenghua Xu Subject: Re: [PATCH 2/2] partial revert 5a91f93b983184c64b3a9332f5f4339d17941d76 Message-ID: <20220513085844.6hrozjcce4ifnjjv@loongson-pc> References: <20220513013523.85151-1-huangpei@loongson.cn> <20220513013523.85151-2-huangpei@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CM-TRANSID: AQAAf9AxatjEHX5iLBwUAA--.3052S2 X-Coremail-Antispam: 1UD129KBjvJXoWxJr17Jr15AFyDJw4rZrykAFb_yoW8Aw1rpr yUCFW5KF1xXFs0qr98Ja4rWF9Iqrs7Kr1Y9r1ftw40kr98GryUuw10qrW3ZF4jqryxZ34S vFWFv3ZxZa1DZFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyv14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvEwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1l42xK82IYc2Ij64vIr41l 4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67 AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8I cVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI 8IcIk0rVW3JVWrJr1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AK xVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUj6pB7UUUUU== X-CM-SenderInfo: xkxd0whshlqz5rrqw2lrqou0/ X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_NUMSUBJECT, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2022 08:58:50 -0000 On Fri, May 13, 2022 at 09:55:23AM +0800, WANG Xuerui wrote: Hi, Resend them with another thread, since the subject changed > Hi, > > On 5/13/22 09:35, Huang Pei wrote: > > set elf_backend_default_execstack=0 on loongarch > > Please provide reasons for the change; while I and other people familiar > with those lower-level details can somehow guess it's because contemporary > architectures really prefer non-executable stacks by default, for enhancing > security, it's better to be explicit. > > Plus, please format the subject lines of both your patches, so they conform > to the repo's conventions. I think they should look like "LoongArch: Do foo" > or "bfd: LoongArch: Do foo", looking at a few recent commits on various > components. > > > --- > > bfd/elfnn-loongarch.c | 1 + > > ld/testsuite/ld-elf/elf.exp | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c > > index e4cd9fa107e..94c8e8269d3 100644 > > --- a/bfd/elfnn-loongarch.c > > +++ b/bfd/elfnn-loongarch.c > > @@ -130,6 +130,7 @@ struct loongarch_elf_link_hash_table > > #define elf_backend_got_header_size (GOT_ENTRY_SIZE * 1) > > #define elf_backend_want_dynrelro 1 > > +#define elf_backend_default_execstack 0 > > /* Generate a PLT header. */ > > diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp > > index ebb5ba090bf..e33a0d08831 100644 > > --- a/ld/testsuite/ld-elf/elf.exp > > +++ b/ld/testsuite/ld-elf/elf.exp > > @@ -186,6 +186,7 @@ proc target_defaults_to_execstack {} { > > || [istarget "*-*-nacl"] > > || [istarget "arc*-*-*"] > > || [istarget "ia64*-*-*"] > > + || [istarget "loongarch*-*-*"] > > || [istarget "nios2*-*-*"] > > || [istarget "powerpc64*-*-*"] > > || [istarget "riscv*-*-*"]