From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by sourceware.org (Postfix) with ESMTPS id 3BDB838560B4 for ; Wed, 25 May 2022 06:57:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3BDB838560B4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f180.google.com with SMTP id f21so6089108pfa.3 for ; Tue, 24 May 2022 23:57:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=arQgMHLWLRiq/YuN1+TLouq0ei9hrHp8hSIWtD/PS2Q=; b=2FYXJLv7oWUy8WELju7CP4h/EzRmxPhd9DPT69WAIo3j0b4p9d/htBxPuX6K4c+ggP HFW/ELTiSREwklMjPfUn9FRJPSQcGsbN7R3YI05P3jFDoq9aoF67U/tmw2B89Zhk0KC4 UtEuNFLrbUZmzZsCRGw9b92CP2gG/y9O1YB+jYoHSvBKHL0aW13BsMmEBmfGgG9Ya9hN UzcB3ze6zicKCQuYtnFZYNSklrnv3T1Zoy7N/Y7fMg7hCc/X6yhcuRsMEOyn3ez86C0B FU8BaqdqSzrfqQHs3YwTaG/3srP+QN4GQ3tcdueTtdWNsMgDZOX9+wjlX2IQrOiodYkT +wtw== X-Gm-Message-State: AOAM532YtVxpEB+SogOJNJDv1rY+RI4xcllpUYpGv5HbxeP7Fs4vT7LF nK4v2Gzi+eZ+SAdXZ9PvA4xtP638Wh4= X-Google-Smtp-Source: ABdhPJwDOusodYiSf6+JNzUz/RqsoCEJy+UOE5wog2+ZkG7xaUw0iqRctwM68VA/nf/PYjL+Rt/3wQ== X-Received: by 2002:a65:528a:0:b0:3c6:d2e6:e3a0 with SMTP id y10-20020a65528a000000b003c6d2e6e3a0mr27427550pgp.159.1653461820229; Tue, 24 May 2022 23:57:00 -0700 (PDT) Received: from localhost ([2601:647:6300:b760:99a0:91d1:ce56:27fc]) by smtp.gmail.com with ESMTPSA id ds12-20020a17090b08cc00b001dcf9fe5cddsm878676pjb.38.2022.05.24.23.56.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 23:56:59 -0700 (PDT) Date: Tue, 24 May 2022 23:56:58 -0700 From: Fangrui Song To: Luca Boccassi Cc: Florian Weimer , binutils@sourceware.org Subject: Re: [PATCH] ld: add --package-metadata Message-ID: <20220525065658.mxvpugjgnh3dt7de@gmail.com> References: <20220515191846.114257-1-luca.boccassi@gmail.com> <20220516164003.iivw6lthknhvce42@gmail.com> <87o7zwwv9m.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 06:57:05 -0000 On 2022-05-17, Luca Boccassi via Binutils wrote: >On Tue, 17 May 2022 at 07:03, Florian Weimer wrote: >> >> * Fangrui Song: >> >> > Both the "FDO" and the json dependency make me concerned - >> > if a linker script approach works quite well, why bother with a new >> > linker option with a very specific application? >> >> The linker script does not work all that well because it requires that >> the script is materialized to disk somewhere, and that path needs to >> show up in the build flags. If the build flags are stored beyond the >> build for future use, this makes them invalid because the path will >> typically be gone by the time the stored flags are used. >> >> Thanks, >> Florian Do you mean that a user may need to re-link the executable/shared object? The note content must be preserved somewhere, I don't see how as ... -o meta.o ld.bfd ... meta.o is more inconvenient than ld.bfd --package-meta='content' ... The "FDO" owner also makes me concerned. It seems a bit arbitrary. https://src.fedoraproject.org/rpms/package-notes/pull-request/2#comment-98855 (tstellar) says "Given, that I'm the maintainer of lld in Fedora, if I volunteer to deal with issues that stem from this assembler based implementation would you be more likely to accept this patch?" It would be nice to have a list of packages and fix them (perhaps issues like not honor LDFLAGS). I left a comment on https://github.com/rui314/mold/issues/505#issuecomment-1136277017 as well. >Indeed, it was working fine as an initial step to get the ball rolling and >the spec adopted, but having to generate and reference an >intermediate, temporary asset is not great and has drawbacks. Now >that the spec is live and proven in production in Fedora 36 it seemed >to me like a good time to introduce a first-class option, to make further >usage and adoption as trivial as it can be. > >Kind regards, >Luca Boccassi