From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by sourceware.org (Postfix) with ESMTPS id 8D8B3382F9B4 for ; Thu, 26 May 2022 23:20:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8D8B3382F9B4 From: Hans-Peter Nilsson To: Subject: [COMMITTED] cris: bfd: Correct default to no execstack MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-ID: <20220526232049.7365120439@pchp3.se.axis.com> Date: Fri, 27 May 2022 01:20:49 +0200 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 23:20:51 -0000 In the now-historical CRIS glibc port, the default stack permission was no-exec as in "#define DEFAULT_STACK_PERMS (PF_R|PF_W)", and the gcc port only emits the executable-stack marker when needed; when emitting code needing it. In other words, the binutils setting mismatches. It doesn't matter much, except being confusing and defaulting to "off" is more sane. ld: * testsuite/ld-elf/elf.exp (target_defaults_to_execstack): Switch to 0 for cris*-*-*. bfd: * elf32-cris.c (elf_backend_default_execstack): Define to 0. Change-Id: I52f37598f119b19111c7a6546c00a627fca0f396 --- bfd/elf32-cris.c | 2 ++ ld/testsuite/ld-elf/elf.exp | 1 + 2 files changed, 3 insertions(+) diff --git a/bfd/elf32-cris.c b/bfd/elf32-cris.c index 00b5f7745e89..653d77f1ea84 100644 --- a/bfd/elf32-cris.c +++ b/bfd/elf32-cris.c @@ -4112,6 +4112,8 @@ elf_cris_got_elt_size (bfd *abfd ATTRIBUTE_UNUSED, #define elf_backend_dtrel_excludes_plt 1 #define elf_backend_want_dynrelro 1 +#define elf_backend_default_execstack 0 + /* Later, we my want to optimize RELA entries into REL entries for dynamic linking and libraries (if it's a win of any significance). Until then, take the easy route. */ diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp index 621d4e121d74..abc35f807782 100644 --- a/ld/testsuite/ld-elf/elf.exp +++ b/ld/testsuite/ld-elf/elf.exp @@ -183,6 +183,7 @@ if { [check_gc_sections_available] && ![istarget "v850-*-*"] } { proc target_defaults_to_execstack {} { if { [istarget "aarch64*-*-*"] || [istarget "arc*-*-*"] + || [istarget "cris*-*-*"] || [istarget "ia64*-*-*"] || [istarget "nios2*-*-*"] || [istarget "powerpc64*-*-*"] -- 2.30.2 brgds, H-P