From: Fangrui Song <maskray@google.com>
To: binutils@sourceware.org, Szabolcs Nagy <szabolcs.nagy@arm.com>
Subject: [PATCH] arm: Define elf_backend_extern_protected_data to 0
Date: Wed, 1 Jun 2022 21:27:15 -0700 [thread overview]
Message-ID: <20220602042715.2999013-1-maskray@google.com> (raw)
From: Fangrui Song <i@maskray.me>
If an executable has copy relocations for extern protected data, that
can only work if the library containing the definition is built with
assumptions (a) the compiler emits GOT-generating relocations (b) the
linker produces R_*_GLOB_DAT instead of R_*_RELATIVE. Otherwise the
library uses its own definition directly and the executable accesses a
stale copy.
Commit b68a20d6675f1360ea4db50a9835c073675b9889 changed ld to produce
R_ARM_GLOB_DAT but that defeated the purpose of protected visibility
as an optimization. Restore the previous behavior (which matches
ld.lld) by defining elf_backend_extern_protected_data to 0.
---
bfd/elf32-arm.c | 2 +-
ld/testsuite/ld-arm/protected-data.d | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
index 5b8f5e5a0e6..36f09cb3427 100644
--- a/bfd/elf32-arm.c
+++ b/bfd/elf32-arm.c
@@ -20315,7 +20315,7 @@ elf32_arm_backend_symbol_processing (bfd *abfd, asymbol *sym)
#define elf_backend_dtrel_excludes_plt 1
#define elf_backend_got_header_size 12
-#define elf_backend_extern_protected_data 1
+#define elf_backend_extern_protected_data 0
#undef elf_backend_obj_attrs_vendor
#define elf_backend_obj_attrs_vendor "aeabi"
diff --git a/ld/testsuite/ld-arm/protected-data.d b/ld/testsuite/ld-arm/protected-data.d
index 3f266dea1b4..7dffe9ab958 100644
--- a/ld/testsuite/ld-arm/protected-data.d
+++ b/ld/testsuite/ld-arm/protected-data.d
@@ -2,4 +2,4 @@
#ld: -shared
#readelf: -r -W
#...
-.* R_ARM_GLOB_DAT .* var.*
+.* R_ARM_RELATIVE .*
--
2.36.1.255.ge46751e96f-goog
next reply other threads:[~2022-06-02 4:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 4:27 Fangrui Song [this message]
2022-06-23 3:38 ` Fangrui Song
2022-06-23 8:21 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602042715.2999013-1-maskray@google.com \
--to=maskray@google.com \
--cc=binutils@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).