From: ruud.vanderpas@oracle.com
To: binutils@sourceware.org
Subject: [PATCH] gprofng: fix bug 29351 - Move dynamic loading of modules to a later stage
Date: Fri, 22 Jul 2022 09:17:03 -0700 [thread overview]
Message-ID: <20220722161703.1974478-1-ruud.vanderpas@oracle.com> (raw)
From: Ruud van der Pas <ruud.vanderpas@oracle.com>
gprofng/Changelog:
2022-07-22 Ruud van der Pas <ruud.vanderpas@oracle.com>
* gp-display-html/gp-display-html.in: the dynamic loading of
modules occurred too early, resulting in the generation of the
man page to fail in case a module is missing; the loading part is
now done somewhat later in the execution to avoid this problem.
---
gprofng/gp-display-html/gp-display-html.in | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/gprofng/gp-display-html/gp-display-html.in b/gprofng/gp-display-html/gp-display-html.in
index 54a87d7a3c7..9b207b99aa8 100644
--- a/gprofng/gp-display-html/gp-display-html.in
+++ b/gprofng/gp-display-html/gp-display-html.in
@@ -8852,6 +8852,8 @@ sub handle_module_availability
{
my $subr_name = get_my_name ();
+ gp_message ("verbose", $subr_name, "Handling module requirements");
+
#------------------------------------------------------------------------------
# This is clunky at best, but there is a chicken egg problem here. For the
# man page to be generated, the --help and --version options need to work,
@@ -8868,7 +8870,9 @@ sub handle_module_availability
"List::Util",
"Cwd",
"File::Basename",
+ "File::stat",
"POSIX",
+ "bigint",
"bignum");
my @missing_modules = ();
@@ -8895,12 +8899,17 @@ sub handle_module_availability
{
$cmd = $m . "->import ( qw (min max))";
}
+ elsif ($m eq "bigint")
+ {
+ $cmd = $m . "->import ( qw (hex))";
+ }
else
{
$cmd = $m . "->import";
}
$cmd .= ";";
$result = eval ("$cmd");
+ gp_message ("debugM", $subr_name, "cmd = $cmd");
}
else
{
--
2.27.0
reply other threads:[~2022-07-22 16:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722161703.1974478-1-ruud.vanderpas@oracle.com \
--to=ruud.vanderpas@oracle.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).