From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 7A1063858403 for ; Mon, 25 Jul 2022 07:52:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A1063858403 Received: by mail-pg1-x532.google.com with SMTP id bh13so9677271pgb.4 for ; Mon, 25 Jul 2022 00:52:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yUcPRdohu7HrgEnRu+JEoP+lvxxegfnbXj0rsKevYxY=; b=NPK+duDYgUWF0St6zEfmnJMs9k9TAOkD+obEeQ0fckJWV3rztHDkQ0GJGYyaGVlJfW vv6cITdHR91l8pVxfvWBzuQPOr+p8YOVwyO5PplFQkyDDO9oXfkchAQrKA+3hEDMdm65 ujSkMriFBS/NJzfoHmiLPqfaE5XCgZTiNM3H8jX7TsREE70AGO6ylAv6nGVk/kmWuggz PwgQQBFYidHJFt1a75PJiwF4y6rMXhL6YUr97xPlg/4YMyijo34kifu2I+lFBLVn6D3o DR6+7ZeJvh1GHtsM+4zuTXmdEo0OtvTocKpGKMhti7ifx3SWs86XjAGYWgqs8JzanoPK 1+Nw== X-Gm-Message-State: AJIora+SXbTT/kCt+fjkczW++sPb1Qbr8Me8P7Fr5wL1FBqtz/gLsMMs uk9cgpu6mTaQMG3iMAVQvBsIsu6ZC2NT7Q== X-Google-Smtp-Source: AGRyM1vjX3Y/TAZQFfu+40okw4m6ybyqj8NVDssuurD/oUJYDK27uSoNHdFqvB5Q+fvj8yVy+wlcOA== X-Received: by 2002:a65:6c05:0:b0:41a:d13f:f0fb with SMTP id y5-20020a656c05000000b0041ad13ff0fbmr8115930pgu.393.1658735519233; Mon, 25 Jul 2022 00:51:59 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:7188:e2ed:3bfc:d34d]) by smtp.gmail.com with ESMTPSA id f26-20020a631f1a000000b00415320bc31dsm7679981pgf.32.2022.07.25.00.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jul 2022 00:51:58 -0700 (PDT) Date: Mon, 25 Jul 2022 00:51:53 -0700 From: Fangrui Song To: liuzhensong Cc: WANG Xuerui , binutils@sourceware.org, xry111@xry111.site, caiyinyu@loongson.cn, chenglulu@loongson.cn, mengqinggang@loongson.cn, xuchenghua@loongson.cn Subject: Re: [PATCH] LoongArch: Set defaults to exec stack 0. Message-ID: <20220725075153.p2vlgb6sckham2lp@google.com> References: <20220725022227.16266-1-liuzhensong@loongson.cn> <94ed682f-1b36-0fe1-7383-19657fa33468@xen0n.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <94ed682f-1b36-0fe1-7383-19657fa33468@xen0n.name> X-Spam-Status: No, score=-27.4 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 07:52:01 -0000 On 2022-07-25, WANG Xuerui wrote: >On 2022/7/25 10:22, liuzhensong wrote: >>--- >> bfd/elfnn-loongarch.c | 1 + >> ld/testsuite/ld-elf/elf.exp | 1 + >> 2 files changed, 2 insertions(+) >> >>diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c >>index 4efe3d9370c..43182ead8cd 100644 >>--- a/bfd/elfnn-loongarch.c >>+++ b/bfd/elfnn-loongarch.c >>@@ -132,6 +132,7 @@ struct loongarch_elf_link_hash_table >> #define elf_backend_want_dynrelro 1 >> #define elf_backend_rela_normal 1 >>+#define elf_backend_default_execstack 0 >> /* Generate a PLT header. */ >>diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp >>index 10c635e9593..b8829b4e3ee 100644 >>--- a/ld/testsuite/ld-elf/elf.exp >>+++ b/ld/testsuite/ld-elf/elf.exp >>@@ -187,6 +187,7 @@ proc target_defaults_to_execstack {} { >> || [istarget "nios2*-*-*"] >> || [istarget "powerpc64*-*-*"] >> || [istarget "riscv*-*-*"] >>+ || [istarget "loongarch*-*-*"] >> || [istarget "tilegx*-*-*"] >> || [istarget "tilepro*-*-*"] } { >> return 0 >Looks good to me. I don't know why this isn't the case from the >beginning... I'll test on Gentoo shortly after. LGTM. Add loongarch before nios2 for an alphabetical order.