From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id 108483858415 for ; Sat, 24 Sep 2022 07:13:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 108483858415 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-pj1-x1034.google.com with SMTP id go6so1949321pjb.2 for ; Sat, 24 Sep 2022 00:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=iUwadJp5Rh9blxO/Io3yVEfCJVMX2OthfEspdYeW7qw=; b=BrkKQJE+hTXOVVT1QeGQLnzpN5tmIfBobMR6tXHIC2EEbUkJtNKr3qmZxAt8ZPZsRo jwXx4Q9xOMzkvOpS580DLFHHDQki+nQ/hGzkybiSKqbsjiuzlnUOb1/d5vV1Sm7HzG3C +4KMNgRFDU/Jdapjjd4iIBsemV+yzRkxAwDizKpCHGpQsv8QS/3KSYtWmdcmeqiX/54P VzrZgOfHXTECWyFDOScUywuvbF8E5ZLcy3CQRaLfxrSz0XSVYWdEtwgcNavrSEswSheQ C9C3JOyn+WrZwgRwGM+pYoaqjo7kipjx63R5xEmL/OL/GqJFgmK0+vSOmwagg3TuLhIy 32IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=iUwadJp5Rh9blxO/Io3yVEfCJVMX2OthfEspdYeW7qw=; b=RsQNNojGXcPX6bicf88P+PnPViJagLQkdCgzKp/15cUbbXDeyZbcnK1RL5LTXyRSI+ klVWZGqwHTaB37Xf9Tq8ot9+yCAKvZbNbl+tj0J4fQKOSxRdb5UPQ/d+KFvVSkpt4zl3 1nS/EOhNNkSKcc/veNb2Y4DCB7iAbG4qAvR6dSOX47efCmstTM34qGiJOQ9RDv20yKys A3vCghP1vFreVyc0tnLMQZzAyGfu1eGBoT2UNDALNg7JKGoeHNTq+7WR6ECP1n2/MqGl 9HwoJUDUMHDEC3eWUtBfMb436NbWdqH7gQH74j/3F1UWrFLZwUkKwFERjxLMNJ6yadTt 7z0A== X-Gm-Message-State: ACrzQf3aqGKXXZhoDAdM7l7q80LZPVbrDwIPKt5WnHiHJPpxaxZVfo+d nM+kqvubfySmTfvHLJHPaef5oA== X-Google-Smtp-Source: AMsMyM7m97KVFKV/epX59axHLWkCBzMRh/9gGagaFAErmUblSF5BjBqP5WAbo2/98aSS/RfHTIUNMg== X-Received: by 2002:a17:90b:1c82:b0:1ee:eb41:b141 with SMTP id oo2-20020a17090b1c8200b001eeeb41b141mr14050002pjb.143.1664003621914; Sat, 24 Sep 2022 00:13:41 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:8ec5:9ef2:91c2:62b8]) by smtp.gmail.com with ESMTPSA id m15-20020a17090a2c0f00b001fb53587166sm2688932pjd.28.2022.09.24.00.13.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Sep 2022 00:13:40 -0700 (PDT) Date: Sat, 24 Sep 2022 00:13:37 -0700 From: Fangrui Song To: Enze Li Cc: Fangrui Song via Gdb-patches , Alan Modra , Jan Beulich , Nick Clifton , Simon Marchi , binutils@sourceware.org Subject: Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections Message-ID: <20220924071337.6shhf26p7vbqkcjj@google.com> References: <20220923040837.550160-1-maskray@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-19.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-09-24, Enze Li wrote: >Hi Fangrui, > >One nit, maybe not an important one. > >A proper committed message should include a link to the relevant bug on >Bugzilla. Like this, > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29563 > >For more detail, see here[1]. > >[1] https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages > >Thanks, >Enze Hi Enze, Thanks for the notice. I see that gdb started to use "Bug:" since 2021-07. In binutils, there isn't such a convention and there is no commit using "Bug:". So I will keep using the umbrella link PR29397. I am on the fence whether the gdb one needs to use "Bug:" but I'll probably not use it this time. Ideally the gdb patch should be separate, but since the bfd's zstd dependency needs gdb build system's cooperation it is placed in the same patch:) I am still waiting for an approval from binutils side. Relatedly, I believe ChangeLog is no longer strictly enforced. There are many recent commits don't using ChangeLog. I intentionally skip ChangeLog for this patch since I believe it would provide little value. (I see "ANNOUNCEMENT: ChangeLog policy change after GDB 11".)