From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 5C7303858CDA for ; Mon, 26 Sep 2022 14:11:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C7303858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x431.google.com with SMTP id t14so10411119wrx.8 for ; Mon, 26 Sep 2022 07:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=GmF4Z4xdZaNaSU3Q4K2Xtm8W0/vcybEmYq9M524d/68=; b=G4rxlMdvl/nDVYcnwLi9YGTceF8d0HMSegJcF53YfdhtzYyt/KYe/imJakb8HC+2s4 kgvI84VlB4TYb0hVVkz3VcMLUUaCbevEstyfDFDannbyUyX9ASQ0SqV0/bGdgAf3aWpD cUrjGzzRsbF06wI4BLyRBVAyi5BInGyEP6irxoWfxdNSSxTfT4gpXHnsqjkAzFeX3JaK EQ09Gwp9oayqy0OhX6ybWez0kGZlX6x1QH5aXA6AxyEU140eTyOC751zRUnMoBD6amwp d9cjOR3ypS+GLfYbhMnGBYiW6g/3RMRHT8ZTWFooyi2mj5RQ5/1VAYQUNABEH9S3cLqH HV6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=GmF4Z4xdZaNaSU3Q4K2Xtm8W0/vcybEmYq9M524d/68=; b=GamnYWAEiPo74s0eAVmLKgmoQNbVizSa2ve77bFLnq+14cgvNSWcfqZJsveUcvcPkP JCG7hNpmGmqvqMXaFsHDM0TXl27/oYXMOd5En9ylP4JWMgU1FhJDMjnNEE2P9/u97haB B8fjS3e3JZ89z9L6bshYETibmZAK3B80Ss+p1jmY4dcO4d8mIH+YZz05HlHYKSTiIQvT oBQK8ukyo3wi4Pwmd2NGbGV8Chrf7ep5hrwllIQMeCHtPBlp15RxK5tiSieuORiIdCIc 74m5aAUyYG7Ye7G1yk0AhCDmousGfWJCe9eVqXn8RSs5z3G5fB38ERkQ0oB7HrarO+Jk 1Rdg== X-Gm-Message-State: ACrzQf2guUzRUKjU13VdUtuX9QAP1FxJvNBgQlmMRiDwZwTNZPlh9p49 6usRReTcWPyvdxCUTJQnCHjB1wRuBTQBow== X-Google-Smtp-Source: AMsMyM6Qv9LKzHlPFrKuQwUN0NSvSojIzw1/RV6HEPOAQX2ljIoVm9UVGFLvsVJx4jF8YRLUUYevXg== X-Received: by 2002:adf:df82:0:b0:228:e2cf:d20f with SMTP id z2-20020adfdf82000000b00228e2cfd20fmr14631441wrl.356.1664201471937; Mon, 26 Sep 2022 07:11:11 -0700 (PDT) Received: from chigot-Dell.home ([2a01:cb15:8123:8100:b332:e6c2:bee9:735]) by smtp.gmail.com with ESMTPSA id b4-20020a5d4b84000000b0022b11a27e39sm14371665wrt.1.2022.09.26.07.11.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 07:11:09 -0700 (PDT) From: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= To: binutils@sourceware.org Cc: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= Subject: [PATCH] binutils/testsuite: skip gentestdlls related tests if missing Date: Mon, 26 Sep 2022 16:11:00 +0200 Message-Id: <20220926141100.163950-1-chigot@adacore.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When launching the testsuite through runtest outside the build tree, gentestdlls might not be available, this binary being created by make check. Simply untested the related tests instead of crashing. binutils/ChangeLog: * testsuite/binutils-all/objdump.exp: Skip dotnet tests if gentestdlls is not available. --- binutils/testsuite/binutils-all/objdump.exp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp index fb099425e34..436fc46d1a8 100644 --- a/binutils/testsuite/binutils-all/objdump.exp +++ b/binutils/testsuite/binutils-all/objdump.exp @@ -787,6 +787,12 @@ proc test_objdump_dotnet_assemblies {} { set test "dotnet-assemblies" + # If gentestdlls isn't available, skip instead of crashing below. + if ![file exists $base_dir/testsuite/gentestdlls] { + untested $test + return + } + set got [binutils_run "$base_dir/testsuite/gentestdlls" "tmpdir pei-i386 pei-x86-64"] set want "wrote linux-pei-x86-64.dll" # The test program is hardcoded to generate valid dlls on any target -- 2.25.1