From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 193963858283 for ; Wed, 28 Sep 2022 13:36:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 193963858283 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x434.google.com with SMTP id v28so7007725wrd.3 for ; Wed, 28 Sep 2022 06:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=pWmYl5mer/iD+2E/17+WE2rBaK+fUbouAnXfJ2MMbHQ=; b=KTE6Q2KQ7deJezntebayCwmulNcFqaskfHoJByfwp+HfnWuTNPnRL2sntsup1iuy10 vDOSZsVX/oJMT+ofe+ArnYLxyMOl3hHdQP64QvnP8MxbHTKeHEVfL0r4HXrxqmkzDtmp w9jN4S1SEDHZJPBp+hN/DlSGuwg/EsFmVHpsWwrKa0PUL55sXe8vOjKLNsOQPOV5lXU8 G7GJKQexe1thJsFTewvaCy3D9Q/vgi9zWxhJP1mjOR5lqdamjJGfVzIdRw1/4gY1pi4n DXz0QKDm8QntlHvq4vhXiAkhGGsnqMUHcJfNhGiw7mmoXJXY46BWfy3aHBLFBbMdTijg 3xCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=pWmYl5mer/iD+2E/17+WE2rBaK+fUbouAnXfJ2MMbHQ=; b=beKVH3WWtPETfoT77zJgeA4vy05pzNnXSPccVW9XHtMops7pBs6lgVoKXrHrdKJMDo 7bwY9fDnfXrqqRsxLfn+ZIeH3VhASRmNtL6FHzUVHy6V1T71O6MPUkbjzdjntwyvfb7o d1eNsg8ATeJDATkMeBaADLByBfYKbxhk3x69uGVZegnA90R+SwypnZxMeZYgM3m5XJuX +jd5P/kUSo7DvUtr9EQ5cIUfNTngzqS7JQUClXsij6bs54dhmOLhYOutUbR0qpznQdP/ WxpJYCEPHXoVo9ZRJxaysGhrW8pY6ozw5o/Ih4LSSpJ+rCcX/HyFcCOswf7FlJBkn76W WeMQ== X-Gm-Message-State: ACrzQf0KSBXWZY6OnWp7wMa4/FKNyri5hbaA4i5vs3BYLbmfFSLNDt5P Mj2VPT8LxfEsVLbRFhcu7Bm1Umcv+Bi4Hw== X-Google-Smtp-Source: AMsMyM4S+/ggLtqf8FisKzFmFEmUj0DrdT/VV4WjR/zyHqeGS2hNcrgJxYcIuAxLto5zrRFHKHq2Kg== X-Received: by 2002:adf:e4ca:0:b0:228:d8b7:48a7 with SMTP id v10-20020adfe4ca000000b00228d8b748a7mr20173224wrm.300.1664372162763; Wed, 28 Sep 2022 06:36:02 -0700 (PDT) Received: from chigot-Dell.home ([2a01:cb15:8123:8100:99e:1de:cde0:1810]) by smtp.gmail.com with ESMTPSA id n2-20020adffe02000000b0022ac119fcc5sm2310409wrr.60.2022.09.28.06.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 06:36:02 -0700 (PDT) From: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= To: binutils@sourceware.org, nickc@redhat.com Cc: amodra@gmail.com, =?UTF-8?q?Cl=C3=A9ment=20Chigot?= Subject: [RFC] ld/testsuite: force warnings when dealing with execstack tests Date: Wed, 28 Sep 2022 15:35:43 +0200 Message-Id: <20220928133542.471998-1-chigot@adacore.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Nick, I've already raised the issue sometimes back inside a more general patch. But with Alan, we weren't sure this was the good approach. This test might also be there to ensure that warnings are printed by default with a configuration not disabling them. Thus, I'm resubmitting it as RFC. --- Binutils can be configured to avoid printing the execstack or RWD segment warnings. In this case, the first test of PR ld/29072 will fail. Fix that by always manually forcing the warnings for it. ld/ChangeLog: * testsuite/ld-elf/elf.exp (PR ld/29072): Force execstack and RWD segment warnings. --- ld/testsuite/ld-elf/elf.exp | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp index 64b1d34f055..ad5bcb87cf1 100644 --- a/ld/testsuite/ld-elf/elf.exp +++ b/ld/testsuite/ld-elf/elf.exp @@ -237,18 +237,9 @@ if { [istarget *-*-*linux*] return $text } - # The HPPA target disables the warnings by default since it needs an - # executable stack to support older kernels and an RWX segment to - # support its PLT. MIPS also turns off exec stack warnings. - if { [istarget "hppa*-*-*"] || [istarget mips*-*-*] } { - set extra_link_opts "--warn-execstack --warn-rwx-segments" - } else { - set extra_link_opts "" - } - run_ld_link_tests [list \ [list "PR ld/29072 (warn about an executable .note.GNU-stack)" \ - "-e 0 $extra_link_opts" \ + "-e 0 --warn-execstack --warn-rwx-segments" \ "" \ "" \ {pr29072-a.s} \ -- 2.25.1