From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id A1EE63858016 for ; Wed, 28 Sep 2022 14:12:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A1EE63858016 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x435.google.com with SMTP id v28so7174047wrd.3 for ; Wed, 28 Sep 2022 07:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=pogX79nw+2v6HdskKx0IEehM3YVk+pm52ka7VTvo4nQ=; b=L+TLy6emMjoJ5oSs56xWyC/kTa7vdpqlaGS9N5uiJjl+J+mb7qhczewpd3oDZFzxJE aMFrAcBjj0UhGol4LUhgqP6Gr2sqjespiZz926RRGBo1EFmGofxmaViVCIy5l/ymnC4z J+Qjv8qb/tyW9qaObNboWCCS3lk4HElTVBP+4M+rCR8kcPnyXlxcRTiP7aJ/Lglfy3K7 Y5jyf813iK8sa5WvDLbMbAqDBo8tjm2wGmcEmLgDqUlCOCmo8aU4H9783SQkNG4gQ+mz jmi5qhG1CW/4xRMP2YLtJYhSVS3Y6p5Ohs8LdON7hvHCT6zknEo+HL4rWZ3Q21tjkStf QENQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=pogX79nw+2v6HdskKx0IEehM3YVk+pm52ka7VTvo4nQ=; b=3w6QD+Eh5SHJvA02WyzflwxsSjffVtzOeG1w4Qmt/uPoIGQJFiPprWa7gGncurS802 eV4kqAkujJGp41z03qRw/MDO61O4IJp7qp6WuZF9QJrcRAa09IuMNrY9pVNdybr/h/Ui d1XYUiACmqw95YMxOGd9Wx+4+PSLNa6gVTzRJYN/sLz2CHjBCzVVPQ1J8fzvNM0veYLl u3H3Ixq+sYiRvxGAP+iEKrfa715e8oYp9tLtjym1vwA5QMIMQijnpm9wG9wcVuB55Tfe LK+Sa+CDq6EdYutAqxXp1OE4EOwNHyC7rtt7Usrs3WLXSVJZyr0SoZmXM35hUls+ooEq D0zg== X-Gm-Message-State: ACrzQf1R4vu3I2iTO0BxcdFV63POXokCpASxiUFE1epcAh676+8ckjfm Tv4vKClhm0k+EgG7k9ppA9+r1Mdkqt/S7w== X-Google-Smtp-Source: AMsMyM5xl8cJaUJYkngZSoEf4QmBzUfKLO7cAoV10r17CwkliKbErdVM9Dp0A04+7tUPDJoByN2+Bg== X-Received: by 2002:adf:a55e:0:b0:22c:c6fd:a4bd with SMTP id j30-20020adfa55e000000b0022cc6fda4bdmr3015923wrb.29.1664374324304; Wed, 28 Sep 2022 07:12:04 -0700 (PDT) Received: from chigot-Dell.home ([2a01:cb15:8123:8100:99e:1de:cde0:1810]) by smtp.gmail.com with ESMTPSA id k1-20020a5d5181000000b00228da845d4dsm4325363wrv.94.2022.09.28.07.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 07:12:03 -0700 (PDT) From: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= To: binutils@sourceware.org, nickc@redhat.com Cc: amodra@gmail.com, =?UTF-8?q?Cl=C3=A9ment=20Chigot?= Subject: [PATCH v2] ld/testsuite: force warnings when dealing with execstack tests Date: Wed, 28 Sep 2022 16:11:50 +0200 Message-Id: <20220928141150.641012-1-chigot@adacore.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Binutils can be configured to avoid printing the execstack or RWD segment warnings. In this case, the first test of PR ld/29072 will fail. Fix that by always manually forcing the warnings for it. ld/ChangeLog: * testsuite/ld-elf/elf.exp (PR ld/29072): Force execstack and RWD segment warnings. --- ld/testsuite/ld-elf/elf.exp | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp index 64b1d34f055..e4d8bee2f53 100644 --- a/ld/testsuite/ld-elf/elf.exp +++ b/ld/testsuite/ld-elf/elf.exp @@ -237,18 +237,11 @@ if { [istarget *-*-*linux*] return $text } - # The HPPA target disables the warnings by default since it needs an - # executable stack to support older kernels and an RWX segment to - # support its PLT. MIPS also turns off exec stack warnings. - if { [istarget "hppa*-*-*"] || [istarget mips*-*-*] } { - set extra_link_opts "--warn-execstack --warn-rwx-segments" - } else { - set extra_link_opts "" - } - + # Since the warnings can be disabled by configure, ensure consistency + # of the first test by forcing the flags. run_ld_link_tests [list \ [list "PR ld/29072 (warn about an executable .note.GNU-stack)" \ - "-e 0 $extra_link_opts" \ + "-e 0 --warn-execstack --warn-rwx-segments" \ "" \ "" \ {pr29072-a.s} \ -- 2.25.1