From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] diagnostics.h: GCC 13 got -Wself-move, breaks GDB build
Date: Mon, 3 Oct 2022 16:24:59 +0200 [thread overview]
Message-ID: <20221003142459.ycyca7z6crdiq37y@lug-owl.de> (raw)
In-Reply-To: <670fd724-f14f-565f-b4a1-5883a8a1b5ab@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
On Mon, 2022-10-03 14:49:55 +0100, Nick Clifton <nickc@redhat.com> wrote:
> Hi Jan-Benedict,
>
> > +# if __GNUC__ >= 13
> > +# define DIAGNOSTIC_IGNORE_SELF_MOVE DIAGNOSTIC_IGNORE ("-Wself-move")
> > +# endif
>
> There appears to be a convention that the definition should be broken
> up over two lines, ie:
>
> # if __GNUC__ >= 13
> # define DIAGNOSTIC_IGNORE_SELF_MOVE \
> DIAGNOSTIC_IGNORE ("-Wself-move")
> # endif
All the others would exceed some 80 columns and this macro, for the
`if defined (__clang__)` case, is also provided in one line.
> Although DIAGNOSTIC_ERROR_SWITCH appears to be the exception to this rule.
No, `DIAGNOSTIC_IGNORE_SELF_MOVE` is already existing (for __clang__)
and not wrapped there as well.
> More importantly however, you need to provide an empty definition at the
> end of the file should the macro not be defined. ie:
>
> #ifndef DIAGNOSTIC_IGNORE_SELF_MOVE
> # define DIAGNOSTIC_IGNORE_SELF_MOVE
> #endif
That's already in place, see (after patch) at around line 115.
MfG, JBG
--
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2022-10-03 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 18:54 Jan-Benedict Glaw
2022-10-03 13:49 ` Nick Clifton
2022-10-03 14:24 ` Jan-Benedict Glaw [this message]
2022-10-03 14:36 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221003142459.ycyca7z6crdiq37y@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).