On Mon, 2022-10-03 14:49:55 +0100, Nick Clifton wrote: > Hi Jan-Benedict, > > > +# if __GNUC__ >= 13 > > +# define DIAGNOSTIC_IGNORE_SELF_MOVE DIAGNOSTIC_IGNORE ("-Wself-move") > > +# endif > > There appears to be a convention that the definition should be broken > up over two lines, ie: > > # if __GNUC__ >= 13 > # define DIAGNOSTIC_IGNORE_SELF_MOVE \ > DIAGNOSTIC_IGNORE ("-Wself-move") > # endif All the others would exceed some 80 columns and this macro, for the `if defined (__clang__)` case, is also provided in one line. > Although DIAGNOSTIC_ERROR_SWITCH appears to be the exception to this rule. No, `DIAGNOSTIC_IGNORE_SELF_MOVE` is already existing (for __clang__) and not wrapped there as well. > More importantly however, you need to provide an empty definition at the > end of the file should the macro not be defined. ie: > > #ifndef DIAGNOSTIC_IGNORE_SELF_MOVE > # define DIAGNOSTIC_IGNORE_SELF_MOVE > #endif That's already in place, see (after patch) at around line 115. MfG, JBG --