From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lug-owl.de (lug-owl.de [188.68.32.151]) by sourceware.org (Postfix) with ESMTPS id 9BF433858D38; Mon, 3 Oct 2022 14:25:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9BF433858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lug-owl.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lug-owl.de Received: by lug-owl.de (Postfix, from userid 1001) id F07DC4203D; Mon, 3 Oct 2022 16:24:59 +0200 (CEST) Date: Mon, 3 Oct 2022 16:24:59 +0200 From: Jan-Benedict Glaw To: Nick Clifton Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] diagnostics.h: GCC 13 got -Wself-move, breaks GDB build Message-ID: <20221003142459.ycyca7z6crdiq37y@lug-owl.de> References: <20221002185433.gl7dvytfh5wthifx@lug-owl.de> <670fd724-f14f-565f-b4a1-5883a8a1b5ab@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hj5d6v25q7tddvdn" Content-Disposition: inline In-Reply-To: <670fd724-f14f-565f-b4a1-5883a8a1b5ab@redhat.com> X-Operating-System: Linux chamaeleon 5.14.0-0.bpo.2-amd64 X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-message-flag: Please send plain text messages only. Do not send HTML emails. Thank you. User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --hj5d6v25q7tddvdn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, 2022-10-03 14:49:55 +0100, Nick Clifton wrote: > Hi Jan-Benedict, >=20 > > +# if __GNUC__ >=3D 13 > > +# define DIAGNOSTIC_IGNORE_SELF_MOVE DIAGNOSTIC_IGNORE ("-Wself-move") > > +# endif >=20 > There appears to be a convention that the definition should be broken > up over two lines, ie: >=20 > # if __GNUC__ >=3D 13 > # define DIAGNOSTIC_IGNORE_SELF_MOVE \ > DIAGNOSTIC_IGNORE ("-Wself-move") > # endif All the others would exceed some 80 columns and this macro, for the `if defined (__clang__)` case, is also provided in one line. > Although DIAGNOSTIC_ERROR_SWITCH appears to be the exception to this rule. No, `DIAGNOSTIC_IGNORE_SELF_MOVE` is already existing (for __clang__) and not wrapped there as well. > More importantly however, you need to provide an empty definition at the > end of the file should the macro not be defined. ie: >=20 > #ifndef DIAGNOSTIC_IGNORE_SELF_MOVE > # define DIAGNOSTIC_IGNORE_SELF_MOVE > #endif That's already in place, see (after patch) at around line 115. MfG, JBG --=20 --hj5d6v25q7tddvdn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCYzrwuwAKCRAdvV51g5nh u4CfAJ4viV83984hu2Nr7PGWs6So0ka2NgCfWkFpkRX8WhsNbic2abZIld+o07k= =FBJQ -----END PGP SIGNATURE----- --hj5d6v25q7tddvdn--