From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacsray@gmail.com>
Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175])
	by sourceware.org (Postfix) with ESMTPS id 7F5893858C60
	for <binutils@sourceware.org>; Fri, 11 Nov 2022 03:27:43 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F5893858C60
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-pg1-f175.google.com with SMTP id h193so3379651pgc.10
        for <binutils@sourceware.org>; Thu, 10 Nov 2022 19:27:43 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-disposition:mime-version:message-id:subject:cc:to:from:date
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=Xks7kYR7L0uEhJv6+QZC8bHLZE4/g95xhewh6kM8qNY=;
        b=xpgk9GMKsQClw1pdyP63laX9VdlS1+RawaUPgYMtknCgwLV4lw5l44jBvBlXGGGOXN
         Gal88XMqxFSoTwKOF9yUNtoQ4cVDbQJrW56rOCu3UJ/5d7O2umtEx3h6hJsUVLSOtMk/
         UWbs/a5y5r1Xrf6DVnxkQIhL95my4NsOLu8MddhVmEZqPwx92n9dUCCxoNwhePSvBmvr
         BeVXEW7o4wgx/UlbxsexFnqjm4JubKKLC7En2ieDUICEdVT17Fbcymhvpp5x2HarzwCa
         7kA93SmH48RH46SK9ssVVq028IOz5JD+aKAdOEhxALqhBfI3El71/MdowZd8/MkOE2ve
         XBJA==
X-Gm-Message-State: ACrzQf0TdUZPLWb5BdtfVSPbC/s8aCL3RnZTWlwsj8HQmJYOYqz3H2Qu
	1VPE9zbyCPzAjquKTWteFebzlBCu/40=
X-Google-Smtp-Source: AMsMyM5i+vwKAUeWBFP1GCYWn9GR+kg4il5MSY+bqnZz14B6LngSJl5XtAuPN3I9m0Tq3f5GRmn3jQ==
X-Received: by 2002:a63:151e:0:b0:46e:f011:9563 with SMTP id v30-20020a63151e000000b0046ef0119563mr4498684pgl.451.1668137262080;
        Thu, 10 Nov 2022 19:27:42 -0800 (PST)
Received: from localhost ([2601:647:6300:b760:303b:3a1e:6768:4f7d])
        by smtp.gmail.com with ESMTPSA id p22-20020a1709027ed600b00187197c499asm439930plb.164.2022.11.10.19.27.41
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 10 Nov 2022 19:27:41 -0800 (PST)
Date: Thu, 10 Nov 2022 19:27:40 -0800
From: Fangrui Song <i@maskray.me>
To: binutils@sourceware.org
Cc: harald@gigawatt.nl
Subject: foo (VER_NDX_GLOBAL) and foo@@v1 in one DSO
Message-ID: <20221111032740.edekvhgrceu6frws@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

Hello, I find a strange use of VER_NDX_GLOBAL and look forward to your thoughts.

cat > a.s <<e
.globl foo
.symver foo, foo@@@v1
foo:
   nop
   ret

.globl foo_compat
.symver foo_compat, foo@, remove
foo_compat:
   ret
e
cat > a.ver <<e
v1 {};
e
cat > b.c <<e
extern void foo(void);
int main(void) { foo(); }
e

gcc -fuse-ld=bfd -shared -nostdlib -Wl,--version-script=a.ver a.s -o a.so
gcc -fuse-ld=bfd -g b.c ./a.so -o b

exit

In a.so, we have a default version foo@@v1 as well as a VER_NDX_GLOBAL foo.
The VER_NDX_GLOBAL foo is unusual.

```
% readelf -W --dyn-s -V a.so

Symbol table '.dynsym' contains 4 entries:
    Num:    Value          Size Type    Bind   Vis      Ndx Name
      0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND
      1: 0000000000001000     0 NOTYPE  GLOBAL DEFAULT    7 foo@@v1
      2: 0000000000001002     0 NOTYPE  GLOBAL DEFAULT    7 foo
      3: 0000000000000000     0 OBJECT  GLOBAL DEFAULT  ABS v1

Version symbols section '.gnu.version' contains 4 entries:
  Addr: 0x000000000000028e  Offset: 0x00028e  Link: 3 (.dynsym)
   000:   0 (*local*)       2 (v1)            1h                2 (v1)

Version definition section '.gnu.version_d' contains 2 entries:
  Addr: 0x0000000000000298  Offset: 0x000298  Link: 4 (.dynstr)
   000000: Rev: 1  Flags: BASE  Index: 1  Cnt: 1  Name: a.so
   0x001c: Rev: 1  Flags: none  Index: 2  Cnt: 1  Name: v1
```

There are two strange things:

* foo is a VER_NDX_GLOBAL VERSYM_HIDDEN symbol (shown as `1h`). Is this an expected use case?
* foo co-exist with foo@@v1. Is this an expected use case?

In my understanding, when a stem symbol has a @ form, the unversioned VER_NDX_GLOBAL form cannot exist.
In the example above, `.symver foo_compat, foo@v0, remove` would be fine.

The above is reduced from a real world case of https://github.com/libfuse/libfuse/blob/fuse_2_9_bugfix/lib/fuse.c#L4955
`FUSE_SYMVER(".symver fuse_new_compat2,fuse_new@");`

% readelf -W --dyn-s /lib/x86_64-linux-gnu/libfuse.so.2 G fuse_new
    200: 00000000000148b0    72 FUNC    GLOBAL DEFAULT   13 fuse_new@FUSE_2.5
    201: 0000000000014870    16 FUNC    GLOBAL DEFAULT   13 fuse_new                      # this is VERSYM_HIDDEN
    202: 0000000000014750     8 FUNC    GLOBAL DEFAULT   13 fuse_new@@FUSE_2.6
    203: 0000000000014860    11 FUNC    GLOBAL DEFAULT   13 fuse_new@FUSE_2.2
    216: 0000000000014880    35 FUNC    GLOBAL DEFAULT   13 fuse_new_compat1@@FUSE_2.2
    218: 0000000000014870    16 FUNC    GLOBAL DEFAULT   13 fuse_new_compat2@@FUSE_2.2
    228: 0000000000014860    11 FUNC    GLOBAL DEFAULT   13 fuse_new_compat22@@FUSE_2.5
    230: 00000000000148b0    72 FUNC    GLOBAL DEFAULT   13 fuse_new_compat25@@FUSE_2.6