From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id D19D23854178 for ; Fri, 11 Nov 2022 05:34:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D19D23854178 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-pf1-x42a.google.com with SMTP id y203so4029716pfb.4 for ; Thu, 10 Nov 2022 21:34:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9kO2fvcNlORmr5refp3iQX7iAtXLZBD9fVphyJARhX8=; b=p1v57G4XJznakUZYcUtOzqrsPutHlF2FSsdHelNZNsuFBWp8GiFkgYJUPQ7vzlqYTo htK64/M4/HDMQr/YVKgmpOXZ3hXYSdV9oTVULYUN+FbLFZ941QDmfvpuHqgLCvyKJc/Q Z36xLDv6YbESmDsxgxpSGEw3RJhcQsvTelMJVg62Hilk4GO0WtffJ7D22+CZfZ2vxZbD lVBgRxkCmvBPBilJGVHiviHmEKZe0d2p4FrphMRxH1kDwUSopz9XdCL9gcHAoBnbFHQG Rfh1uiayk+SDnFDYOHU4etjr6H2l/r4hDh/ul8ipDI6sfrJ+DQB1AiBi0xfGXZbWvrDX 14lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9kO2fvcNlORmr5refp3iQX7iAtXLZBD9fVphyJARhX8=; b=3/DA4NaqyC8Hgvpx68rSRXdxv4M8+/0nwssdWgIH3nQMy0h0h1jkCerj9vh0sm0Dc9 6mvu9H5ma6gmLyZQr6OwSSInMGsud9CYToAarQI6DKVi9xlQySsmhZILSlFmpDsb9mMl 5uKRMLr7YieoG6kuqNZelJPo6vjXb+S1uJLbjTSyeUWc/ZYYL7Pfzl+opO6jjmftq+AC TNBZ9CRr7BAYv14dRbus1f3qj3XkluRWzFSNZaokaar82ikm0wnVatpCG2W0X4R2PNcW 3Ha/MEOsU96rSf3Ro+Dvv24fzDQMAl36nLFtXwUyzSmQubpxeoTKz+oxKmk7aD0ZELal vEAA== X-Gm-Message-State: ANoB5pmEskAgsmwnLtL0zU1BVqaatTx8kCykn5XglnlOt5vWG0i1QWyM wwYq3lPQIi+EXx+XFT0sJIopRQ== X-Google-Smtp-Source: AA0mqf5aD+L4Db5Bvz1T5isxqcTFlUW7lxk5LjbB/umOsRdBUaOD8R48dfMWSm3Svy1J3yoKvXzAgQ== X-Received: by 2002:aa7:95bb:0:b0:571:3fb3:9b5f with SMTP id a27-20020aa795bb000000b005713fb39b5fmr934023pfk.86.1668144859699; Thu, 10 Nov 2022 21:34:19 -0800 (PST) Received: from google.com ([2620:15c:2ce:200:bcc4:9f72:ddea:982a]) by smtp.gmail.com with ESMTPSA id y15-20020a17090322cf00b0018658badef3sm657149plg.232.2022.11.10.21.34.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 21:34:18 -0800 (PST) Date: Thu, 10 Nov 2022 21:34:14 -0800 From: Fangrui Song To: Cary Coutant Cc: Alan Modra , binutils@sourceware.org Subject: Re: [PATCH] gold, dwp: support zstd compressed input debug sections [PR 29641] Message-ID: <20221111053414.2g4ifwlrfqepcubc@google.com> References: <20221001014451.532772-1-maskray@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-19.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-11-10, Cary Coutant wrote: >> elfcpp/elfcpp.h | 1 + >> gold/Makefile.am | 10 +- >> gold/Makefile.in | 16 +- >> gold/aclocal.m4 | 1 + >> gold/compressed_output.cc | 44 ++-- >> gold/config.in | 3 + >> gold/configure | 258 +++++++++++++++++++++++- >> gold/configure.ac | 3 +- >> gold/testsuite/Makefile.am | 17 +- >> gold/testsuite/Makefile.in | 32 ++- >> gold/testsuite/gdb_index_test_2_zstd.sh | 24 +++ >> 11 files changed, 361 insertions(+), 48 deletions(-) >> create mode 100755 gold/testsuite/gdb_index_test_2_zstd.sh > >In testsuite/Makefile.am: > >@@ -3120,6 +3120,15 @@ gdb_index_test_2_gabi: >gdb_index_test_cdebug_gabi.o gcctestdir/ld > $(CXXLINK) -Wl,--gdb-index $< > gdb_index_test_2_gabi.stdout: gdb_index_test_2_gabi > $(TEST_READELF) --debug-dump=gdb_index $< > $@ >+check_SCRIPTS += gdb_index_test_2_zstd.sh >+check_DATA += gdb_index_test_2_zstd.stdout >+MOSTLYCLEANFILES += gdb_index_test_2_zstd.stdout gdb_index_test_2_zstd >+gdb_index_test_cdebug_zstd.o: gdb_index_test.cc >+ $(CXXCOMPILE) -O0 -g -Wa,--compress-debug-sections=zstd -c -o $@ $< >+gdb_index_test_2_zstd: gdb_index_test_cdebug_zstd.o gcctestdir/ld >+ $(CXXLINK) -Wl,--gdb-index $< >+gdb_index_test_2_zstd.stdout: gdb_index_test_2_zstd >+ $(TEST_READELF) --debug-dump=gdb_index $< > $@ > >These new tests should be conditioned on HAVE_ZSTD, right? > >Otherwise, looks good to me. Thanks! Thanks for review! I am going to use AM_CONDITIONAL(HAVE_ZSTD, test "$pkg_cv_ZSTD_LIBS" != "") if HAVE_ZSTD check_SCRIPTS += gdb_index_test_2_zstd.sh check_DATA += gdb_index_test_2_zstd.stdout MOSTLYCLEANFILES += gdb_index_test_2_zstd.stdout gdb_index_test_2_zstd gdb_index_test_cdebug_zstd.o: gdb_index_test.cc $(CXXCOMPILE) -O0 -g -Wa,--compress-debug-sections=zstd -c -o $@ $< gdb_index_test_2_zstd: gdb_index_test_cdebug_zstd.o gcctestdir/ld $(CXXLINK) -Wl,--gdb-index $< gdb_index_test_2_zstd.stdout: gdb_index_test_2_zstd $(TEST_READELF) --debug-dump=gdb_index $< > $@ endif autoconf generated gold/configure uses test "$pkg_cv_ZSTD_LIBS" != "" to define HAVE_ZSTD_TRUE= and HAVE_ZSTD_FALSE='#'