From: Indu Bhagat <indu.bhagat@oracle.com>
To: binutils@sourceware.org
Cc: vapier@gentoo.org, Indu Bhagat <indu.bhagat@oracle.com>
Subject: [PATCH,V2 1/2] libctf: remove unnecessary zlib constructs
Date: Sat, 10 Dec 2022 16:10:21 -0800 [thread overview]
Message-ID: <20221211001022.564137-2-indu.bhagat@oracle.com> (raw)
In-Reply-To: <20221211001022.564137-1-indu.bhagat@oracle.com>
[Changes in V2]
- Stick to the intended effect (remove only zlib constructs). Added back
the $ZSTD_LIBS.
- Will discuss removal of AC_ZSTD in a separate patch.
I am not sure of the future plans for zstd compressed CTF sections, so I
would rather take that in a separate patch.
[End of changes in V2]
------------
This dependency is managed via libtool. So explicit addition to LDFLAGS
and LIBS is not necessary anymore.
ChangeLog:
* libctf/configure: Regenerated.
* libctf/configure.ac: remove zlib from LDFLAGS and LIBS.
---
libctf/configure | 5 ++---
libctf/configure.ac | 5 ++---
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/libctf/configure b/libctf/configure
index d3d63407cf0..cdfc0008fe5 100755
--- a/libctf/configure
+++ b/libctf/configure
@@ -14579,10 +14579,9 @@ OLD_CC=$CC
# always want our bfd.
CC="./libtool --quiet --mode=link $OLD_CC"
CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS"
-ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'`
-LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS"
+LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
-LIBS="-lbfd -liberty -lz $ZSTD_LIBS $intl $LIBS"
+LIBS="-lbfd -liberty $ZSTD_LIBS $intl $LIBS"
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for ELF support in BFD" >&5
$as_echo_n "checking for ELF support in BFD... " >&6; }
if ${ac_cv_libctf_bfd_elf+:} false; then :
diff --git a/libctf/configure.ac b/libctf/configure.ac
index ba4a144ce37..652e95e3968 100644
--- a/libctf/configure.ac
+++ b/libctf/configure.ac
@@ -90,10 +90,9 @@ OLD_CC=$CC
# always want our bfd.
CC="./libtool --quiet --mode=link $OLD_CC"
CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS"
-ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'`
-LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS"
+LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
-LIBS="-lbfd -liberty -lz $ZSTD_LIBS $intl $LIBS"
+LIBS="-lbfd -liberty $ZSTD_LIBS $intl $LIBS"
AC_CACHE_CHECK([for ELF support in BFD], ac_cv_libctf_bfd_elf,
[AC_TRY_LINK([#include <stdlib.h>
#include <string.h>
--
2.37.2
next prev parent reply other threads:[~2022-12-11 0:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 0:10 [PATCH,V2 0/2] Small improvements to libctf configure.ac Indu Bhagat
2022-12-11 0:10 ` Indu Bhagat [this message]
2022-12-11 7:32 ` [PATCH,V2 1/2] libctf: remove unnecessary zlib constructs Mike Frysinger
2022-12-11 0:10 ` [PATCH,V2 2/2] libctf: remove AC_CONFIG_MACRO_DIR Indu Bhagat
2022-12-11 7:32 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221211001022.564137-2-indu.bhagat@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=binutils@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).