From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 6EF3D3874162 for ; Fri, 16 Dec 2022 13:25:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6EF3D3874162 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BGBqvjQ015631 for ; Fri, 16 Dec 2022 13:25:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=U8cLhPqVlwmaSs2qAauvhhzeFsxFTJA1IFxKEUsi8Cw=; b=OoW8+tG2GHpY9aL6M7ZX46HILCRHcJBurkr7FZkimf+BDSIkLEg+tKlJTgDlJHxKuUFm cUf0t7J/O4AiQQ8nUpMlTnAv4jkuIOlfhZ9tXry91pNE/cEoA53EiZNwaPCu97gCUzvy m0chmLoMYt881S6F+kuufwQ78JsT+I4QM1CImPpX1jZbihSRl8wrcXD6XgNWGMXxeK9Z vRg7oesaBzcsGt3FE3siBvQAFSq/khdG3FbIaK8TEaPLNNBI+W5euPEXEsbovyduIZQ+ epahJcr1i+R3mOHEkNSsarq0sO2UMSNWEyDQEBAjxcJnzsMmLxRJNqLE09uiL240QxQs DQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3meyeryhen-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 16 Dec 2022 13:25:54 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BGBOBLW027824 for ; Fri, 16 Dec 2022 13:25:53 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3meyf0ak0w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 16 Dec 2022 13:25:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N4GL2H+ZYq2hQzfujALSNAgdNC+4p3jJB46JpXsZi5Vbo0B4zs2jEeNVEMYmBzsEP8o4rW97x8sZi657KNb8PRmQH7sH+3o0M6JcljLAwfdALtiyZw3tAlxAoRaKu7IFpmXUukD3QNsIGys6+ZrQvX6f69HZGSO6QbtanYZlnU0k3w9FmHH/EYDW1ZaMEAe0nFi0hv7XNEd/nWYkwrFZ+XE+vjBHvDbN6VvuTHOHR42hTOXO6B26mAE538h0oifgTtd+HYxPXzw1QYdW98TeZIcdu6HZmX2iyhG/e6agKuTAg2I5E846yweDkyZRqk2WvZ6Bar/RIB1MS29GNrVfNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U8cLhPqVlwmaSs2qAauvhhzeFsxFTJA1IFxKEUsi8Cw=; b=i+jzGOr74LX/M664X7vC5T+daNwXoEAhCs0q3+xMDOvvlN2IbC18Jss9CoAl81tEqwbqA/YACmbuoG+r02K4i6LGLEK5NCQFu9p21HjlkKDQttNSUmeNka+Ngcs5eZmqnno8lw7jfPYSlsbr9p/lrAVrXtT5GmkfmDRN3uH0vgWzv3qftiwQtVJFlaTQS4rUrPzlvqq1kbGJKGuFRLJY1DTMQho//sBzI3DPeBSk6ayYOB5lCuvhM+mYJCIkLfeOM1dISLtz6CB3VhPzquMN5QfZsPY9N3KGj/JXfX7nT8BhKQeoXmAUgm27dRWmwb34t50EYOUQIw6E4y8PZdRW1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U8cLhPqVlwmaSs2qAauvhhzeFsxFTJA1IFxKEUsi8Cw=; b=SLpmHwhjrnTHEGw3rZ5fnBuR+0WLd43zBMqz9YUoNsx6UPwksQhM0dhyKnAogGYUsDrGk0UhKoxq21g9+0YKL74mE4ifXkRZh+ny/uZj3dVfa9XFYZ0Um2m7D9GYD384YRfrqYKUwxlUv5hMDam3uYEZe9azP/daH30XCWPwoA8= Received: from DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) by IA1PR10MB7358.namprd10.prod.outlook.com (2603:10b6:208:3fa::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Fri, 16 Dec 2022 13:25:52 +0000 Received: from DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::6e94:e2a2:ca1f:2a7]) by DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::6e94:e2a2:ca1f:2a7%9]) with mapi id 15.20.5924.012; Fri, 16 Dec 2022 13:25:52 +0000 From: Nick Alcock To: binutils@sourceware.org Subject: [PATCH 1/4] ctf: fix various dreadful typos in the ctf_archive format comments Date: Fri, 16 Dec 2022 13:25:38 +0000 Message-Id: <20221216132541.45791-2-nick.alcock@oracle.com> X-Mailer: git-send-email 2.39.0.267.g7648178303 In-Reply-To: <20221216132541.45791-1-nick.alcock@oracle.com> References: <20221216132541.45791-1-nick.alcock@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0151.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::19) To DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6798:EE_|IA1PR10MB7358:EE_ X-MS-Office365-Filtering-Correlation-Id: 81a5168b-6e6b-4959-088e-08dadf690df2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zx940ECmdTYrLrAAI7NxJk3ykHi/mGnL9SlFG9xab3bIBQL1rySyWLf/SvmzOZHcUF8gXdn7OKzvrLhkU8AJp2cbtYirxbV+Pb87hHKiiPE8WRMijb92MHOs5viQZLbGkiF9huDuoSekTlQfbYsOkq6pxKImwDhvfgC4lNYNZjkYSsudxdnqLUQg/IXJu+cAgNZc08gscXQ2vYx42tYJSsUsoYwWiON/f55kztNHy9dnYLcFIh2CpNdswpgBTAju0v8PQW3Yj1JPQfGETn8nXzNq8ozClzzNZO6tcbG6IOxmqulL9IOxRCQfcfyM43cV03kzNDTGhVR1XLC1sU055LOK4oDqmf/AWBC9WS12ZeWHOxAUXYYKIpk6bGuDxXRf7sWJy0Z87q3gDZ06DyRnfKPvOsOuJyNCuzlkOFXZthopyRi+wMcdhR+XqUGvOkisxC23GzYmIJGdSdijTRWhT6GzxnoEqxW52mYGyMzpb+WHvk91yUg6K2uhL8/rELSntLol0b/gxNhN8WAZZYgbEkNV41NQcBHuNyb6+efQ0g830IUumoZBFIaS0wbvz9M9IZgUO4TU7ZzLQ4uV+AcC2Zx5gEOP87WXH8BK73to5jGB4z8oCnfthhDOZo6s00TnFiPZT1HvPfzYPDq+U/J+Sw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6798.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(376002)(39860400002)(396003)(136003)(451199015)(36756003)(6916009)(6486002)(478600001)(8936002)(86362001)(316002)(38100700002)(6512007)(186003)(1076003)(6666004)(2616005)(83380400001)(41300700001)(44832011)(6506007)(2906002)(66476007)(66556008)(8676002)(66946007)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Nh8RxQrViFDK4AjrsoEp+4WzJYQHsCq9BoVfOAt4Ky7jX2PbA14+CnabMvLV?= =?us-ascii?Q?fsx1NhLK7nMrjXl0WsY9J48/qUfcIFRpEsViOnjsmJ21ebepxFwa83uxCkG/?= =?us-ascii?Q?w0pkspbMvZTQu/EuG3eXSIzJFn3dIyhtJMf3e4Dkb7eSxVSFh3DdjYrxWSSh?= =?us-ascii?Q?tFaaMnjBjAwKiVa1G2jaaFatkx2i+QaTZ4bcqUsiobHCSd8OKGrBZtyGzF2f?= =?us-ascii?Q?S1PDT2+SInnJ5UMg8rWTszr1iCPQY0mx6d7YukJPYKyBqaLRkOZhYcWZuqrf?= =?us-ascii?Q?n4bnsFyLFOK1xG/I/fYfk+uCDWZk2Wo3jpYAKglXUqUbtDj5GLDOUSMtYkm4?= =?us-ascii?Q?hXZ9+X0BU/ebkTIONZZvu7ZWVI9uXTJ2SQhqQUsj1SLCv0Gi7BNM6xLFIn0P?= =?us-ascii?Q?c0vfEJx9kNHBe9aPQSTiQV4/sVNcYSvACeZmr2rfwBlCLtHjuwIJ2hGjik1B?= =?us-ascii?Q?lXN8Uw9y8m6+VlQnWyHtkIuZ5ckgbG9pawQvlcAy9q4pYROjsIYNT6Fmsk/M?= =?us-ascii?Q?2mgDfxB99DwZMhfKMbYG5EHJatCFN1I4rQKG6QwbZxVk77Q4xQLYFHtMFSEC?= =?us-ascii?Q?nGTa6CPbcw4i77rbCoEZr8SpIhGRLoI+Bx3F269FcCFf6EZm1cFW815F5mRT?= =?us-ascii?Q?odmM6HKOfPvwXlPQ5OtSlNgj69/waHcTJkSg99ascp9dcCqAcQcHDnCXLLh/?= =?us-ascii?Q?KLC3IsV+0+/muadKlcztjVUt5t4mkd2u69uNsfS/LuaDpzgI2RmPkWAPh+rM?= =?us-ascii?Q?bHPsKxoEa3iwCH5aKetSWKDfz19KhL4im18m2XPdynzqK4/LHHu6ZHNLu2Mw?= =?us-ascii?Q?aKqixFyzcr9uycM6wqlNnVom4p/FMWGBcdbHsYpfcKNlhrVNNwfjyWaQdpMN?= =?us-ascii?Q?+m40TDUdHXxN0IfsWyjOcDDcTDXsIvK6fEe1Nxb+4DfK19mcR8HkI567Xv1t?= =?us-ascii?Q?u882Uvjalx6z7WYRv/we/a0NfmeVN1C5x5S5741ksgvgo4RgFuqeTPhTDDio?= =?us-ascii?Q?lcd8x+0xnIdu26pfemTzj2X9rU0wEgyRjcq92PnbJ6cwA4MEU66f42XBFJLp?= =?us-ascii?Q?cg4veeiyrjS6Sp315HbnixmSzuzyHad3+L6ZDBG2JWojubDPUQdUQI8LnXov?= =?us-ascii?Q?m25+Ofn1NVcUKpNzUpTOr1gjq/7VvK4cwI+AoIcVwCjrZQYkFs9M7FxtZuK+?= =?us-ascii?Q?nPy0n6WS+FVR2+ZoKobTPRgS4GCq9ptXrZoTy+j8g7Q/Ph6RqN9bo5FRuo37?= =?us-ascii?Q?cosviAOx+CPPUGTl9qi7mIcLJrohC0oewRD/+5V4EfbAWwWa5hQB+Qyq8mAu?= =?us-ascii?Q?fHCqz6f85430vDyb6fo7nn6T7xurFt/s1leiyeiMJNn74UOLXFP12P0ULBkw?= =?us-ascii?Q?g5lSzd7fzyOjqdN3QkxJA6DVvGUsJqN8GjwOjddHaCsQH5mccFw3tD3byvm5?= =?us-ascii?Q?Rso0KlwRxzCn4Rr6CeWsxLQGUR7Z89xVtprdjYWYeqnI8l7oUL57fE3+PIf/?= =?us-ascii?Q?ZdXQGuJ89Amy1wMbQpqwZnZ3Zs4EWGTqHqzRnusDvMlFEtpNa7EKW5ubl4nv?= =?us-ascii?Q?pmoOXBt6Ldd/cviE2Tm9kG2ZQcYmUZ0IJgH6BETqzXcWDj34XuidGQEEqvvI?= =?us-ascii?Q?Xw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81a5168b-6e6b-4959-088e-08dadf690df2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2022 13:25:52.5823 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HuESPAdkaus9cuuBdyM+QvhyJmTy2tz1PtS8RabSvrtdI+Aq0Sf1Is79c5OJf3mGyBRMrrPJuCt0X8v9xgJaaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7358 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-16_08,2022-12-15_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212160117 X-Proofpoint-ORIG-GUID: _xtCXewFKp3AZTkdQVhOdW-Ey7CUqbRQ X-Proofpoint-GUID: _xtCXewFKp3AZTkdQVhOdW-Ey7CUqbRQ X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When defining a format it helps to a) get the endianness right when you explicitly state what it is and b) define things in terms of fields that exist rather than fields that don't. (A bunch of changes of names during implementation were not reflected in these comments...) Thanks to Jose "Eye of the Eagle" Marchesi for spotting these. include/ * ctf.h (struct ctf_archive) [ctfa_ctfs]: The size element of this is in little-endian byte order, not network byte order. (struct ctf_archive_modent): This is positioned right after the end fo the struct ctf_archive, not at the offset of a nonexistent field. The number of elements in the array depends on ctfa_ndicts, not another nonexistent field. --- include/ctf.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/ctf.h b/include/ctf.h index 698aab3eab6..6b17236254f 100644 --- a/include/ctf.h +++ b/include/ctf.h @@ -599,13 +599,13 @@ struct ctf_archive /* Offset of the name table. */ uint64_t ctfa_names; - /* Offset of the CTF table. Each element starts with a size (a uint64_t - in network byte order) then a ctf_dict_t of that size. */ + /* Offset of the CTF table. Each element starts with a size (a little- + endian uint64_t) then a ctf_dict_t of that size. */ uint64_t ctfa_ctfs; }; -/* An array of ctfa_nnamed of this structure lies at - ctf_archive[ctf_archive->ctfa_modents] and gives the ctfa_ctfs or +/* An array of ctfa_ndicts of this structure lies at + ctf_archive[sizeof(struct ctf_archive)] and gives the ctfa_ctfs or ctfa_names-relative offsets of each name or ctf_dict_t. */ typedef struct ctf_archive_modent -- 2.39.0.267.g7648178303