From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id A4422383B6D1 for ; Fri, 16 Dec 2022 13:26:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4422383B6D1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BGBqnCs016025 for ; Fri, 16 Dec 2022 13:26:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=wM4PmeZHwX4ayiZA0YAdx/+vQ+N3VHrkW+FrEhdb3pU=; b=bung5+G8nlLEMAP4c5EweWx4eudxljw/vB83pVHDLV5bncc9QCdGm0iaUQn8+NZu/lTv AsWMyZ4PJZAF2g536fm+YKARnGbKSrxovMP2mIc9le37WYr38IV894OsXuvwzrRPVzrD ZoEWzBcD5aJp2Lbod7Fs4vtjbTB/9So6Ut/XykGalTqeXXK+mAf/TulvH5RZdleEji0p g/0MgcQUf35kkMNmNK29voxkdBuoeHJoB761HALtfNOOwhG0VMmaQn9bFv4GYq/+tm1w 9rU4iLIZpKhN1W7DGejUJdu2+E+ry6XzU2dOqWkPo8UfjZ3BmcLn3uGWSlXxYCN2t9/P 2A== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3meyewyf12-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 16 Dec 2022 13:26:01 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BGBZUSq027689 for ; Fri, 16 Dec 2022 13:26:00 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3meyes8mnn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 16 Dec 2022 13:26:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lXYO2BfCSBrZ3CEQDskDoPqcB/3v3JayHYwJY4FKe8+KKXv2ktSgfMp8RC1uDotjmY1IX2+tPrdMa4sbBVm0n8bF69re9n+m6hli4ivTvm5QVH1JdPCxlfTcTMd2m7hEAySWr7w4Lrs5JM86Zc0gakJVocKGUPvDO9D2VNJ/qGKOV7Kh58HkiQTqs2RSNlHuimofQnexsLWKDn/gpVaPuiOVT1auxmfaLpRP9Mxs/krXVZ/6/kd+YZU4POw/PBaFGdQHEuo5e+RAvgk56Gr3Gw4VHCfaQSCzhR9GOEHrPFdMG2Z31mI50BScpp5qnj9HJFwgImnvBhSPue4ujLRggw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wM4PmeZHwX4ayiZA0YAdx/+vQ+N3VHrkW+FrEhdb3pU=; b=I2bK+g/w44sh1BXX77KKWohKRkS4RhLCAGJEEfjkb7qBMQzTdDQWA91/UBo7MX/4kDxy7n/mLByRt0Aex6mnYkaocXMmPhjqwwDP3JYNRvg/gh7q2LobCT9S37Ppx9oNk5CnwMSCe9TofmzofwXU7LMWwF13revLno8/pQVRB3TA+fB2N/RckhJ6s9FB0dM5oQ6E78bQOUvsH+/B4AtVI0Q68xjFW1HTZTPHRFX1O7IGefom+BdURIH2GOlEiV7riLJ2OCwT3xVtCNMx4wtkssWflEYLA6SAl8IAnBF188ovcs4DRQ1Z8rNPXkOIL1Zhb7SVNpGzFhEiz0LX5jONyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wM4PmeZHwX4ayiZA0YAdx/+vQ+N3VHrkW+FrEhdb3pU=; b=CGYqZgYdRhmRMxy0pahEqGwLpfj3CnJiPQ9LLzxftp6pJEHcDvQNP1M/mcIe4tPZuSPHhZtdv2rLFFLYHG4qfBPCNcainNPBIk90BtZk6QZ+Lzs7QLm7e2ZNDMIWjmurD3323Cpko42rJVCcHjLJvSJ8obczy1/akfg/HVxd4lo= Received: from DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) by IA1PR10MB7358.namprd10.prod.outlook.com (2603:10b6:208:3fa::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Fri, 16 Dec 2022 13:25:57 +0000 Received: from DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::6e94:e2a2:ca1f:2a7]) by DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::6e94:e2a2:ca1f:2a7%9]) with mapi id 15.20.5924.012; Fri, 16 Dec 2022 13:25:57 +0000 From: Nick Alcock To: binutils@sourceware.org Subject: [PATCH 2/4] libtool.m4: adjust kludge for ignoring syntax errors Date: Fri, 16 Dec 2022 13:25:39 +0000 Message-Id: <20221216132541.45791-3-nick.alcock@oracle.com> X-Mailer: git-send-email 2.39.0.267.g7648178303 In-Reply-To: <20221216132541.45791-1-nick.alcock@oracle.com> References: <20221216132541.45791-1-nick.alcock@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO4P265CA0142.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::16) To DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6798:EE_|IA1PR10MB7358:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a6f24ef-a0b9-4239-2516-08dadf6910e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0b5n+h2Ts5+AAAqy0H9s8aCJOWiwHTfcPB412z796mP9FCPDhdy9WNC3eashoy2iCxSz4PPbL/OA4V8Xanf9btjuclrWsWsNueiAb3f/LeE43oPIg/lFDpp/PwkncP1dLViA1dc4e+XZ/LfkZDu5UrzO5Y4fp2ph/8m7Y0Bevd7Uk054G3cabQYb2UKMV1lH+rhWZw0byrTjgnQICky5Udn9MWaf/haEJmS9lKtD9qviZuyndW97P7fBLqPcC01rAjED5JDdEJtcGAqgrRlHwZ2un9vC1ug5wlocimVRL8T06L6GAG9rDzERzyaGHtkUQbEuWMKMo0U6vyd1a3Ogh9iLDxRnaZPvM6P+TVulVTmkFM2CQvJ+KVwzNSoz4YZFfhl997CCDQypWj9Z7cJaZQGdf/cxb/HiITC79CgqgkMjtwf/41UR5a2oRUve4jxTT0GEP+2FrfOCrL+FRp4jzegnvTD9DgZKllcwlgyW9jflLwqK5Ww8DYbeu2uwONXrqT6GB5rAqmOAfhYT+CkGnnq0BS5rN7XzzsijVkkDcYGmXMvdnEnYMn6WWCDUxMmusXdApoorTFJXWFEkgOFIdwT8vg92ED2Ty27C6P2lU3pLLTjBrbKd+2xbgQ1DOM3b6GH7NFdtXaxHfFFyGbbv5A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6798.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(376002)(39860400002)(396003)(136003)(451199015)(36756003)(6916009)(6486002)(478600001)(8936002)(86362001)(316002)(38100700002)(6512007)(186003)(1076003)(6666004)(2616005)(83380400001)(41300700001)(44832011)(6506007)(2906002)(66476007)(66556008)(8676002)(66946007)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mb0PjUE5PAmfoEkCKF8gyNzLB+UtHy2VRuLuAAZhZTta4lSCjqCsxSNWUrbC?= =?us-ascii?Q?ZtXIufsJ4E2+76XvDVmWm0gCqtqdpXhpNGnySSvv1Tm8U7H9VBHO7njhPnBw?= =?us-ascii?Q?e6Tu951MKKWGnWWftylHj+bsST0LGiFp1lhAhGIQQQV0EKgCxiOtUJuVbtKH?= =?us-ascii?Q?PCELSZ570PsrnzPMEWxQSItXGb//IkxvlxsKVl2OiK55ETULTUfljvk+mb9V?= =?us-ascii?Q?t2PPlh1lxwXPIpqTuoR2hEWnGXYykLiXekvOutiLdPL0iJZGGD/QkRoUk8BZ?= =?us-ascii?Q?+y+knuBMmIGZ+aiHu3l86AiYeRwoTbTIkEDDo9Tow6TixaulbMQz7bHlDA3a?= =?us-ascii?Q?2wWKGyokN39rca2k4ZlI2Amx0vDAVzi8Sn0gbyGix3Hc6SbD2HkgZyUEqxKD?= =?us-ascii?Q?OjmTNXlyh8HP+W9dhuu3nkZrQ5dqkLozJ0Fi1D38bz+17bkWP0TS1LdtOzKc?= =?us-ascii?Q?6ukg6FE8RSdaJYVhbbqPZrVVLpfdQ15ozuOiqbBbuMJb51IxdUOS41j4w1ws?= =?us-ascii?Q?SrM2xwI2iaTwKPveF9PPpiE7N8CB+dxANnmMBQHm/6jeT+G/l0TwOe02y9yc?= =?us-ascii?Q?9sL0mivrs2W4VK5gXwkg3tluGdcAmeUQPnsH0lV7rnBCducm8lJl9gu6FW0X?= =?us-ascii?Q?kZMKidpkbEbA4aDUyaZCstvauYr9T6+nKGq6ESa4RsOs61nPECOk74wDiF5V?= =?us-ascii?Q?rlyqPLOdKc1P0/2Ws8w3ICbeHKdOBz7PTl1SrpphTVylKNaSF2DXiLb4+L2W?= =?us-ascii?Q?lEYwDF7Qv+ze2WABrXrUqLncI+I6xinUsQCDG3uvOoRCVrEsqFh7E79xxb/Z?= =?us-ascii?Q?vNiPe/JPBCVE9809H7TOa39nqcHP95ZLah4Y2jFxqmmOlvdVh/FvzfFafJ7J?= =?us-ascii?Q?1xj9g4W+i65aBxh2QL+0SVC0qwdiheP1TzDtvC/NbfVnpPvICwYFf0Aab3BD?= =?us-ascii?Q?UJKNmxd/yU0j/D0pWmKXn7Vvirze7JYxr/+CI+69bmR0fadaYGcYNrZA5uaN?= =?us-ascii?Q?Z36zvK5ivhWwd3FjxVFrqXblCYDH6sRd4lH9NfnWbjtsgnrTEISpw9JaxFMN?= =?us-ascii?Q?I2s1NatMrGFPfgOZGBu39Q4wGrLYcyZl99SekW76Z6ykjsIybCgeEIeBB8kT?= =?us-ascii?Q?3DEGpGh2tgmiX6xINNyJIn6oMFWsEdgCsNKD5XU/OMD8WqFTTHgAFKG4lZJf?= =?us-ascii?Q?/iDpLKamz92npUFg4uKqQQtXX8XMlAg0ypSMA7vCJbYqQzHdRyk6V0PrC4Q/?= =?us-ascii?Q?WkfINiuCr5OZLfgoYCVFIZbJaX/GjTCwDKdFhvztTJ45DBAf+UlHgv7B5irs?= =?us-ascii?Q?9JZ09DFvxu/kVzo1CVrxfJiOk7Mx/2A42W+2aav3rQseMgcGJhLQjhVqcWuI?= =?us-ascii?Q?VzPz+7ZvflssT03HN7LJ74KFALrcShukFCf3okT20cnDju2QQqAP06OgTJCH?= =?us-ascii?Q?NGXZK0zDOiKEpb2IK/COB8VnNoKcdVGBMG6kzeN8E474u68Xh0v6fNsVYzB8?= =?us-ascii?Q?4Pw9/2SG0PPLyDijvPQo+CgEWWkauvtQkbJ0FFCDuzqLG/KEhzI/BsWgqJC4?= =?us-ascii?Q?3VTTbaNOd56Uu8Akx3aHUt/CmZeLylEWidseMtbCYD46n6X0Gz3o25YuffFr?= =?us-ascii?Q?HQ=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a6f24ef-a0b9-4239-2516-08dadf6910e1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2022 13:25:57.5972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1Pwg5NwfJWw43wqg/AjQccDPjNWgbQUdWvK+B8GWGqmcHCjFUsnkHtkoUe3QCtH5RxnYyRewHwzXc/dwYkQ6+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7358 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-16_08,2022-12-15_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212160117 X-Proofpoint-ORIG-GUID: KBeJfurTdO35lI7Vs-HOgb_nJ1i8OpdX X-Proofpoint-GUID: KBeJfurTdO35lI7Vs-HOgb_nJ1i8OpdX X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LT_PATH_NM considers an nm to support -p/-B if it returns output that names the path being checked -- but since that is itself nm (usually with a path attached), this can trigger false positives with errors like /usr/bin/nm: unknown option "B" ignored" The test currently avoids this case for the single instance of HP-UX by deleting all but the last line of the output. Keep on doing that (so we don't do more work than we need to), but also explicitly eliminate references to "unknown" and "invalid", with any leading capitalization. This handles Darwin, which says error: nm: invalid argument '-B' Alas, we cannot check the exit code, because some nm's return nonzero exit codes if no symbols are found! Things were also erroneously failing if nm had actual symbols in it, because we were getting output that did not mention nm by name (its usual output). Identify things that look like valid nm output and let it through. PR libctf/29547 * libtool.m4 (LT_PATH_NM): Explicitly filter out 'unknown' and 'invalid' errors when looking for valid output. Let through actual valid nm output too. --- libtool.m4 | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libtool.m4 b/libtool.m4 index ad63ebbb385..4e5b1884b87 100644 --- a/libtool.m4 +++ b/libtool.m4 @@ -3231,15 +3231,18 @@ AC_CACHE_CHECK([for BSD- or MS-compatible name lister (nm)], lt_cv_path_NM, tmp_nm_to_nm="`$ECHO "$tmp_nm" | sed 's, -.*$,,'`" if test -f "$tmp_nm_to_nm" || test -f "$tmp_nm_to_nm$ac_exeext" ; then # Check to see if the nm accepts a BSD-compat flag. - # Adding the `sed 1q' prevents false positives on HP-UX, which says: + # We discard lines that mention 'unknown', 'invalid', or 'usage', hopefully + # placating systems like Darwin and HP-UX, which mention the name of nm + # in error output. # nm: unknown option "B" ignored - case `"$tmp_nm" -B "$tmp_nm_to_nm" 2>&1 | grep -v '^ *$' | sed '1q'` in - *$tmp_nm*) lt_cv_path_NM="$tmp_nm -B" + case `"$tmp_nm" -B "$tmp_nm_to_nm" 2>&1 | $GREP -v '^ *$' | $GREP -v 'nknown ' | $GREP -v 'nvalid ' | $GREP -v 'sage: ' | sed '1q'` in + *$tmp_nm*|*\ \ \ [[A-Za-z]]\ *|*[[0-9a-f]][[0-9a-f]][[0-9a-f]]\ [[A-Za-z]]\ *) + lt_cv_path_NM="$tmp_nm -B" break ;; *) - case `"$tmp_nm" -p "$tmp_nm_to_nm" 2>&1 | grep -v '^ *$' | sed '1q'` in - *$tmp_nm*) + case `"$tmp_nm" -p "$tmp_nm_to_nm" 2>&1 | $GREP -v '^ *$' | $GREP -v 'nknown ' | $GREP -v 'nvalid ' | $GREP -v 'sage: ' | sed '1q'` in + *$tmp_nm*|*\ \ \ [[A-Za-z]]\ *|*[[0-9a-f]][[0-9a-f]][[0-9a-f]]\ [[A-Za-z]]\ *) lt_cv_path_NM="$tmp_nm -p" break ;; -- 2.39.0.267.g7648178303