From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by sourceware.org (Postfix) with ESMTPS id A11F73858D39 for ; Thu, 5 Jan 2023 21:05:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A11F73858D39 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=flex--maskray.bounces.google.com Received: by mail-yb1-xb49.google.com with SMTP id e12-20020a25500c000000b007b48c520262so3563067ybb.14 for ; Thu, 05 Jan 2023 13:05:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=/7IwxJ1HaxM3rsqRVCWOK3btFPfm5CRCmX3FcSF9F18=; b=LjGeuI7pkRw1GYikLSN90724DdS3A3snDcWx+sIK1LO/mjsz+Wzkpi3vOFKbvKQsci bixQZIjidIPv8q21UuxWwV3LragDTMllbjNM4HyivFD859bRi9svyoOuwr4i/P2uLNxx 6hJMcRGk41RSbR62xtGIYGfG7B2xoO99rLdO4PU1cyMarsewc9XsKcbR3UFLhUFMZz+0 HK4LxLGJ70Vn2gdH93XP9OVRTPGbo0bPA0sTXVoVXK3qwAq8Ixg3qmMOBSyqZQdqK6EB UnKkbTR0MZCWNko44UBRFV5uvUF1btFLalMTLRmuF28uAw1lutY0C9r/ViQGckI6R6nW 5GVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/7IwxJ1HaxM3rsqRVCWOK3btFPfm5CRCmX3FcSF9F18=; b=qZ36OJEj+DDopsiOPDATO/caFcsyCYdG/GuCm1PbU+ygnzHpZjcYsCyol38WPzYhMR KENZQfHBYiw/oTyUjBBIVj2olzZAHRNCTjb3ziCvlo1i5FUvqgI8r7mc7JbmnwJ6+f1g Z1PqcO8WEdLbVxhhKBfvlB4Ns3Kf1PMfPv80fBxoS1Jn18wBk89gnKOY6G9ncXVTNSo+ 46+1OT2iz2ETWfZVtmOX+hIVNGffg7tI26dsUOF4Go19W3uIME195OWzbk1Z5jp/Y+4l 44vGtM0sGD78ypTgmlLjI85ljWA04DOG6Q5q7NfocbaTTgNe82u03q+kYT804fydtcRv tkHg== X-Gm-Message-State: AFqh2kqeZ09KDToX7TuOWgDVuqXO1Kr+zmtG9MrrG/lrfvUiZ5GcoaAd qmpEixYokl2JU29ZRv4NvQZQDoeOGx8Z/nYYaf2d0DmBJctw7wR4bY+zNU2B2TrlFdnDzcdkVwM gOI46V5CQd8Uwi9meve0cmVlkKSQUEyyy78kykbfizBZSmJIR2eM/CuDpX8ntvWLK5w== X-Google-Smtp-Source: AMrXdXtFTZqCbTZQ56zLAWihqYuP35U40l25wLVdzwC5qMb+gINYAddamomfXX0pgPS8ABM42Ws/w2cvP3w4 X-Received: from maskray.svl.corp.google.com ([2620:15c:2d3:205:c2de:536f:e9be:ca87]) (user=maskray job=sendgmr) by 2002:a25:69c5:0:b0:7ae:5e48:380e with SMTP id e188-20020a2569c5000000b007ae5e48380emr1060112ybc.596.1672952745988; Thu, 05 Jan 2023 13:05:45 -0800 (PST) Date: Thu, 5 Jan 2023 13:05:42 -0800 Mime-Version: 1.0 Message-ID: <20230105210542.3573076-1-maskray@google.com> Subject: [PATCH] ld: Allow R_X86_64_GOTPCREL for call *__tls_get_addr@GOTPCREL(%rip) From: Fangrui Song To: binutils@sourceware.org Cc: Fangrui Song Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-20.0 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: _Thread_local int a; int main() { return a; } % gcc -fno-plt -fpic a.c -fuse-ld=bfd -Wa,-mrelax-relocations=no /usr/bin/ld.bfd: /tmp/ccSSBgrg.o: TLS transition from R_X86_64_TLSGD to R_X86_64_GOTTPOFF against `a' at 0xd in section `.text' failed /usr/bin/ld.bfd: failed to set dynamic section sizes: bad value collect2: error: ld returned 1 exit status This commit fixes the issue. PR ld/24784 * bfd/elf64-x86-64.c (elf_x86_64_check_tls_transition): Allow R_X86_64_GOTPCREL. --- bfd/elf64-x86-64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bfd/elf64-x86-64.c b/bfd/elf64-x86-64.c index 914f82d0151..095fe2e0fe6 100644 --- a/bfd/elf64-x86-64.c +++ b/bfd/elf64-x86-64.c @@ -1241,7 +1241,7 @@ elf_x86_64_check_tls_transition (bfd *abfd, if (largepic) return r_type == R_X86_64_PLTOFF64; else if (indirect_call) - return r_type == R_X86_64_GOTPCRELX; + return (r_type == R_X86_64_GOTPCRELX || r_type == R_X86_64_GOTPCREL); else return (r_type == R_X86_64_PC32 || r_type == R_X86_64_PLT32); } -- 2.39.0.314.g84b9a713c41-goog