From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id B24173858CDA for ; Fri, 6 Jan 2023 14:34:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B24173858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 306AOMF0031876 for ; Fri, 6 Jan 2023 14:34:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=OSAQRrlSfMOFQCnohooMlELD5lT2lANBvMeJjbDhVBc=; b=MA/iEiEZyJzZjyV7EQ0gS6V2sxmHihWfjSVwfHyYvvn8zXwMD8Abh4GZ7mipbrGMJco8 l+FsRcv+Wz7+0EvF0mEkLTZNrkp1ah0RoXoaBiKw96WzAILEziNGlQi8uvkLJPS9udnB TyYZo7D7AKUzAr/JubpYEA3u9z07zdXbc+40BKOYbn/DP5zAgh1cWYFcwHQrCMXlYyrt FDaPbzb15rfaKrQg7eWB4E0f8mqvgCiZXBcqmNLyaI/NC8xkZ+glTg0HtY07u1M8oTOX tqrBPCnVfIBqKNBVIQlIZXRDVhJTNfgam1PZGU9omuq3LwuS+kenWXo9aB2sK1vzlN0S rw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mtdmtu5qv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 06 Jan 2023 14:34:05 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 306Djq3j004959 for ; Fri, 6 Jan 2023 14:34:04 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3mwdf1ucn3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 06 Jan 2023 14:34:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XG0hro4j32IRJAjizPWZe7ScnQzgECrcQqvMRChYvpdvqdf8v9U6heAqsohPuZef1fb+mIPgatRw5GPb7EtJvRVVKuf3T2K2IaMkjKKpo95ToLXJfI4FhJHTWIS/xcH88AJ1fMBydebmrfyq51OP3/ebxXobJ6kWMdUTn+ZbKhuYd6rZcYsp8F4G53afwbKoRBoN3vtJUy6E1bpWkVLDVwyjXKvuva0pfoz1uHnHnEB1IJmv/L4SWhSD1048R7tbdn16nlh6k/pBb23d+cZ8Tzos3PJ7kq/FG0pzo7KfU9LY4dhPHXqFJNkiLrqXNIlxPOotfoH09yOu/Hor/ToL8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OSAQRrlSfMOFQCnohooMlELD5lT2lANBvMeJjbDhVBc=; b=ap3lv2J63vWVfcekRpa7xx+YYQTorqVoRKhj5Gf+ROTKwrM7l7vGBVL+4jIPCzR/pGHAY7ShUduaYJoFJ8ciNNay2r4o9FHdwA8668tgh2DOuTNAylkczJxI+rs49hpGpuOtEyLx5qFDccfD2GXQYxJCjb7P8BBUeV+fdIGxi9viKlw0WpxTFO5abtYqG/Zxv/D6Bcjo6Plln+GJQC+hcbKHjQCXHMnQfuxp202KPjhgqe+WZadVFk7+XnnUkj28kkTLO+NEkvOCx5kD7kFz6Y9o/cKe4dJOT637UI83HZLSp37Rxhfj1q7y3KfW0nzSD6PInLdw6iCWjqKvEdYgTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OSAQRrlSfMOFQCnohooMlELD5lT2lANBvMeJjbDhVBc=; b=pEcdhJ5zonxKHTIK+P+CoftiLTrTykEMFCOJI80eIBz7qE3Zxel4AkQqj8S84KqsQ4sKdEmUlqaH6F8E7aGWrE7PzspPYJ3vR+aL4NIonfpTpPUKnFGY3SI2TZEP0WMfmtztVXy6lcDE3okC2xt8EE23708x/V14r/5h0Yt8pSA= Received: from MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) by PH8PR10MB6455.namprd10.prod.outlook.com (2603:10b6:510:22d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 14:34:02 +0000 Received: from MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::70df:cb31:cf08:5b12]) by MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::70df:cb31:cf08:5b12%9]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 14:34:02 +0000 Date: Fri, 6 Jan 2023 08:34:14 -0600 From: "Guillermo E. Martinez" To: "Jose E. Marchesi" Cc: "Jose E. Marchesi via Binutils" Subject: Re: [PATCH] bpf: fix error conversion from long unsigned int to unsigned int [-Werror=overflow] Message-ID: <20230106143414.mkltqymnj64liwv7@kamehouse> References: <20230106075816.387489-1-guillermo.e.martinez@oracle.com> <87mt6vg41b.fsf@oracle.com> <878rifg33a.fsf@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878rifg33a.fsf@oracle.com> X-ClientProxiedBy: BY3PR05CA0058.namprd05.prod.outlook.com (2603:10b6:a03:39b::33) To MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR10MB1407:EE_|PH8PR10MB6455:EE_ X-MS-Office365-Filtering-Correlation-Id: f7685ebc-4771-4ed0-cd91-08daeff30e07 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CnBdOUGUuVdu+1aGp86TH9oyDDbra0kxr9fu0jZlecLKp2eNaB+iZS53eNZG9J7OMvDTt3bK/EOu9jhmZd9BBt1jGOw64Dd0pkam4VWilRTmQrgyZGEzYb0G12NdsHeN1+Cn9kRWkr2qECEqsfUrdigAvc8aS+j/rz4Kqj+53+LFH74AooJViPVHCdRkOBzFISS7x9jR4HRGt4GdReLZMq7BpuV/+AiDHtR2YsOxqPRlW+Iyc8YX1jmJsNPuP1T1841yI6ICGUVqvFS7GpBZuiQODqmzwzbwC8t4Mh4Gmjx/qETyqlJToBidIOguzhleqjAz/aV4wwxgqgQ5gQ1H5KY3us9oYh6qe0sq5bvdOiHfqArADuQmy/45WT2I0eOGsrrAJmklxHmgHO2nXbFtakkWZ/jZKBYk1mnQ5SUefepudVFv+/Oyz15J1MUSgEXEl7K5YkEhN2RBFn69LJqCT9ca7wjP7HFW3QvL2be9SGJej9OM6OABkm25GKAPfH90Sy3ZwVmAsEV6YQqMyEkUiER90KmAvuNIfNzlotMKfV7GhWq4dFZZQW9oMSZWAthyADdvulRSYOjrmAxf5cek+sNPSDb15wvvVuybp/oyQtD4n/E0Byr+CxheeWcOOdlj9t4PcVQ/jzIi+pTScl4osw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR10MB1407.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(366004)(39860400002)(376002)(136003)(396003)(346002)(451199015)(6506007)(6636002)(66946007)(316002)(6512007)(186003)(2906002)(5660300002)(4326008)(4744005)(6666004)(478600001)(6486002)(9686003)(41300700001)(26005)(6862004)(86362001)(66476007)(33716001)(8676002)(38100700002)(1076003)(8936002)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BZpK03IdzKTYr3VJwO3Nqyn7k2T9H6I17Wnkc0+VoNyDu/PcRd0j5MmJy1cH?= =?us-ascii?Q?B26zXgFRbJ3zlJH2l30r39fB/Ft/oy1QFfwNaKyxvmQ5Uk8CNEZmCO+cj7WN?= =?us-ascii?Q?9EOJyZwpBsZM3gzPXdSPBTZ7u10W0EXObAJE//lBvv/hZwAzHVSAdCrQ46HW?= =?us-ascii?Q?VT1b0kMTP+qsFww0wu9Kk3KF7orhS4GvxMyh51lQUttbptZ7QZqiRUw9CB4o?= =?us-ascii?Q?Kk7bQFGUfHp6igxJthQL15gOiJeW93Fyvi8e+nnTLwe6fbwfYobWhHBZoOl8?= =?us-ascii?Q?y6TFSKU0bP3r4r9+Kt3ZcR3x4jzXiFMEm/WEnzXxoMGNUK4XrIAsZtTUi40/?= =?us-ascii?Q?lHbsR0ol8HlaBfIGAWQ3VSc3E5DD0LDE8AMgCf9JyVmZgx0Lwyrv1J7IbYza?= =?us-ascii?Q?PDexS0KyzQDFQlUCTI/zaIB3cuWSyYDAGT7HL0uKxpKusitY0phtF6MJPaId?= =?us-ascii?Q?DtKMEC8WT8kvxlsL39bWdhrZOV5cVZG7ayphaKshSxdq9wG2XRHn0W62W4h7?= =?us-ascii?Q?v+c04t1klzaPSEbFsbev42z0Jn/iAwrUt86b/JACQBg2dmqRNlDpZr+AahPm?= =?us-ascii?Q?ZLiT+ENCZQUFzQUuBiYZ6UO/5MAV6OX9oI/LTTebtmsltnYzMFAfJ1kEHEON?= =?us-ascii?Q?/LIExpMHLmuQN2casFzpBtW+i3jCKW5ps8KLPDu0EerrRJM1PpqcnJcJVBj0?= =?us-ascii?Q?4kr9N13+6lghmpmN4mVFL5CbAFPSIEYhx5bc3Qcq0SJTcg8WYklbe69Q4YMf?= =?us-ascii?Q?b6itDyrUbW/FnopHQUp7w3C379MaLeKTQvVwXLMmv26tI1sCLC05BD3rKahz?= =?us-ascii?Q?PQ66Fnju8+kHRMigxxFi8WdbLZDT7VJQZ48mmGuIVjmz/rhtkM7XQPNWIOkS?= =?us-ascii?Q?tacxnSMPXQKUBM1tVFf+vZZzJZSg6gMHZbi2hiurWpTnP6q59GkYtKkpbe4Q?= =?us-ascii?Q?equYbmj0bw/FeRCGyApjD+JPG/BRfvYAlGMlD1on/efWe5xa2HRmjvncUtbc?= =?us-ascii?Q?BQAOeKqXSCzDxrm++I3u9bxoRf1tGcZ9HlJvO/vnpWV6MBWGg8e85N7MM3pu?= =?us-ascii?Q?eZKilL0p9MOypuR8TmABAwIC62Q2ZfFqmUCZp+xnp65eKqRAsb+E/p/KKx69?= =?us-ascii?Q?7wcOKeYYwlMc0/Sc+gppgpX39kqUYH/MUyH5VDIDNIWTmrEUx++X/NoZKCJA?= =?us-ascii?Q?Mj2prQZlJ0UaBgIeixGGRubfC87wZvF/2mQTooxk7WPwQEYAsQxFaj2qRdfd?= =?us-ascii?Q?wMyCKlPbmGWHVjXL3gGBf0trv/4M0hJH4MgwNBtcw08j1vwe9wcsU1dySJDv?= =?us-ascii?Q?7WkffR2bQsrNPky9HTRroB9BCg7lW/BJl9WYt6IKj5/Kt7755F9SG1wkVb5c?= =?us-ascii?Q?IjhRQao8v3w8rD0ToAvcLwBFZ2WK2cgBCUGQ8MWR4AW7FFuxlCwK5qyzj+zo?= =?us-ascii?Q?AhvdwcBSKBM9/5KmAwmWzBAp99S+iuLMlqQhkODSU5kTwj10yV3Xmb2xjZkj?= =?us-ascii?Q?Vwx8dlAOO+/qH7NZKrliS8Tpv21ap5+n33XE4aoV4QnBXRyvf+hb1gsrHt96?= =?us-ascii?Q?U2KwJkcTOCqQ/kXhUIwJEuefpFdd6tNtge5xBMnrs97tCizUBV1QZkjsoRkY?= =?us-ascii?Q?w7XwmRHy/peJdxa0U/0vdSw=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: sixkhqnERpLBX2SzWsVB1pLGWQHkoX+yBOL/hDHJyDsEUaVxlU8mxxsWZszcfnOlbx5rYww6Wdt99Fak7GsXj5MuWZ++wLCjzGnJai53sTaPE7aVVenWLsmff+Q5csjZpZpabE8ErV9Iim45tg1syF0cnf49T9YYTRBkn2jlzD09uln97iWTzjjilLL8xL6TX3T4VjbXYzsCQomK34CrZlK5/c9dWAIupmOhIIgqzsqz4vTFJETX9o6Bxgr4qMr9R3jwHpEsB7tz2Df6bz+E9R19qGffQMqGrcOlJdtQPkqCbT8sx7L6+rx/clcfLfnuOqiwwa07K6VRfKaO4zjEh4zX13I3GeXkDf5oKYUoUeZwpktOghF24DFVkRSRAjgE/Xz38ywGaUb9qCKTfsEkXQhz3JAJHggIOM+oY1cw+f5US9MTtOXePKqyBUCRSU576ztg0Nn9Vi1Ldypb1absz6cTSlVSLrDPkdKyL08tzAPfxRNj5NeWxoK341J4z36TKg7OByO7hA7rjYEhNzlTyWL2oRnAYD6C/+ZIAe+pOJXJwwjeGEQZzA7eVZEOXVb34HPu5E2QM5cXfcCELDwFGTHREvG7/nhvG2+IcaPE5xAhIzeQ1Cxb8IxUkrrs7yUiM2NmVX2maaEkX+qTCYT5U/RN9z+CII05CBLWyrk5fpmUdc6P+MDjxF81o1I7LXChxOsKBYPEkp2D7NMugmgqjwm9uoQF3ieUH3eLt1dMopA13Tw9HlatAKeTy0t9LMGk X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7685ebc-4771-4ed0-cd91-08daeff30e07 X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1407.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 14:34:02.0173 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nKvoHJQR6nD3uvFPV9L+ZU61G6e8vvAsI+0+zRncqiPnhv2dx9qP2PVZAUQq0Z/IwBYBHwhMwPxPZyEdxnXTn7b/sOzn/TSiokKwDDITK8I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6455 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-06_08,2023-01-06_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301060113 X-Proofpoint-GUID: 0wozToq6Et6MF4tB-PswYg7kKykTIOUo X-Proofpoint-ORIG-GUID: 0wozToq6Et6MF4tB-PswYg7kKykTIOUo X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jan 06, 2023 at 03:16:57PM +0100, Jose E. Marchesi wrote: > > > Hi Guillermo. Hi Jose, > > > >> cpu/ > >> * bpf.cpu (define-call-insn): Remove `src' field from > >> instruction mask. > > > > I don't think this description accurately describes the real change? > > You are basically adding an opcode for `src' to the instruction > > format. > > s/opcode/operand. Correct!. I'll amend the change log. Thanks for pointing out it. > > > > >> diff --git a/cpu/bpf.cpu b/cpu/bpf.cpu > >> index 13dde7094c8..2ae74fc4c18 100644 > >> --- a/cpu/bpf.cpu > >> +++ b/cpu/bpf.cpu > >> @@ -768,7 +768,7 @@ > >> "call" > >> (endian-isas x-endian) > >> "call $disp32" > >> - (+ disp32 (f-offset16 0) (f-regs 0) > >> + (+ disp32 (f-offset16 0) (.sym src x-endian) ((.sym f-dst x-endian) 0) > >> OP_CLASS_JMP OP_SRC_K OP_CODE_CALL) > >> (c-call VOID > >> "bpfbf_call" disp32 (ifield (.sym f-src x-endian))) > > > > The BPF side of the patch is OK. > > Thanks!