From: mengqinggang <mengqinggang@loongson.cn>
To: binutils@sourceware.org
Cc: xuchenghua@loongson.cn, liuzhensong@loongson.cn,
chenglulu@loongson.cn, caiyinyu@loongson.cn, xry111@xry111.site,
i.swmail@xen0n.name, maskray@google.com, joseph@codesourcery.com,
mengqinggang <mengqinggang@loongson.cn>
Subject: [PATCH] LoongArch: ld: Fix hidden ifunc symbol linker error bug.
Date: Mon, 9 Jan 2023 16:35:26 +0800 [thread overview]
Message-ID: <20230109083526.74448-1-mengqinggang@loongson.cn> (raw)
For hidden ifunc symbols, it not have GOT entry, only have gotplt entry. When
process R_LARCH_SOP_PUSH_GPREL, the offset is gotplt entry address minus GOT
address. When call bfd_put_NN(got->contents + offset), the absolute value of
offset is grather than got size, and other memory not belonging to GOT is be
overwritten.
bfd/ChangeLog:
* elfnn-loongarch.c (loongarch_elf_relocate_section): If hidden ifunc
symbol, don't call bfd_put_NN.
---
bfd/elfnn-loongarch.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
index fafdc7c7458..449fad6d25d 100644
--- a/bfd/elfnn-loongarch.c
+++ b/bfd/elfnn-loongarch.c
@@ -2502,7 +2502,10 @@ loongarch_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info,
if ((off & 1) != 0)
off &= ~1;
- else
+ /* If h has processed (h->got.offset |= 1) or h is hideen
+ ifunc (h->got.offset == -1), skip it. Hidden ifunc symbol
+ not has got entry, only has got.plt entry. */
+ else if ((h->got.offset & 1) == 0)
{
/* The pr21964-4. Create relocate entry. */
if (is_pic && h->start_stop)
--
2.36.0
reply other threads:[~2023-01-09 8:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109083526.74448-1-mengqinggang@loongson.cn \
--to=mengqinggang@loongson.cn \
--cc=binutils@sourceware.org \
--cc=caiyinyu@loongson.cn \
--cc=chenglulu@loongson.cn \
--cc=i.swmail@xen0n.name \
--cc=joseph@codesourcery.com \
--cc=liuzhensong@loongson.cn \
--cc=maskray@google.com \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).