From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id ED200385840A for ; Tue, 10 Jan 2023 13:01:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED200385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30ABql4K006387 for ; Tue, 10 Jan 2023 13:01:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=m4F8y0SImLSltJO4xvQLh4GfbENvFN70ryhsnSEGs48=; b=S/pp/H5uCAsDK6ZhhIFFC1fP/G3m4njaI7yQjYAgB2IvA5Eyx2v+5TmqUwWd/vgwd6p0 3An9Mf7eyjBEu5ISjBnjrr7D26tD7n9xLqe4/IeHMGfvPhQhCPMUoytluUg0J8ezD3JM z42SnuIU5BPnQk/nGY1GsIvZRn5zyTGoHTMQNFNDPsDQ9Ve43SHg/W9JI1UcSmzQ+txp CKqXxo3X6+GDg3CA6s/IzzL52jS+yu9ksYDVUIV/p1532UUTBjoM2HgzFRRlFZn5r0sw lWfSMfJjdefjMqNMYX8MTy0RYTY4ZTbrPUXHR5+GwODgy5RscoqtgVQvZ9cbVNDgxemD WQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3n173bg5xg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 10 Jan 2023 13:01:03 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30AClHpA030532 for ; Tue, 10 Jan 2023 13:01:03 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2048.outbound.protection.outlook.com [104.47.74.48]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3n184wrytu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 10 Jan 2023 13:01:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFbxAdYdRWfS80ArxQhIv6+NAo8noQF6sW9eCkpf6ZDa6bizS4CAqWk/IAdqtO6ami91usDc7gN8SszUXkPKSs75d2uOrWJu0/q5h4Duk63uJij5HwdnMICHAta+4Fy8dnMMBr/dim1JZyugOPcjUqxDUYlHIK3jlIAKm4p5NzTT5weYEIIkbzLlXSY3d4gI6XTkvlHGtDmeST/utxgOGQh2usRawdQ97uI9cS/V6J2FIcQAJ9UCwugrbObkPfGTzlIxDNWbwub8it7ZS6/YpZQ4M0OeURzJm/3ZnVmkgG8+beKLcD4WWlbY+B4a44HnfYFFElCy5R99ZsLfwME1Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m4F8y0SImLSltJO4xvQLh4GfbENvFN70ryhsnSEGs48=; b=ezNJklZyjFFCQkYCCw3f2v2sdyECLowN2Aqm+k2NLC9J9naa2/lFpQifFrIUPRKDD6wSk2JnP17A659VRaH2xBzB2PYOBj+GuJDT+nSPE6GzpmFmT/kl1mR7HS26Ut30GYD4RMrvTaQJYmRpOX1q0Tp7ZZgNVLjG5rRudpq/RXupW2SF3P5Dl9Z/CnAgvaxKu/oQQ1UeIRdn4osjWT/xQCYgPY5jgSNEoHFiH1r/YLxGFs2uquWXUYw42TfXLq3qCmW/QdOVJYGnZ+uAk3FHofWW8S538Z+koEmsQeiyHpnTDYwjAJmTB74W6kOCkkIJqGNQYF4OABUSXsv2Ss+8AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m4F8y0SImLSltJO4xvQLh4GfbENvFN70ryhsnSEGs48=; b=I57PNy6h4Gd2htlEzfdIwHUgZmlq+fAlr8yPcG7Cq0E+J0mdqVVfOeYapZhFPKWvdvpEUZRYWCQ220U5AFHVUNFn3DKXiQt+xtgeU2nA0Z0kCzLA9zS4yUMPvwJCKPn9a5R1j8Rq+E3rpjgGSQVRcVhJIzape8li2fahpamPFuk= Received: from DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) by DS7PR10MB5198.namprd10.prod.outlook.com (2603:10b6:5:3a5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Tue, 10 Jan 2023 13:01:01 +0000 Received: from DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::b30f:e3aa:6ba:5c8d]) by DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::b30f:e3aa:6ba:5c8d%5]) with mapi id 15.20.6002.009; Tue, 10 Jan 2023 13:01:01 +0000 From: Nick Alcock To: binutils@sourceware.org Subject: [PATCH v2 1/3] ctf: fix various dreadful typos in the ctf_archive format comments Date: Tue, 10 Jan 2023 13:00:48 +0000 Message-Id: <20230110130050.366404-2-nick.alcock@oracle.com> X-Mailer: git-send-email 2.39.0.267.g7648178303 In-Reply-To: <20230110130050.366404-1-nick.alcock@oracle.com> References: <20230110130050.366404-1-nick.alcock@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO4P265CA0040.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::9) To DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6798:EE_|DS7PR10MB5198:EE_ X-MS-Office365-Filtering-Correlation-Id: d1737d38-03d6-463b-72cf-08daf30ab93e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bj5XmyvQMoru8ZZWIX5EC3nqhZAN+TpPHJpewA0vapxM0iJ/bQ80RwwWoOiXmLV2jOl7Lr9rTApP5kEqbla8DnMOn2lk50dB/6GqJRONVmZ7YiaYSwKooWvwX3i/7SrkCnK+/oBECbz7Vx3yN5lL//Vq7HXyQbQRZ+yswrQgqZdNJUlVryHzU3ISObSTCY/hzJ1s7GRzHwI9Xo6C1Zdus9VbNFCc+q5ZeKZ/R7EuCHSPx2ns6hZhexb47CYOlRmKVS39YK1C7cZhKjjKTbZ4J7GTzn9Fs8R11APqxSAxP9RVNGJbEW0rlIytz4F3O8GPd+N+sJRfiZuvml+ZS10cX4Rb1p0JCzBf53+zBW3Lf89r3FsWN2rgRS4MCw9w3wjFKS4TOup2i9SRymXxHnV7SNgHchwJmseWpAXHwGhDXaSGwc6Sg/JefxQ/PA0rkapV7epdE5aCaMB/fix8RqKO5PPSGv1NqiDxEacOdLmnuIpgkNtZzxXAwVM8LLOV+rrvqxljY/5dul3s3vZiUaLsqMEQ6hjFbgGhCkfbrCi16iUv1litZiKpKqbzFglsapo/crYHIn7OHVRwaS4MJE135CTRuYM+myf3OF/C0S3U2qay9YMkL8FO7ucYEy2GoxcDA2nFUrU03zwfhPcf3eVaKw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6798.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(376002)(396003)(39860400002)(346002)(451199015)(6506007)(38100700002)(2906002)(6666004)(6486002)(1076003)(6512007)(186003)(44832011)(5660300002)(2616005)(316002)(478600001)(83380400001)(8936002)(86362001)(36756003)(41300700001)(8676002)(66946007)(6916009)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pcqT32NnXsHjVQroyH+6ZZS4J5q0+yppWDtoKVXaSfR3ZzOX5Vk97+HQsfBL?= =?us-ascii?Q?nBVSEe/7Uzz6L3LdBTG7Gq+3Mr4jG+g9Zb8BVVbv7Navms4j+np+9IuWcEuz?= =?us-ascii?Q?Hvlyji69nIT3wsi/bygbL4RbJ++GzLkjgwToUYobQ7yfcBScSdd2iTQgvRSQ?= =?us-ascii?Q?xkcZlHFTmR04ENHZWM0WvtIm66yUQphwZIiLQZXM6ACK38j17zw74hOqiiEB?= =?us-ascii?Q?rdpkQ7paPf/XS4UOm04IW+8a0IV9bUKs1zOrYaDcSIM/+xFAKtOypb866PJC?= =?us-ascii?Q?iKvNLl/hfNwCMNa/2+H+zL6zW6InrkW0U4xTQDPFgeeIS9lHsqDgI4dkiX2E?= =?us-ascii?Q?pL0N2W5BwEmLewJd0Cwcfr7yts52ncDUXA4QcxekSXwz2uwNaI6IikqM8I74?= =?us-ascii?Q?7dMiA4BJQoUv6noB4lLcIb+OeYDIcCVIfxuRoJ13s5uCgzy5rbLW7OOwBvyS?= =?us-ascii?Q?OfOLZRP1GHmiJPOJEtTOvFMwiWLCfFUx42pyhszBEHgmHoA/8775BgeGgF1k?= =?us-ascii?Q?LWv3p5cZRJoNIpc3DDaS1HRr5tdi9GnQsyaYe6NjqrwikiBc+RmQtJyVZrHP?= =?us-ascii?Q?bZ2r19RgkbDudLOz+DCU5EY6dE+FG+qF31J/iQMYRiVcKqRnL1/r3ShjO0m8?= =?us-ascii?Q?2yyrBFi521gADHxFAui2VZLio8ikMv2MEEJTS8V6zXuX8RX9NeMseW/yX19j?= =?us-ascii?Q?MrC6a1hPaGk3xoNFB0w7tTkIBDT13QvBgcUbhED/5YHuszrkKtPf+2NiK20l?= =?us-ascii?Q?CaU+GwlcHxK1zLp59lln/dXAKSZnHkHU7/JVaKrgrQkgAiIY1sbeSDL2k/6c?= =?us-ascii?Q?mIaYDNLeb+KtJxh7pD81e797rA0asICN3pbF8exnGd0/enNzYseEWKx1H6Zv?= =?us-ascii?Q?LE75K2sPMN8Nx/MegBQVZ8Ko6uNjgx8E1rIPJhZruyoa79a/TVMzBR0Rhr0m?= =?us-ascii?Q?sd4cntJlsCdoqBGO2zIyugzzJfW1fjYaB3JJhtLkmTAmNixQfqYXTpeWgMyg?= =?us-ascii?Q?FqWmDuw73X+HahL/bLXVxHLnuKPgAhKyseRDU+ifuYEK6l8DqiWxE0/L0jFn?= =?us-ascii?Q?jzcl6WP7WVyqO4xlFmL80Rbjr2BLZaOZozi9DYfMTWyceVz7HhdMsS8hWcVZ?= =?us-ascii?Q?e2ivmUjMTcC8hObZ3Cs2M5cc1wAsq+pKWq+U4fQuftGaXI1llscHunyWsIRa?= =?us-ascii?Q?O5DqWcBSK54uC//2sbG0vz+embQfvWI5QiUvtU6ZCRBaZD+uzm51CRqtH+0d?= =?us-ascii?Q?YFcu69P6Wl82/VEQswBglMOr0lby8bl4hJIs1ulGmujBg4AkFu9NAhHaArz7?= =?us-ascii?Q?htWrYdn2QJWaczsx0wkLYrfd8GBCVME5SsLTEpltnbhGmIDXHXCypeH3vq9Q?= =?us-ascii?Q?6JLr9DPuySqyX0UTM9kjpGWu3zpreSzCoG4RgUnhIOBQ3agxAvh6hxvvIZXE?= =?us-ascii?Q?0B40RZ/KxKOZ/5OGo+nAKNS664RkWougceGwpuLSqfkoyyvuF0SlHkhjISgM?= =?us-ascii?Q?qvbDbPNdpTo8G/IE0JdfgnB8+9EpHdhl+PGmIvtEb1b8MiWn2ozrbRtUTjUe?= =?us-ascii?Q?QrNnD7wPJUy+nQGJOC+WW7LhMCPUI0YkQw+4DGFdVDeknkvcANS2BPQmDj7s?= =?us-ascii?Q?ag=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0r8EDq4TxxXiCZGkgacD595c49k3ac1CxXi455mt36v9h/p98R/O4o+/DaHTrmMYzZBZwrBZ862Fub5u+utyfxxNbEgf85KUs6hb4GfuuPNVeDj7RBMOCk7EDF1gUXj902Ef9+GpiSiKD23ERtYWy2PeJE2WnBLblhjPwuYihaTDG5MRkEM8RiqfkZxIt6wLwiWfSORpq+3E73oilps0ohvUNZjNw9K3ZxHKUTtd20FJCF7LBgySyM/NS2+Skq67GMW1+v7q90Ck5BKCF7MgDdY0qcjSrnEEfy6TBnp1zbjLUzAObGdqgVGW2cbf7v2sOkGYN4p8fWMGVCud7m09FsAbO/xW+BLEXcrHwszHMu/DFfKUuj1mCShRYtaqBD4lU0S3u8o8mBB+sjar/oRPzusnDe1mSzpvIvMO0xhVi3Cgj58qKWJxKuo9Pg3RNFzpJMjpVTN55N6zS4icbQfMT97HUkQmq9QU0kDclkf87Ri2kNJEzpuxVBV5y5eQ3HIBJPGxHZ8kaeZUNGeiSJb4VcjqcdRxViKa+znYP+YO9Xk9xwAHcZj/HaNEiYf9mBH5wAPX3mn6aFh+4HenvrKkP8bNn1UmQZlLEfmSq4fzRgJG0AvSKyXfQb5qAjoIVjpFqmp/MI/FzSTeXFyjaDDz7XiKQP5KE/NU76ZIDvd4mMbJWrgrtuuFBFEGKYn3mbFu/+YyTkMOfWlXbFABVMoXHxB4esxXugj17AEGRbAzUlUTLTVahbR3rZcKZ7XexpBd X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1737d38-03d6-463b-72cf-08daf30ab93e X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 13:01:01.0227 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8OL3CP5Riu3HCcfOXMn/aM+eCl8xkUSdkURj5pSRhbv6upmbJ3aEPbyj5/93icSERv7WHMkRTsHRWBqcy7UPPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5198 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-10_04,2023-01-10_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301100080 X-Proofpoint-GUID: GRnj0nRf-oyeH_yqn6B6OKJxMQRbde8W X-Proofpoint-ORIG-GUID: GRnj0nRf-oyeH_yqn6B6OKJxMQRbde8W X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When defining a format it helps to a) get the endianness right when you explicitly state what it is and b) define things in terms of fields that exist rather than fields that don't. (A bunch of changes of names during implementation were not reflected in these comments...) Thanks to Jose "Eye of the Eagle" Marchesi for spotting these. include/ * ctf.h (struct ctf_archive) [ctfa_ctfs]: The size element of this is in little-endian byte order, not network byte order. (struct ctf_archive_modent): This is positioned right after the end fo the struct ctf_archive, not at the offset of a nonexistent field. The number of elements in the array depends on ctfa_ndicts, not another nonexistent field. --- include/ctf.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/ctf.h b/include/ctf.h index 4414cb0ebed..4263799f82d 100644 --- a/include/ctf.h +++ b/include/ctf.h @@ -599,13 +599,13 @@ struct ctf_archive /* Offset of the name table. */ uint64_t ctfa_names; - /* Offset of the CTF table. Each element starts with a size (a uint64_t - in network byte order) then a ctf_dict_t of that size. */ + /* Offset of the CTF table. Each element starts with a size (a little- + endian uint64_t) then a ctf_dict_t of that size. */ uint64_t ctfa_ctfs; }; -/* An array of ctfa_nnamed of this structure lies at - ctf_archive[ctf_archive->ctfa_modents] and gives the ctfa_ctfs or +/* An array of ctfa_ndicts of this structure lies at + ctf_archive[sizeof(struct ctf_archive)] and gives the ctfa_ctfs or ctfa_names-relative offsets of each name or ctf_dict_t. */ typedef struct ctf_archive_modent -- 2.39.0.267.g7648178303