From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 431DE385828E for ; Tue, 10 Jan 2023 18:27:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 431DE385828E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30AIL1q2026392 for ; Tue, 10 Jan 2023 18:27:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=WHRhuQwhREcM1kcLiVFRVuCE3h3DIIOw81XqdSgL2Dg=; b=zz+GLku8nxBWR/1QqN99QJvLLZeW+j6zdUfKNICkaCmjwgZeEng3ZBpYD06xII1NyMzY MUNFI0gAY6qxlkkGuEy1q8D81sZIUzBXW20+R/ykZ06jVrkyR1JaHCZf/v8lxCtfnw44 /Qpaav9CdmU1+B18yYKLm/ZCWGPVU8keLNx5YbUtyql8icF/6p0g5hqY9ZKgCsunu2Iu U7jj4nSrpGd8Hm/jHAm8tI0o7YkryZlfKbwW8cqXESFZuKi7Me77gD+wE8LmHv6T/T6s zw0dO28VHlBt8c0uZ4Om2ZZNvhMNN6moeothXTVQv/aecqUys/7yn88D4n+9iexaCtb6 ew== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3my0sce2gm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 10 Jan 2023 18:27:57 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30AI0Js7030834 for ; Tue, 10 Jan 2023 18:27:56 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2105.outbound.protection.outlook.com [104.47.70.105]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3n1bnadr7j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 10 Jan 2023 18:27:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nxYTreGOI2HQ7vAjjm36CUKtMoSWlkvzofmu84bJeiF/3OiB2O4qHTGMDdQ4ojswaMxSMKaCzCNfSn8dL7ARbRY6zQtFNaJT9OLb8qQ4uZX/8yCiUg8ol2+aKKwDcRgEeuR/hK+peoCESbq7Q1pO6yft7MTjoeAed0ajJR6rBHHiCUwkB9IuncBDYjFVT5XDi0W1cHp0vIq77Li01Uqu0Jr/DDjiFptYHTiAKvctPZSLG/c6h8PJabMTQwboY/V0CSL4oXId98ZMTEgbAY+AXdOsqGjTsoTgLA150NQVtezuuzt55/mA8CyldiHQwO/hH4GXvV7okgVuApTxvLK9CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WHRhuQwhREcM1kcLiVFRVuCE3h3DIIOw81XqdSgL2Dg=; b=dV69lPqrii0OJd36yXCjT/L+ZcX1efmZ19FU+lIGU5irBxLIdaVDnHgWqEzVbZrBpTUV6Cu3QPYjoeYdUJrNxehHOlP3WELL4Q0BntaQIisJ2o/7zcEptdZ6oXhFxF1Ic11/5u9bj/tQRRZiRk5VzAYToPY/ZrV0kJpNdGd332tKioGSGKQEsFLnrVXnU7EuGJaTCH8FicTfu+K06wWOSFQxr4O7+iHC6WB0vcvHb0vnWpPNMdQHQM5e202ODegMxJAvM7wxC+OmKFZSu87bhaTsZLOPtQMN3uKJ66dO8jDEG2Srk22L8qlhkOh4dLA9/R7bYRrfqJrdrS0ibuZ/qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WHRhuQwhREcM1kcLiVFRVuCE3h3DIIOw81XqdSgL2Dg=; b=IbsKlHCy5i5+8QusMpMdLXqvYuXfjQnESiG07pduTVidAoluomFiBCfINdSTMX52uz7dW6fssGPjt9V6uL2txaLAc27mSEbZgVQfH/pP4XGneNBH5WZhC5kjtPJLpWnLZvNjAM29BwMh9LQIIxQ/UeZaS/Ds7ZH/J9yCWbJtBFo= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by MW4PR10MB6653.namprd10.prod.outlook.com (2603:10b6:303:22e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Tue, 10 Jan 2023 18:27:54 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::14e6:a522:273f:db57]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::14e6:a522:273f:db57%7]) with mapi id 15.20.6002.012; Tue, 10 Jan 2023 18:27:54 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH] libsframe: replace an strncat with strcat Date: Tue, 10 Jan 2023 10:27:45 -0800 Message-Id: <20230110182745.3641128-1-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.37.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MW4PR04CA0297.namprd04.prod.outlook.com (2603:10b6:303:89::32) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|MW4PR10MB6653:EE_ X-MS-Office365-Filtering-Correlation-Id: e281764a-061e-4522-9c33-08daf33863a7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NjQzA1Pj4BnYpaCTTOjdhxUO5kiW9jvhAoR36cS1aIIM3GRjFUUVEXMKHxisbEKbC+qA2ooJ7kEP9Ei/UtTRxaRDIPYXpHKyA9oYg5eeZK8bNl4MwH2RmrqLPKCErsnY5rWU6m+HtIL+CQfPKO0Z4vjZPFR7blmcjx1Xlh4exWFtN2Kue/IPdsXrQ+pX7MBHTlCxYZ4U4unL4qYsYxTRNJbinTE8XfCPZxWiiWzK+CfRoDU6uEgZy/ro9FjjfZeTeMax83ya8QS5nLx2JUtbxjX1JHGxqC6n/quTI8sjflbnTO5mt5l37FLvgXF3WnGt0nTyY0uTyNtxtYjSlxmlyN9y43a9W5rmeOjIDqAbTfwJRtyIg2uu2NVryZIJQ6Q3HnKSTd2jju6MaiAc5F5eXP8PSu7pWy5t4xj+zrkSh0mBSw4pkT0qUJQXmcEDEOzq9qAnaOXFu7/AxneI/2X2ZwOXpTAJs4BQbhaf3dDRX9gZ819Jvo1gXR7dXFKlSsI67fZrw3HxGj27PHOgPVRGeY0CY7wGw3AfKCEoZhO8dL2ZwKca/SAIBd0oOi4khC/NpzKKQERyPVeMEXvxdCxERAO57aqMw9uEbSNZBwhUbX6GPp8AxDDCulhgNitNOk62Y+z6jRnWJJYSaIhd4uAFLg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(346002)(366004)(396003)(451199015)(2906002)(5660300002)(44832011)(86362001)(36756003)(8936002)(41300700001)(6916009)(4326008)(8676002)(66946007)(66476007)(66556008)(38100700002)(316002)(6506007)(6486002)(83380400001)(186003)(2616005)(26005)(6512007)(6666004)(478600001)(107886003)(1076003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGk4ME03TXhiRXlod044eEJhN0VKb05kVWhWK1d4NXJBbFZZUExFeVV4VEcy?= =?utf-8?B?Q2l2SE83ODZJQmo2ejlMVExTNWovUTQ4UVVRdnlCSERiak8reWxIQ2d2cEgw?= =?utf-8?B?cnV0aDUweTA5cERScUN4V0xOSDh4b1JtTnBFd1ZOcWdKeFdzcFNHTmVwT1py?= =?utf-8?B?dTBsaW1TMzdVNEFuSktxZUxXc1BRbGNYT05HU25hUWhVUWlXZlJaVUFaWThq?= =?utf-8?B?bFNRVmp1ZWRsV2dZcHV5S0JZcDVSWHJaaW1TTkcyQ1diK3BlditFWjhqUVhN?= =?utf-8?B?bjVJRUhxK2orUXVCSVRBcTQ5cnh0RXBZOXRpbTRhVkI0SmpnRHhlTURlOWF3?= =?utf-8?B?V0dZMWtuWE9uN1NjTDBmL0lXUmd0SVJ1RGg1azZIYlpVbittclpJV05nbXFC?= =?utf-8?B?TUtLSXNJNFJWYUx1WUxmanBhQnU1V29SVnlCZTRFemxnVUlPd0pSWENmdUZ3?= =?utf-8?B?ZDdUWXAzRWl4alp3VS95WHNieXlFQzdSaW1jbTcwcExGcDZJUFhNSmc5MzVy?= =?utf-8?B?RTFkMlcrZXFOTklSbGpXTEhFTjh4NTJiaGtOOGNNOFZLN3NkVFlFNXB5RXBQ?= =?utf-8?B?dUJsME02UUNDTmR2eGxldFBXSTdSU1FJMW5DWXlRcGMrZHNOcDBUTzEweWYy?= =?utf-8?B?cysxVTFsUDBVUDYvR3FwdVozeWRwQWRxVnJFTzJpSHlzbUQvTFZpMmJycGti?= =?utf-8?B?OTByMFg3WFBBeXpXY3BmVWJQT2hCUWxOaVZEWWVkd2dzaDdHM1N3SHdJMTJv?= =?utf-8?B?SXFLVUlzeEJSeEdSVFBydzJoeFdXZi9xcHNqSXB6QTVNd1VDTE9paVlpWkt2?= =?utf-8?B?UHI4VHBzNkZzWkdqYWp1aWE4YlBTZ0xrY2pDV2RrcmxIeVBMOHNSTC9Db1NW?= =?utf-8?B?VE1MMDkzMmhPcXJXTzR5L29WNnlLUUJ4SnpZU1JMWXBoVFhsVWRYRG1oa1hP?= =?utf-8?B?UXcwanlmREp4Rlp3SVNYbVVvcElsNGZ2TzZVRlJuVFN3YjNkcWNvYlhSQlEr?= =?utf-8?B?amJCV1ZKZGNmakcrYWpZK2NOdmhGMFBDeHdTS3U5RlBkU1hGdnFXOFRqeDJD?= =?utf-8?B?WG9USks5djJabDVpMkNueTBZUVM5dlZBOWoweGlnaklwOXdKd2REYUN0aWF1?= =?utf-8?B?dzlxdDFtTjhkZXhNM2twZUd0eURXR2QvZUtZb20wUWxOMlBvL0dKWkovYUxV?= =?utf-8?B?MzA0YkNPaE1yU2c1aElXMUEwMG53OHg4VTJCeEx5SlhvZ1YyUm5LSHY5ZU5P?= =?utf-8?B?YWp1Rmg4VU11R3lJK1FnMU5Ub3RLN2hySlJGS0ZrN0N3cGZ5S3c2NWsxY1lE?= =?utf-8?B?Y1UyTGluNGl4WVBIQWltZXVPZmY3eTlZV0NSL0c3RUkyNWI5cktnZ2piTHdn?= =?utf-8?B?djlzdVNIazZoeHNFWGFUbFhod1J0ODV6T0VJdytDZHpkbytQZlRSWlZ1SFBt?= =?utf-8?B?eGJvWDJOUXlZK1dTNVFUTkxJQXJ6cUxjYzZ1cXphQUZ6WjRVSTB0NHBiVFpT?= =?utf-8?B?Q09PVWdsR0dLbHIxdUxsczNQOWZZTnFRU3I4SVIxbjYzWDJrd05hT2JTeGd0?= =?utf-8?B?WXRpdTc1WVArUmpUT240aDQvU3RsWDFxR1JjRUp6TFhGR0ZJUDc5MUl6ZmpK?= =?utf-8?B?L1Fac3F5bWZISXlqZ3d4YmVIUzh0OHg3WXZrVHFGWHp2RnVTVjhmanU4Vmkv?= =?utf-8?B?MXFmMUY5ZzFPUERjbWlUUEpQWStZNzFUVWJMUE1IZllTRWxCWmZTSmZucThn?= =?utf-8?B?U0RnYkxteU9URHRZdm9PemJ2NmFDelZkcUdsaW5MVEZqOUlCWTVKL3NWZUNm?= =?utf-8?B?T1d3VHM5Y2pnN1BQRkdXSFZUSWpwSTdWNnRjOUI5aDc4SkhWZFY5aDIzMTlp?= =?utf-8?B?b0RjQnFiUHQyc3pnMW5KZ1I0cTVCbWxhNHN5NHZXdDRTYk1VQkRibE1aaGx2?= =?utf-8?B?aU9GaTJFVHlrb2hKUzVJMUV0UFlvQzg4REZpTTc2bzRHbVM4WWgzWnRETGw5?= =?utf-8?B?Vm9VRFFBbEtHMWUwWWZSR2lwR0J5RGE4ZUtUU1ZQTURJaDl1WHRGRHpiWmJV?= =?utf-8?B?TlVieE55eEhrSHVBSDdwemp0Mm9kMjFPYVpCQThZeUNUcmkrUTdsSzlkWTF4?= =?utf-8?Q?z3Oc7vwkQz4xWJYRbsOChZ+F+?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: RmkAWb0QOUkhs5KQYjxZmgW6RltbDWCUwaATDWZkU8hzamH4x4oVWCkIWnD9UM08eDRtLZgthfsOhxh+/QrLTxFsMvYEDjDixFjN8RqEgP/1HMnJZXgDwRAc2jmqeOGBLcopZeFyJ7WHh3azZ59smQw1ra3vi0YtM9U/cWJQBphftzj0hFQP6/n01TTNJ46oZv01nC2Ys0GwA9oQgsqcZQOP2smKZrp6mCXs+R4pa1d7sNwt0Yugpf/PBDuj5GKyOfLjaw5VlEyHqyN+WxtydMjCAyOenttJbvUbN9Xzst9vMHuesY1AM87zeCG2ktRW5ms0wrQDa3uUrYlubPS0jl6rcdXykMi6dYfZ+eJTXanoMTS0lm5MfZzcsSYRt7CAWPVXGwlGIKhBL2pCsVh14nQaXaJZ5BOBfeng0LAyreTruFkF9g0QQgmB5Q7Ao+9ZioOhIOfgnC5uQ5XzhznRXsRiIWk0wpxxnPyckdVxccZ0v5Y1AydBkBgJXQq2IcaFtMaCnoGnoMY24ivV78eTOgnq9gnOe2VJbezdx83IeLMpUrRl7DAMOlFdcizI7Fhmenl96jPoo58gUCfK3ZEL/PyjI5PKOzRLYk2sEGByMFZLW5FT7wrDnS/ZQ+6jN24heXIG7wfayD9NXHVxPxlpWEgk4cfN9DLshkeiBDC99u0PAty8eI3+h9MGf0slOuGM9kCxmjkhhCMZCw6nfJDmTi5coaG631a/1ILbZ0NOmUhpSetckVVgNxBAXxfCYNY2 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e281764a-061e-4522-9c33-08daf33863a7 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 18:27:54.4024 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d6uRMZqGNuc2U72N+oNP+2my0+Li7hQF8ziZzE4HJXmyNXj7kDeznotIPT+ae5htv8/4qSF+rU5OyWKnxSVRyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6653 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-10_07,2023-01-10_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 spamscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301100119 X-Proofpoint-GUID: 4NV3ygDl7empiUHd2SKqkMZpFgABOjji X-Proofpoint-ORIG-GUID: 4NV3ygDl7empiUHd2SKqkMZpFgABOjji X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, I noticed the following warning on s390x builds, which drew my attention to the code in dump_sframe_func_with_fres: ../../binutils-gdb/libsframe/sframe-dump.c:180:7: warning: ‘strncat’ output truncated before terminating nul copying 3 bytes from a string of the same length [-Wstringop-truncation] I think using strcat is just as fine here. Thanks, Indu ---------------------------------- Calling strncat with the size of the src string is not so meaningful. The length argument to strncat should specify the remaining bytes bytes in the destination; although in this case, it appears to be unncessary altogether to use strncat in the first place. libsframe/ * sframe-dump.c (dump_sframe_func_with_fres): Use of strcat is just as fine. --- libsframe/sframe-dump.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c index 320555a0a51..5417a16f48c 100644 --- a/libsframe/sframe-dump.c +++ b/libsframe/sframe-dump.c @@ -176,8 +176,7 @@ dump_sframe_func_with_fres (sframe_decoder_ctx *sfd_ctx, const char *ra_mangled_p_str = ((sframe_fre_get_ra_mangled_p (sfd_ctx, &fre, &err[2])) ? "[s]" : " "); - size_t ra_mangled_p_str_size = strlen (ra_mangled_p_str); - strncat (temp, ra_mangled_p_str, ra_mangled_p_str_size); + strcat (temp, ra_mangled_p_str); printf ("%-13s", temp); } } -- 2.37.2