From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id CF5773858C78 for ; Tue, 31 Jan 2023 23:34:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF5773858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30VIiM14004204 for ; Tue, 31 Jan 2023 23:34:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=fXmqzlAb7QLGdAx+/lQ/O9Yp2Euduf9vuLsYGbGYWnk=; b=MsJlc3qij9wZBHziBLRkwrBPUTVjLlSBgLoP319qlg8eGvGPIUXKAYoXSaw7E3pM2X1M 8MQ+Ov6o1vzuJpvfTQ3fs/GzgyZat9FUQHH/gbUsj+RXbOViXBiu+n9FIzKgQ2TK7Qw/ MPyg6DQH7k7iJZnjiJ6wfCnFUtGFZ0DrQ1Dm7NTrJDMpFtJDOkWz6BesvKf6kaThz60x 1yXkRcrJJZaR0OhjgmsE2S/H05OHuSLTpGkBhP5u69mdCjNbidyDb1OFzmV5fT02bEQo 74Eizevc9CF5TgdYoTddLUG9UXPqr42rcMFdP5hRE9CeHBzU7WU8W/I5Rg011biXU8yz tw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ncvmhq12y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 31 Jan 2023 23:34:57 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30VNHPtS033886 for ; Tue, 31 Jan 2023 23:34:56 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2103.outbound.protection.outlook.com [104.47.58.103]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3nct56fq1k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 31 Jan 2023 23:34:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L9Lv4MCsWBeCWgU52aFIU8Tjy5GRV8jjoT2MHv5Y+HlD5kSj6dst9dud7llYbQ2UmZSUXQI3+4fMg9NQcmdpjIQZOL2GFahWnp9Kxe6mpFBrXcwNcus09wWNsvlyKtOKcOEEu4ZWxXrvZBi/VZa15/2Js2+E5IuWdY+bnVe1RBiIRhmMBWDmVo2M9NPKUiB39qTuAfCwAI0LGar1KO8kQpoMs5nmsC1LUILZURvguMMwB0NKRhR0FVCKYnUANC1mDwSdNb+rxRg68Qny+lLFUUc32CXHTQWdNTzyiaSykjIuPsuFL6jgN880lgpHqL5yivYDslEvvnKL3O58WK1ghA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fXmqzlAb7QLGdAx+/lQ/O9Yp2Euduf9vuLsYGbGYWnk=; b=jRojp62dKABagzap/0kJTL9RgBjqApP897lf+yPSFcKP4F4Azf4rjE5Wkwf9HxohISIWJJZQvqL/JPoDnAHG53aQziLnjBBhzTQzQQKJoBlcFre2RQrA0WBDYFExzWaJZiyXLVSl7Rj3O2JN7AMGr8eloi7Fc+c6EBFtHix8/XXbFsA39gSNwRp0uSbZlcVEyJeoly/EfwIZN1P9ybZq6+UbZ8iowvQbQ43Z8T7loWcoitxciCcyDcq8FjwFi4cqyFdjBA6zF0VkIiOM0SxroT0zJB/0Lks0nC6fcAX2HJ4xzaFRfOj2xtcdNDlzX7gIcogs2G6pyTKSIKuZ22OjWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fXmqzlAb7QLGdAx+/lQ/O9Yp2Euduf9vuLsYGbGYWnk=; b=A2Q5UqA0qv7+STWgWBMGuqyaINM02cElQkVzlXwBjuEyc63dTjsj5KZjPVoyvR3h9Ylshmbi7bpf8xPIwdJbDe5D1IRE9dybkmHGpjzc8+f30vD5kWkTZkWSe1WOeapULV0Dav6q4BILwuYMUqn3avsPTYtqIiW+UY74BHhxQVU= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CY8PR10MB6633.namprd10.prod.outlook.com (2603:10b6:930:57::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Tue, 31 Jan 2023 23:34:54 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::14e6:a522:273f:db57]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::14e6:a522:273f:db57%7]) with mapi id 15.20.6064.022; Tue, 31 Jan 2023 23:34:54 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 2/5] sframe: use "stack trace" instead of "unwind" for SFrame Date: Tue, 31 Jan 2023 15:34:26 -0800 Message-Id: <20230131233429.3708328-3-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230131233429.3708328-1-indu.bhagat@oracle.com> References: <20230131233429.3708328-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW4P220CA0007.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::12) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CY8PR10MB6633:EE_ X-MS-Office365-Filtering-Correlation-Id: 99c00c56-174a-44a4-55d5-08db03e3c16f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Asloxu80T8gBT7NnBOq0U672nIL9lRRU7sAv4tWvbwGqTAs1SmdP2PbIWPmkoeD3t7nlqUK0OrQ5JrpyqPqfZTot5CqxTjqllI5HHKPedlvVCCtwFQUV3fBYlIFTuqGw5qzzItvGIGYma7fIYR64XCWtj7oPsZKRKWQ++UmvSw22J+suOL1iF2w9W7aREcycXsD8fZ9ohAN1/95wdFCnHRdqaSWjoWkLhn2rN5npgVNP2ZC4oxThcMKPSPvT/xpj6fRauAkUZ6auYXJFOLYe9ppX5XLaBEKmSy6AvpOaUu6yOpa4XxjIz/c8tZEs1FvVflGbRbULgJDjHxDGnhgrRl9BB7HTywkjpPhF7a9gELbCd8hqEynj8ULeoNPADLS/oZim8mUrvWyFRM/RvKvoNNT6nqa/atrw1rtUNqAJyZxNPyHqWG7aZSZsCU3QRJVEHpAJyjndemTT2l/VVOIUhF/TgqosYKDfG4JvzB6Q2d7mMOD0aL8UFUqg8VrqQ56JzSMaeiVY/1GNh600g9YjmBGBvX/jOTuSpjV7gjo6G4D5FAUU7sVPUeZDou54RMGISbkUg0w+3uwuZGz7e4/xy9FVyxrpfQ6rdW4WpI2WS+7qM7XTC5+ElTHK0cV/GjROEg1gkVifVsck+2c1Qzsl8w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(39860400002)(396003)(376002)(136003)(451199018)(2906002)(8676002)(4326008)(6916009)(38100700002)(478600001)(44832011)(8936002)(36756003)(26005)(6506007)(6486002)(5660300002)(107886003)(6666004)(186003)(6512007)(86362001)(2616005)(41300700001)(66476007)(83380400001)(66556008)(1076003)(66946007)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3ldWlL41I/H9uME/8Q1wgD08DJdo2bIqDusUxn9UuxBm74hmFWKf5KBcvZVb?= =?us-ascii?Q?5CzB7MYLBrID71gIYi5oU6MDueuOHfu/fuYcmV8m/u4DOk8Bct81i6Bj1M/r?= =?us-ascii?Q?Rdj1yznpPVBieOLFc5PmAQlhy30qBCD/btfnB9loVfiwnBGdPHQtChnVW32U?= =?us-ascii?Q?N83+edaNI4M/7keOJpfl8PXoLi2S/19YJBpZygX9RN35m0K/3CMztK9kRgLd?= =?us-ascii?Q?m4LJ0JupAmduDP6IV0oJwD/tTZXa9g3gfPClAud01NPK88UNByfZQBZrtyMz?= =?us-ascii?Q?bnOS/ZVVXggQjCQu1l2LsURAhYq7slRyXwiLZypoe6YC5Yj9BLYsKl5ZGukV?= =?us-ascii?Q?agZkbZKBf7rKjs8aUGSwXBJzeAZlQ+KC8b3XHR49tFiiKWIo862XPZVpSPt7?= =?us-ascii?Q?AHyOZVZU+YoAwqmu2pATv9cABOrIM3qtkoMD3RjgfCnjbYygD2CPviRVBwu1?= =?us-ascii?Q?BT7cTzKpN+ZhAkyNmmrJl+WeMTfI0KFxRe7UguPb658a1LDbEtlaYABWzXvF?= =?us-ascii?Q?nuvKlLd0mpIHZTwGkDSz6EXULAT9KqPpyUHmzYvV94dNkMFdWLHe/OYdcox3?= =?us-ascii?Q?FCOqRBPYxr/bXeA8su4/xyvaybNLAKmhK5mNrW6MPXzi5vZn8+VBjdWkzHz4?= =?us-ascii?Q?NihohT+rD2T5HLkxRz6AhkqDrVD3CQ71s3SRdPDfivQHxefaGmk4BZSQPPzd?= =?us-ascii?Q?C5yjkJE4bqW7BQ0gULdQGNky8PdZn7L2u4NAY+2tlrbQA4Ijtb4kKDoDC3sr?= =?us-ascii?Q?F4FG7GIP4DQ8yG1AzHSkZstuFPVoSnU33MRJsyLfmMU/zpx/U70fOO5P+/gH?= =?us-ascii?Q?iGI2l5p9PIxVkmgDWsgVCVlJU1VcK5QVvajPak6zHqS4FhpDlp9FL8AX5N4l?= =?us-ascii?Q?V4S1QRt8eb/OvzLKSa6BEEF80wNN1ntuGDHOx8h3KrRAYjhxcgfoxNFSzYua?= =?us-ascii?Q?Er5DlVLSCxctDAmJA+DKRc17+2K/VxdWdp3Uxaq/c5PAusbP3yk76yaIMSw0?= =?us-ascii?Q?GEKYpi6ifC3FKou2KpqFiF30Fc+3etxzQapaD1sZcg7L9svmPunLbePvLd3m?= =?us-ascii?Q?ZDQoWA1yxA6sE4dIo3+JVbkaENsKAML3PTIT3qdySJOov50eLMjUDvLA+zIe?= =?us-ascii?Q?QY2LagsMaIMyiIafl8tOlmBDA2XrJ0hlFKLtpRHv2a+Pkkv9PmCoiHZozWpy?= =?us-ascii?Q?TAVnjaS19AaoOXXB9ddyKJiI8IG6cjZLBEXoo/PjJQC4ZlBDiflKBmTxHnFM?= =?us-ascii?Q?JwOmM5yshAi1IgKHFcG/LIUeOu+lIZtY8b1rrBHgUrEsPru1DsmiaHAQJu9R?= =?us-ascii?Q?lYjtlggLugUHgzUdyU70w2mbzGPZg9wRvwjP6RNdwlDPY7A0RvEoQISEDrDK?= =?us-ascii?Q?yicTkeCEhyseEMV9uIhRPGNsvYofDzBwa+Dyxpg5TE2AQzI6HKuEAknbWmRX?= =?us-ascii?Q?saL6zh2fS0JRqAD7MaQmrYhLyj/0YWGfj2LIq2ORfZuMZ6aroH1mDGP0Yric?= =?us-ascii?Q?oLhFZ7YBBrvFjCfLBqf2gnBpGXorJp7o1ZqCMwgUM+ObiqU85WQQIig4w98D?= =?us-ascii?Q?4UiFTrv+b7M+BQLN3GXx/eQKZ1oxLcgj/O2SVh8M?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5JvSSm4mCRix5xJk6SPsel/do0r1/TLzF3Axt6nMnU6fB+7EPz8PVFaPO2bI/CNbnDH4a31hr/CZ8MhUXKfPLY9YUUGRO/jxM61wPJR3c9g/923CJa1zibryr3olwhB+9/NNDUT6QHbpLfFVfaUpjVReHFiox/HG/JieMsFYhM0Tpy2X63QHP8rvPRmvPVm18BeYkIrBny7wPOrMnzU7Lidb9DKs7mdqOKWDVxeqs6YywnZosQ+NjEv7I3yO0uAwl8Ve0dPJ7bPztHhvRyZnUIsjk1LBt71gHSUqpVUAmw6VLWoBOZYk3d7pSTmTV8A7Rch6WbilrTUPF4GcEx+2ajpGmQrhZgPW+RYP5yVp7Uk/D4ITv3+U4i0Lggtm38/9NdO4Lbokhq5uJzygiY1ta3kd5xnTtam5ceq47vrpH24GaAnB9ZCrwLtfu22LlY3/7t9dR03Hvz2KObSFXMT9viVErPRnm38EumzeHjSYfoR3T6NlsF8fI1FtpASnHBk53cutAZYQndIWwtFn+6JAuL0N/4U64slQNBBt18QO6WQH16VOIZI+V/+eqElRhxSIAyHUWwXW6lh+f//aG5rRTbQppAWvdA6mhz1FYW00B5oPBgNm5ddNnKMib0wZ4rhTa2paJ/A39tptScuVQ60zHtM3kthQ0YSEQDS/5YQnYgNG2nR8XYqdfzD8Gf12rjGGAEcNgUFnkNUWB3QxRP+XNzUfnlnlFknkXtk3tP5MsaMzQhWDKNFrCPHQKiLjsvUJcF1ZJkeI7pB53lRTH1yBxw== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99c00c56-174a-44a4-55d5-08db03e3c16f X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 23:34:54.2534 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JU0Uxno6JzJqMqR4utbvIiv4BAZTbW2J3q8fQOS0VEbLcC79IIQuvPtGCzaCT3tE5GWSsxDLfRoZI8TG/rRBaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6633 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-31_08,2023-01-31_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301310202 X-Proofpoint-ORIG-GUID: jwlVXkss1Q6ChDDpaOMPgJ2GCahCZVR2 X-Proofpoint-GUID: jwlVXkss1Q6ChDDpaOMPgJ2GCahCZVR2 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: SFrame format is meant for generating stack traces only. include/ * sframe.h: Fix comments in the header file. --- include/sframe.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/include/sframe.h b/include/sframe.h index 58ef07dcc21..58907d73413 100644 --- a/include/sframe.h +++ b/include/sframe.h @@ -34,8 +34,8 @@ extern "C" /* SFrame format. SFrame format is a simple format to represent the information needed - for vanilla virtual stack unwinding. SFrame format keeps track of the - minimal necessary information needed for stack unwinding: + for generating vanilla backtraces. SFrame format keeps track of the + minimal necessary information needed for stack tracing: - Canonical Frame Address (CFA) - Frame Pointer (FP) - Return Address (RA) @@ -59,13 +59,14 @@ extern "C" .text.* sections in the resulting binary artifact. Each Function Descriptor Entry specifies the start PC of a function, the size in bytes of the function and an offset to its first Frame Row Entry (FRE). Each FDE - additionally also specifies the type of FRE it uses to encode the unwind - information. + additionally also specifies the type of FRE it uses to encode the stack + trace information. - Next, the Frame Row Entry section is a list of variable size records, - each of which represent SFrame unwind information for a set of PCs. A - singular Frame Row Entry is a self-sufficient record with information on - how to virtually unwind the stack for the applicable set of PCs. + Next, the SFrame Frame Row Entry sub-section is a list of variable size + records. Each entry represents stack trace information for a set of PCs + of the function. A singular Frame Row Entry is a self-sufficient record + which contains information on how to generate stack trace from the + applicable set of PCs. */ @@ -81,7 +82,7 @@ extern "C" /* Function Descriptor Entries are sorted on PC. */ #define SFRAME_F_FDE_SORTED 0x1 -/* Frame-pointer based unwinding. */ +/* Functions preserve frame pointer. */ #define SFRAME_F_FRAME_POINTER 0x2 #define SFRAME_CFA_FIXED_FP_INVALID 0 @@ -181,8 +182,7 @@ typedef struct sframe_func_desc_entry uint32_t sfde_func_start_fre_off; /* Number of frame row entries for the function. */ uint32_t sfde_func_num_fres; - /* Additional information for deciphering the unwind information for the - function. + /* Additional information for stack tracing from the function: - 4-bits: Identify the FRE type used for the function. - 1-bit: Identify the FDE type of the function - mask or inc. - 1-bit: PAC authorization A/B key (aarch64). @@ -271,9 +271,9 @@ typedef struct sframe_fre_info Used for both AMD64 and AARCH64. - An SFrame Frame Row Entry is a self-sufficient record containing SFrame - unwind info for a range of addresses, starting at the specified offset in - the function. Each SFrame Frame Row Entry is followed by S*N bytes, where: + An SFrame Frame Row Entry is a self-sufficient record which contains + information on how to generate the stack trace for the specified range of + PCs. Each SFrame Frame Row Entry is followed by S*N bytes, where: S is the size of the stack frame offset for the FRE, and N is the number of stack frame offsets in the FRE -- 2.39.0