From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 737073857C44 for ; Tue, 31 Jan 2023 23:35:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 737073857C44 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30VIiaPM023158 for ; Tue, 31 Jan 2023 23:35:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=dv4jFbzx11ePMVeCcvU560smKBlCnnVcINEFr/4qs6s=; b=PVZivXdyjJxJSEYi2IXbOphBvClqB/Y/zkH2tzVq9i4jDfGecHvkrm9W2hEkfGQspetR IHvplK7YqvBTRu+c+8t6fROYIdaK2mvj4jlJ4dg7jwi2nPCb7Mtmxu8yFbpoNIckvu4O Kj9AoouH8qNuzdD+N/bu97wVneEXrQTsoOMuWwybm6gurjgpUM7b1azF5Ghk1NIG/c/q zcmPHyTtk354NCUli+fA4uXrj4NwnX7+prA4PMtO0CA9R8xUfiVPRKbOa275GVGAN6pX gB2IQB6/ULgUSoWOQ2+zeR0wcaJIV1t9jKY78ANEZ6ZPc20bm987RCSktSqzMkpkSQDy wA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ncvr8q2kc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 31 Jan 2023 23:35:00 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30VMw53d012954 for ; Tue, 31 Jan 2023 23:34:59 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2108.outbound.protection.outlook.com [104.47.58.108]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3nct5d9hsf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 31 Jan 2023 23:34:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OqaOOCeoN8cvtkdyrO1cYQzzDz53cX9pMxqdTKk8Svzxq9rM7IuPG4s822Vg5b60+9TA7tCRNrEIh6y01x3nM17vd8XMVsa3EQ62emLcUHUeEoPtW+znX/rNr2jFP22vwSIyIiXZGgXBg2QDXhQ+baq8+cf6dWvWMPhpCLsdcqjQyvyg9T7Qpf990oSSSuEe+bJlbkeaGDoEqfdjJFUqqvdR4mHboGWyQDmEgl323a8STFbRn+/BdWCsUY74fMjEYQxND2YTWaxA4EIwAokRWEcXLl0AVDqmDR69ESvIznOS8v5+Yn3C2KkfV7hZPMUq9noAYDzlc7qAMiFSpNI0Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dv4jFbzx11ePMVeCcvU560smKBlCnnVcINEFr/4qs6s=; b=G0wLLgxHNRiGBQFxOcDp4wNCAsOpY0rqMzBFh1RsLIEUTSCWE3G1gAvrhqDDGcd4soZCeYTjQLGF3iDD1Um58OMIu1/7OUWIkP2BzFl7UYd9laAmkVZytEaSBSIqOYBLIm5kUrzTPOa+HyA+KhRIpmMtxh7y5y0xfuxKQ6pgzbtJvViUmDf7veqzMYjcwFt7wrJyiCJ8t8CZejZ/7zfaSXbCHsA8g+6/X/dgFmvfMuiZG1l7z3b6jVOaD+VhkJaav8Nlmz7FtmhYAUfEK6NvCum+DP71507kO2moll0RHCsHILtbwLjcj5+2DhoX5UdRNLWLKrKgYHYl22tRFwJ/fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dv4jFbzx11ePMVeCcvU560smKBlCnnVcINEFr/4qs6s=; b=IbrkvdSxr/Z3M2aTYadLQ5ELkfZcmkhjT6ohfV52tdXOYidjs3yW0/NbVdjp13VG0EXx7MvxuKq8iFZrOMntoha0RFUjFXrTvULZhOUQMcqDLrzomiZW3QNFppUI4r7OiBzVJhVl2BoqS2+kFS+GLuq2nIWJSj3V6DPuRz/HSiU= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CY8PR10MB6633.namprd10.prod.outlook.com (2603:10b6:930:57::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Tue, 31 Jan 2023 23:34:57 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::14e6:a522:273f:db57]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::14e6:a522:273f:db57%7]) with mapi id 15.20.6064.022; Tue, 31 Jan 2023 23:34:57 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 3/5] gas: use "stack trace" instead of "unwind" for SFrame Date: Tue, 31 Jan 2023 15:34:27 -0800 Message-Id: <20230131233429.3708328-4-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230131233429.3708328-1-indu.bhagat@oracle.com> References: <20230131233429.3708328-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW4PR03CA0144.namprd03.prod.outlook.com (2603:10b6:303:8c::29) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CY8PR10MB6633:EE_ X-MS-Office365-Filtering-Correlation-Id: ccd62737-3f17-40ca-afde-08db03e3c317 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iwyJxW0D6Dqk8xqqg5CJ2qL92q9WfzErkw9lkSsNwPgrSdcw7g8hbrssGkmvJTd3jYVaddz4cOmhDqJ522r6p4ju4yjZVw2iHrCZdt0GJcUcHaGsD6BGpJtigB6NYYXYNwvsSPvLseP+BkzYWYaEtjwUCqRNyOEVdAGnbmN9AOUnpmhMjTsEkH45Sxj/BM35D9dWh7t5SNMczdqfExWP4At4QtQNGkg+e0rAy8fobB8ZRo4ddqQWoZHRg9sIuPgA6TRJmBVD0G9bTf73UayeRT3ymIUrOfLXBhcoGUUWJruEUh8h0Aef6+ejO65i2uk7zvn3pWlA1caylHVl1HVwGLWZsJXx+tla/csnztg330X8G7BSgd8GRb6u+QT2gdI+GZipMzuFDiP7YnCsobnAglV6BKLOawVKt2frmJZ/jX0Gc1vSvlhETB5MIMotFQGrKLMTi3w8XtX7oT4gPV0gEIFhnXJuA0Pv2I5Ld4wmDecR0CnIp1ZxIfsobjBiZhWfs4D09JDmh0gPPdfu89jVTgBHp9/7Mo8mwcR/lP1lV+kjf9MXtmGJJ8w7qI5Y73akt0OMkX63HbSpctSkTJA1ed24fcocmScc8o+e9MH7ffENHM8GcyEe7WnhphnLioS6exh1wm5VLvMe7KFg2QoC+w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(39860400002)(396003)(376002)(136003)(451199018)(2906002)(8676002)(4326008)(6916009)(38100700002)(478600001)(44832011)(8936002)(36756003)(26005)(30864003)(6506007)(6486002)(5660300002)(107886003)(6666004)(186003)(6512007)(86362001)(2616005)(41300700001)(66476007)(83380400001)(66556008)(1076003)(66946007)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Qkak+bu/ElZK00vIkP3FYHchDhUzEK098ffGVLgvn8P7aiJKtt0LaLTmVzMl?= =?us-ascii?Q?k2577U7W1nJSSnYWWXb0WfUk9iadx6QtYkjgKiT2uwwWKxTpwLnc5vqvvF97?= =?us-ascii?Q?7gpon5b47LnFSqrULJiJN2DbXVxaSE+Gbk8ZEsN1eqxPiK9mqXLWVEmWZZDT?= =?us-ascii?Q?17nEqJMERmLYQGO07BCiR41x693S8zR04OFH0+ERIbQ4gT6WYrSLvw3o8P4v?= =?us-ascii?Q?oQMLmTPrQBOi6hCwnvsnaHtfgq/7OKELAMBGzsAmE1+GP5NoNh18p1tQvCdB?= =?us-ascii?Q?6f5WpRS8hc217ISJBz4guUE/Eeq08wm1RPdO+D9pTVZc1+a7uFavABOMbd3U?= =?us-ascii?Q?dLdqVaG5sEQYX+MH+ReXDAERwqlNGIjOeOJ+tHhe4Aws8nJoFZPmhPaVUlvy?= =?us-ascii?Q?N9asXfFnfI9TWc5jEGA7onaEvlYdmBUvXVDNGATnpC0pfLmuxYl93CgrWADQ?= =?us-ascii?Q?occF6z90uErqPRMQvJVTxfSjUZn9xRZhkQgXuZNDhdSNa5S7MiNe69/VBxKp?= =?us-ascii?Q?ICSWzWTtYj/Jo+rh1VgzQewPRr7HwOtQBvefxwcKyzBQ0yGFZiSCw0sDuxZo?= =?us-ascii?Q?q7636E5JG20/bZ3tExVsKXjgVvpNjgaq5/uhAHw31O07KtTReS5opztqoBxM?= =?us-ascii?Q?CgLYubHFAr0c3WnbLZzuUAUrXJBIAb0wsUtm90RPd16J4cU4YAJkJIM+ZV6A?= =?us-ascii?Q?B6Z7Mxu/v8GZs50/aB/hq/unNk8UgqvnsuH1UYCgtLp5rSYM8wn6bSl/CJxu?= =?us-ascii?Q?xsJ9gpqskPDmPCdppKKf/jqWsnQUn2zYq6OA5bsORwH0uhMQOuL6q8Qe6DeX?= =?us-ascii?Q?fpbWZOHzXBg3/VnczxsM7yug9HnB+vFGFj5bGANOpkYW7XSZx4y8F7lC0s8x?= =?us-ascii?Q?U2RBpV5W9lQYQIJBidy4Ni3bl8gu7ycqkwrhUS50IiRpl6XoWoTvUjvpr4vq?= =?us-ascii?Q?DC8NWQfQNLPM245Uf/pLfToCgexBo+EFjJC7wdFn2RSs67n5oYSGcUb7agCZ?= =?us-ascii?Q?xJG7wNwvbbS+oSsqHqo6UeQnHwPeDnh+gXpB+HmGBX4MzZFNYyKc7ZtMQ4Mg?= =?us-ascii?Q?+6/pFOw51rQcoMO6rQkk05jlXg6yClom1DZdEdP93s9r4pChGyffQafV9zlt?= =?us-ascii?Q?yXtIScpgeSoahX/UuQcdDWtGOas2vDV5peXlbEpPta2dQkHF2iP6m2j4rKxB?= =?us-ascii?Q?6W8fXbFDtGSm8qGO0Ajf3dcBeZ65iNCXUTyIKBCxnVhjq135vybtWrXGPMV0?= =?us-ascii?Q?eh/0SJEJOVH0X03piPdJqbs479VCI9KC+52kDmHB5sR7hIyzH468484RFvUL?= =?us-ascii?Q?rpxbojeuencqpRpDmXxbuBhXUYGtPhLd/3kDYE36MntpPOW0G2P1CXM7wm13?= =?us-ascii?Q?926YdhMiJRst3wbz1JirzuThjPwC0huLyOFY1GBNf86JzAQzjKOTjrayv/cK?= =?us-ascii?Q?qKWnYd6VsS4nMgTotfrTZRirara4+bBed53IozNCKoXc1jA0W7vgbUITz3BM?= =?us-ascii?Q?UEneiJ78zSW4dKmdqdZPJbOWONgFrOYNVIHyHSZ47KWipko3I0wgd8yz5AEG?= =?us-ascii?Q?+0RdM+LyeApyYdVFdywcNSh6bJuNBn8ZZQloNkRQ?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: yR5wOuSiTA7gvSiswSA0V9Y601mUXrYJrrwMquh/id2VuzWVq4grTVvhycduX/eBOE2bUqdWxKzYB5BsPVkREYlWx51dUpOdBB0NvWyZn3ua23EpGz6HXfeT7mLKfvJ23cstKUFoQn9cUGFyityrqAdOaxErrBmNWmUJpOkRov5yySajCyeUzNhT2ePJap2JuSkBwEo2H/taEYE7nUNIAteZYQ/NLXESV2n748RjOT53aE7+TzyMhdzDtU8POBRWqeqtAgZJsmGlJfxy302Ghag1/8WhvTr0S17eu4ymHm/aCQTHMJRnSB91Ck1sHf5LIo22o4OLtnAgI0BmVp4mR3q9HwSiNDibNm+Q2bY5o8NS0h2QOLXaYssSBAfWx25AIolqSVaFJbRDtc3NsyT3ZC0b+lP99853kljF53M5PyVJT5OjYPHgdPNszVYEQDhD8/YkahqprYfLyPOdGPX8MsYyA//JYyEgQtZ40OoRVj5/8bxw0l0gFWNYi0q6XP1WA0M0pQt8GqBQOIgCDT5XgQHEAak+NtvKUC5CMl1Z7X+c5erKpmAxjslWO8S3Ec9ct13KmArvZHA3eiWArdciSlM42WUC7bd3ByZGOwpAIuygdAEnJ3cvSzHq4l/pzlvURxnevF52KLJ7+jaBB9+2jAEfle4n0qlHX0jaSDB97BwKjanc5nqNQLLMak7bZTVZSp0Iy6z3d+MbUHKk6n2XK06sVmqeUW7EJrdUOozklRxNaj6UYVDYNMuC0odp8pOsyB2dyYL4kVvyt2SN7r9NLg== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccd62737-3f17-40ca-afde-08db03e3c317 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 23:34:57.0344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BEtaWpYJe+x0/Z4j04VtlJ/65dRFWOO8m3fWL5fvGiwxJ9p7UBtyNpm30BmwgQoxggpWsP/UbQp6XpINP4Cuqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6633 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-31_08,2023-01-31_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301310202 X-Proofpoint-GUID: MDsxJHWQ3jyjjpnAVkdwvFuOWkHWFy3- X-Proofpoint-ORIG-GUID: MDsxJHWQ3jyjjpnAVkdwvFuOWkHWFy3- X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: SFrame format is meant for generating stack traces only. gas/ * as.c: Replace the use of "unwind" with "stack trace". * config/tc-aarch64.c: Likewise. * config/tc-aarch64.h: Likewise. * config/tc-i386.c: Likewise. * config/tc-i386.h: Likewise. * gen-sframe.c: Likewise. * gen-sframe.h: Likewise. * testsuite/gas/cfi-sframe/common-empty-2.s: Likewise. * testsuite/gas/cfi-sframe/common-empty-3.s: Likewise. --- gas/as.c | 2 +- gas/config/tc-aarch64.c | 4 +-- gas/config/tc-aarch64.h | 8 +++--- gas/config/tc-i386.c | 4 +-- gas/config/tc-i386.h | 6 ++-- gas/gen-sframe.c | 28 ++++++++++--------- gas/gen-sframe.h | 2 +- gas/testsuite/gas/cfi-sframe/common-empty-2.s | 2 +- gas/testsuite/gas/cfi-sframe/common-empty-3.s | 2 +- 9 files changed, 30 insertions(+), 28 deletions(-) diff --git a/gas/as.c b/gas/as.c index 602ed3b5f79..f548294c3dc 100644 --- a/gas/as.c +++ b/gas/as.c @@ -317,7 +317,7 @@ Options:\n\ fprintf (stream, _("\ generate GNU Build notes if none are present in the input\n")); fprintf (stream, _("\ - --gsframe generate SFrame unwind info\n")); + --gsframe generate SFrame stack trace information\n")); #endif /* OBJ_ELF */ fprintf (stream, _("\ diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c index 2aeab6f958a..980710e8992 100644 --- a/gas/config/tc-aarch64.c +++ b/gas/config/tc-aarch64.c @@ -76,7 +76,7 @@ enum aarch64_abi_type }; unsigned int aarch64_sframe_cfa_sp_reg; -/* The other CFA base register for SFrame unwind info. */ +/* The other CFA base register for SFrame stack trace info. */ unsigned int aarch64_sframe_cfa_fp_reg; unsigned int aarch64_sframe_cfa_ra_reg; @@ -8474,7 +8474,7 @@ aarch64_init_frag (fragS * fragP, int max_chars) } } -/* Whether SFrame unwind info is supported. */ +/* Whether SFrame stack trace info is supported. */ bool aarch64_support_sframe_p (void) diff --git a/gas/config/tc-aarch64.h b/gas/config/tc-aarch64.h index 134c1f87b4f..f11d04826c3 100644 --- a/gas/config/tc-aarch64.h +++ b/gas/config/tc-aarch64.h @@ -263,19 +263,19 @@ extern void aarch64_after_parse_args (void); #ifdef OBJ_ELF -/* Whether SFrame unwind info is supported. */ +/* Whether SFrame stack trace info is supported. */ extern bool aarch64_support_sframe_p (void); #define support_sframe_p aarch64_support_sframe_p -/* The stack-pointer register number for SFrame unwind info. */ +/* The stack-pointer register number for SFrame stack trace info. */ extern unsigned int aarch64_sframe_cfa_sp_reg; #define SFRAME_CFA_SP_REG aarch64_sframe_cfa_sp_reg -/* The base-pointer register number for CFA unwind info. */ +/* The base-pointer register number for CFA stack trace info. */ extern unsigned int aarch64_sframe_cfa_fp_reg; #define SFRAME_CFA_FP_REG aarch64_sframe_cfa_fp_reg -/* The return address register number for CFA unwind info. */ +/* The return address register number for CFA stack trace info. */ extern unsigned int aarch64_sframe_cfa_ra_reg; #define SFRAME_CFA_RA_REG aarch64_sframe_cfa_ra_reg diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c index e1f8f65f90b..438180cf4e8 100644 --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -607,7 +607,7 @@ static int use_big_obj = 0; static int shared = 0; unsigned int x86_sframe_cfa_sp_reg; -/* The other CFA base register for SFrame unwind info. */ +/* The other CFA base register for SFrame stack trace info. */ unsigned int x86_sframe_cfa_fp_reg; unsigned int x86_sframe_cfa_ra_reg; @@ -9285,7 +9285,7 @@ x86_cleanup (void) bool x86_support_sframe_p (void) { - /* At this time, SFrame unwind is supported for AMD64 ABI only. */ + /* At this time, SFrame stack trace is supported for AMD64 ABI only. */ return (x86_elf_abi == X86_64_ABI); } diff --git a/gas/config/tc-i386.h b/gas/config/tc-i386.h index 49d2d25a7a6..9247cdeab8b 100644 --- a/gas/config/tc-i386.h +++ b/gas/config/tc-i386.h @@ -363,15 +363,15 @@ extern bfd_vma x86_64_section_letter (int, const char **); extern void x86_cleanup (void); #define md_cleanup() x86_cleanup () -/* Whether SFrame unwind info is supported. */ +/* Whether SFrame stack trace info is supported. */ extern bool x86_support_sframe_p (void); #define support_sframe_p x86_support_sframe_p -/* The stack-pointer register number for SFrame unwind info. */ +/* The stack-pointer register number for SFrame stack trace info. */ extern unsigned int x86_sframe_cfa_sp_reg; #define SFRAME_CFA_SP_REG x86_sframe_cfa_sp_reg -/* The frame-pointer register number for CFA unwind info. */ +/* The frame-pointer register number for SFrame stack trace info. */ extern unsigned int x86_sframe_cfa_fp_reg; #define SFRAME_CFA_FP_REG x86_sframe_cfa_fp_reg diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c index d6961f893a6..c5470596d14 100644 --- a/gas/gen-sframe.c +++ b/gas/gen-sframe.c @@ -33,7 +33,7 @@ /* Whether frame row entries track RA. - A target may not need return address tracking for stack unwinding. If it + A target may not need return address tracking for stack tracing. If it does need the same, SFRAME_CFA_RA_REG must be defined with the return address register number. */ @@ -892,7 +892,7 @@ sframe_xlate_ctx_add_fre (struct sframe_xlate_ctx *xlate_ctx, xlate_ctx->num_xlate_fres++; } -/* A SFrame Frame Row Entry is self-sufficient in terms of unwind information +/* A SFrame Frame Row Entry is self-sufficient in terms of stack tracing info for a given PC. It contains information assimilated from multiple CFI instructions, and hence, a new SFrame FRE is initialized with the data from the previous known FRE, if any. @@ -1024,7 +1024,7 @@ sframe_xlate_do_def_cfa_offset (struct sframe_xlate_ctx *xlate_ctx, gas_assert (cur_fre); /* Define the current CFA rule to use the provided offset (but to keep the old register). However, if the old register is not FP/SP, - skip creating SFrame unwind info for the function. */ + skip creating SFrame stack trace info for the function. */ if ((cur_fre->cfa_base_reg == SFRAME_CFA_FP_REG) || (cur_fre->cfa_base_reg == SFRAME_CFA_SP_REG)) { @@ -1081,7 +1081,7 @@ sframe_xlate_do_val_offset (struct sframe_xlate_ctx *xlate_ctx ATTRIBUTE_UNUSED, /* Previous value of register is CFA + offset. However, if the specified register is not interesting (FP or RA reg), the current DW_CFA_val_offset instruction can be safely skipped without sacrificing the asynchonicity of - unwind information. */ + stack trace information. */ if (cfi_insn->u.r == SFRAME_CFA_FP_REG) return SFRAME_XLATE_ERR_NOTREPRESENTED; /* Not represented. */ #ifdef SFRAME_FRE_RA_TRACKING @@ -1103,8 +1103,8 @@ sframe_xlate_do_remember_state (struct sframe_xlate_ctx *xlate_ctx) struct sframe_row_entry *last_fre = xlate_ctx->last_fre; /* If there is no FRE state to remember, nothing to do here. Return - early with non-zero error code, this will cause no SFrame unwind info - for the function involved. */ + early with non-zero error code, this will cause no SFrame stack trace + info for the function involved. */ if (!last_fre) return SFRAME_XLATE_ERR_INVAL; @@ -1248,7 +1248,7 @@ sframe_do_cfi_insn (struct sframe_xlate_ctx *xlate_ctx, default: { /* Other CFI opcodes are not processed at this time. - These do not impact the coverage of the basic stack unwinding + These do not impact the coverage of the basic stack tracing information as conveyed in the SFrame format. - DW_CFA_register, - ... @@ -1285,7 +1285,7 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, err = sframe_do_cfi_insn (xlate_ctx, cfi_insn); if (err != SFRAME_XLATE_OK) { - /* Skip generating SFrame unwind info for the function if any + /* Skip generating SFrame stack trace info for the function if any offending CFI is encountered by sframe_do_cfi_insn (). */ return err; /* Return the error code. */ } @@ -1309,10 +1309,11 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, return SFRAME_XLATE_OK; } -/* Create SFrame unwind info for all functions. +/* Create SFrame stack trace info for all functions. - This function consumes the already generated FDEs (by dw2gencfi) and - generates unwind data in SFrame format. */ + This function consumes the already generated DWARF FDEs (by dw2gencfi) and + generates data which is later emitted as stack trace information encoded in + the SFrame format. */ static void create_sframe_all (void) @@ -1330,7 +1331,8 @@ create_sframe_all (void) /* Process and link SFrame FDEs if no error. Also skip adding an SFrame FDE if it does not contain any SFrame FREs. There is little use of an - SFrame FDE if there is no unwind information about the function. */ + SFrame FDE if there is no stack tracing information for the + function. */ int err = sframe_do_fde (xlate_ctx, dw_fde); if (err || xlate_ctx->num_xlate_fres == 0) { @@ -1355,7 +1357,7 @@ output_sframe (segT sframe_seg) /* Setup the version specific access functions. */ sframe_set_version (SFRAME_VERSION_1); - /* Process all fdes and create SFrame unwind information. */ + /* Process all fdes and create SFrame stack trace information. */ create_sframe_all (); output_sframe_internal (); diff --git a/gas/gen-sframe.h b/gas/gen-sframe.h index 77630255e8b..0a0b3658302 100644 --- a/gas/gen-sframe.h +++ b/gas/gen-sframe.h @@ -149,7 +149,7 @@ struct sframe_version_ops unsigned char (*set_func_info) (unsigned int, unsigned int, unsigned int); }; -/* Generate SFrame unwind info and prepare contents for the output. +/* Generate SFrame stack trace info and prepare contents for the output. outout_sframe () is called at the end of file. */ extern void output_sframe (segT sframe_seg); diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-2.s b/gas/testsuite/gas/cfi-sframe/common-empty-2.s index 146c53de785..53bb8c0ce9b 100644 --- a/gas/testsuite/gas/cfi-sframe/common-empty-2.s +++ b/gas/testsuite/gas/cfi-sframe/common-empty-2.s @@ -1,5 +1,5 @@ ## CFA register is not defined to be SP/FP. -## No SFrame unwind info for this function will be generated. +## No SFrame stack trace info for this function will be generated. .cfi_startproc simple .long 0 .long 0 diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-3.s b/gas/testsuite/gas/cfi-sframe/common-empty-3.s index 982fe0c851d..cd58499619d 100644 --- a/gas/testsuite/gas/cfi-sframe/common-empty-3.s +++ b/gas/testsuite/gas/cfi-sframe/common-empty-3.s @@ -1,5 +1,5 @@ ## The return column is not the default value. -## No SFrame unwind info for this function will be generated. +## No SFrame stack trace info for this function will be generated. .cfi_startproc .cfi_return_column 0 .long 0 -- 2.39.0