From: "Clément Chigot" <chigot@adacore.com>
To: binutils@sourceware.org
Cc: amodra@gmail.com, "Clément Chigot" <chigot@adacore.com>
Subject: [PATCH v2] ld/testsuite: don't output to /dev/null
Date: Mon, 20 Feb 2023 15:43:02 +0100 [thread overview]
Message-ID: <20230220144302.1234792-1-chigot@adacore.com> (raw)
Mingw doesn't have /dev/null and thus "-o /dev/null" will fail.
Currently, all the options are checked using this "-o /dev/null",
resulting in them being disabled on mingw hosts.
Fix that by outputting to a real file for all targets.
ld/ChangeLog:
* testsuite/config/default.exp: Replace "-o /dev/null" by a
file.
---
ld/testsuite/config/default.exp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ld/testsuite/config/default.exp b/ld/testsuite/config/default.exp
index 257fd4ba985..1b568b6f8bb 100644
--- a/ld/testsuite/config/default.exp
+++ b/ld/testsuite/config/default.exp
@@ -383,6 +383,7 @@ proc compiler_supports { flag args } {
append flags " [board_info [target_info name] ldflags]"
}
set fn "cs[pid].c"
+ set fno "cs[pid].exe"
set f [open $fn "w"]
if { [llength $args] > 0 } {
puts $f [lindex $args 0]
@@ -391,7 +392,8 @@ proc compiler_supports { flag args } {
}
close $f
set rfn [remote_download host $fn]
- set avail [run_host_cmd_yesno "$CC_FOR_TARGET" "$flags $flag $rfn -o /dev/null"]
+ set avail [run_host_cmd_yesno "$CC_FOR_TARGET" "$flags $flag $rfn -o $fno"]
+ file delete $fno
remote_file host delete $rfn
file delete $fn
return $avail
--
2.25.1
next reply other threads:[~2023-02-20 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 14:43 Clément Chigot [this message]
2023-02-20 17:11 ` Howard Chu
2023-02-20 22:22 ` Alan Modra
2023-02-20 22:18 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220144302.1234792-1-chigot@adacore.com \
--to=chigot@adacore.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).