From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id DE2C838515DD for ; Fri, 17 Mar 2023 16:01:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE2C838515DD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32HFZIR1015288; Fri, 17 Mar 2023 16:01:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=Ij7fYhIIBl9/XQNeSZkkE5g3pyBkkeCEi9ESIBzF7EE=; b=pHG9knjq8k3K7EWVmThphTRbi6N/bC2KY6k0k7dDqfR80chegrnKNmQ/rOQMu4G7zio8 +HHE/Gn0K97vbKynpF4MYQ/b0LMMRSHOeL521/yBd1mYarCOFDGCLHqafehTuleM8VlJ DbU1jX+3RGNDuuqDwpOVTw6cbmY0L2JLLsvZLTyy3qVyz/bwGEqIUS3dmD+5vnuejVGA SxUK25cLJIdZpNGUECChQ6S+PGwICCTdIiupGOIqynshSHGcnQkjywv5I4xpCSK29Q38 jUUocuch0NXRlHgJtkN0MPJL+MGfTYpmzGEiPOhzcs+ep6ZDKRjiH5eAhnqrFiMMfSaw 5A== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3pbs2am91c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Mar 2023 16:01:41 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 32HFW3Cu020727; Fri, 17 Mar 2023 16:01:40 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2049.outbound.protection.outlook.com [104.47.56.49]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3pbq46f1vy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Mar 2023 16:01:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nRaKFOlhS8D+Svi3RR1xU+peXIpCjrasEk0bDn8NNrXXrUKR8y95q2ifVQSdNLlHCWmum7uYZ4zZ4nVNHs7KNyhm30jgDpwz5GJmF5rC7EdBut0iU3So1eEJGbWIepYvQ5UKhgX1PvXIWi06/BpQa4NzUO+nZ6owXJAlW+E6wY1c4N1PRl/QJVPiodnh2Pdh/KO5ueOy6mFR1V4f0xRuL2ZxZ7ahNPscqy0Y8NoOblL0iw2t+Px/Hk1f5IJXomzwJloHqFxajzQQewwrKS3n0yrFz3vqwAuIet0OHfgHarkkUNx7/wWSWjZj845cZgT4qE/Dg/n02JxbYbDVeQmX9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ij7fYhIIBl9/XQNeSZkkE5g3pyBkkeCEi9ESIBzF7EE=; b=OUG+8gEL76kClH8iUMc0/JKv0XgfOzb6RGGozFfcbRYHPcoydDWRfcyHvpOUyTjXwPmVMd4H2VscRZCFnPSz6HEH43+BfdRSKaxfrIWVcm375v5EYtoOsueM7dv2bkCfyW8eKWtbgPGXmnjU7QovVGHsK7zd1hr5aky4JtuFvM2Fa0wZ6DH0sx4dpMkdvHR2FPdU8uQBFE42+j6vSmZwMqldWKOSNXs3f8J+iuTBqTKocHNGuEX9aEB2qRFtBCeDMTpf0yl6Ro6cygoSDNdTcnmebQ15lRp/P7ZF2O9lpfK9/L+F+P0c/iB0CcTL1A3wDD4R2Stqc8vnGFHsoOC/qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ij7fYhIIBl9/XQNeSZkkE5g3pyBkkeCEi9ESIBzF7EE=; b=xPvg1RK27dPGxwrj0aK5sEhaEQfS5Kow8keYI9/SPCoIb0axYVtl5Ikz6k4vTsw8kcj/8VNGYWM+qZgIjXrxi9PiSpiEeqcXIzZKt8JLcvoi2VtKt+10jNe9pnWGwiPezDfUXzGQ2UMlCgRgN8qSVN5qB7xlGqqFauoMu7u1d88= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by CH2PR10MB4358.namprd10.prod.outlook.com (2603:10b6:610:a8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.35; Fri, 17 Mar 2023 16:01:38 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728%6]) with mapi id 15.20.6178.035; Fri, 17 Mar 2023 16:01:38 +0000 From: Cupertino Miranda To: binutils@sourceware.org Cc: jose.marchesi@oracle.com, elena.zannoni@oracle.com, cupertino.miranda@oracle.com, nickc@redhat.com Subject: [PATCH 1/2] Reloc howto access broken for BPF Date: Fri, 17 Mar 2023 16:00:44 +0000 Message-Id: <20230317160045.502282-2-cupertino.miranda@oracle.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230317160045.502282-1-cupertino.miranda@oracle.com> References: <20230317160045.502282-1-cupertino.miranda@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM4PR0501CA0064.eurprd05.prod.outlook.com (2603:10a6:200:68::32) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|CH2PR10MB4358:EE_ X-MS-Office365-Filtering-Correlation-Id: 6754342c-0673-42ab-6deb-08db2700e3f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4XtmvQDu+oiHy+bPJESyhGOITxyUCmLkLGEs0m7M2NH6Vt5vidXUhR06hFIGzftTqh90zndgu5kX+R+i0SCFKSqcPS85VddnfnIECGwXubSv3mLnZr3TqD2SWZNg2JBPaCZ2WX4HaU6NR4zC9JE7pAR2ywV50laxUf7SQ4TleHTgQMxPEgfPQcONhTKIRjMN58qnqr+dippyhwGK3hww/h4kpTSPyt24c3XRKkUZAiaLWLOnTWeQzwo+PsPzQ5hGWAYSMFCEdvrLYIT+OzY2t3GF4fgQmXxwOUwbaUTSaJ2A5nEyoe3YSvychRMuXxYIF+Q6CBLK2COF+ZpVpUn2dsZQkfvDxaaqLwAm0SRvyTtSguDU3Sr2qvDJ7ltzqnet1cJOWzBELEm76mdqVnt+jPQ9nXnghYx7REXj93oEgbl6My/l4/riiPx8kpWF71QNvI1cene8SFikt9tzInZk72CWN6sMNjj1l52n4ywXJ72cXNwdc8GxXowHsOSwoS4iPlFuw/iIa8tX3+EwGtD9TWMkp+ZXH4PQUhZpikOFX48UuujcEybydOJz+veZVjUEV/2eNhyjXd4GSlDsDRbSFI4oVgHqUlIun5sC01uBC/z3kjLXh0LFTMyfCT2tiWfQyIsCsklq1ejxD49ss6udUw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(136003)(346002)(396003)(39860400002)(451199018)(44832011)(4744005)(5660300002)(4326008)(6916009)(41300700001)(8936002)(86362001)(36756003)(38100700002)(2906002)(6486002)(6666004)(478600001)(83380400001)(186003)(2616005)(6512007)(1076003)(6506007)(8676002)(316002)(66946007)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d6AA0pGa18vIEBL6U+qEDOZgByHOcnwqsxyeiA0ZA8jr6+fQ7/+v18mP9MKH?= =?us-ascii?Q?fKHgofDWndbxoNYWmvwvnRI1bfPRJuku2fxZEICV0aCJW7slKDbLJxgZOpZt?= =?us-ascii?Q?XfR462MrrvmuaqXXViDcBG8ItpmjA94xuvYIs+iHQs3JlzL37dg3DLwTRMqr?= =?us-ascii?Q?TZHPot+XZKNA/NWw2qt57o6TktIz+uhfBjhVQQR7lyE2GnZ/DIMtKrMl4bKX?= =?us-ascii?Q?ApWq22a66DWpzbmhhEOvLy2fGmp3V1TcJ/cyXkdUmV+TllfXz6X9V0oXG8VM?= =?us-ascii?Q?N1ZrV0LKrwbtL2pcp1eeHdSmKTt5IrGPQ5bXllD1Z8vxQd/ZznPZ06Gkp+d1?= =?us-ascii?Q?xcnXdFXryeZ/amA48DSUuauZwAqoTPoiGeZd8Jjw6KmCmVdHfn+Fk3n8byp3?= =?us-ascii?Q?kZ8Jj5jIw+x2OHc2znlyKX+7WTZXmodqF702dKPhC/RWcV53Cu5H7VQ6g+eO?= =?us-ascii?Q?jneZZIFu17WjDkDOar165pPxGzh8kIU8oR0S2r/v1uJVZVFy84FyaHzl1OjL?= =?us-ascii?Q?PPeC4raqrOteVjwWJzikkVWwHYYwrDiRg6b0ZXDXsP8SZj6aus2VA4BAB1EL?= =?us-ascii?Q?M41ARU7Zcdvq529FeN+pc37RpA3g+TLwjUGv52Iwf1vHtFj7MwunAdATwHm9?= =?us-ascii?Q?Ia7tXoTwKsh20Uw6pVR4J3OfL0wmeg5BjFBMYGim9ub4C7BPHliDfga6jXhT?= =?us-ascii?Q?pHCJgVNqQx+kGuCk+USHREGu4qZ60DKrM7mQxAGGOCHwsqjIjyiIGgU8psbe?= =?us-ascii?Q?N4LoMPtG3fwKrEFcG7QI3fooncj3R3nRUlAkTI37OlAKJ8/iN/joo2jciy9z?= =?us-ascii?Q?j2ibtBHWyHmFpLPaHDlaD4iV+OKid/ZV6D0uVVOPBVxRQImDx8lWZM5qwQ0z?= =?us-ascii?Q?huHS5ZAnI3G/SbNjkqLh0UFh0Zx9ZZ2qedBaGQXbohgYvHu+gJQxn7Y+Tb5Y?= =?us-ascii?Q?4kOJ7Trxdnzn9ELpjE8hz/OMjdYX/bHRFhAGUOTfBzgguvZcYqdtfl9iflUd?= =?us-ascii?Q?by6a2TIlC/GdfeKZNGHFvrA7AhNr/Mdx9QEdniQNKWU7PEHx1W1D0NYrEzu2?= =?us-ascii?Q?UbSVYpIjA4IUgLKdscIXA/ebdSb/dvKlmbC4NC8qW6Ic3dM4of3C8J7hZoHg?= =?us-ascii?Q?cj+V7Jn9Y46UmqUnyIfVp0aAlcoauiJWITeLT1gcJbDZ6Wk8QAx7Pz5kUaXV?= =?us-ascii?Q?LynAm2RjEfBil7qQUQSvhoQo1sQW50IEaKuqZ2F387T3dU1jabm5xyp6Zm4a?= =?us-ascii?Q?pJiFUWsPyI1q+m9LnH8B54AtPFpLjRHoyzAkR36T2hp3iuHDqNMFw4XNzd13?= =?us-ascii?Q?bRwTmjLv9smL8svsqmFLkyiEPpqlq/qoHh1Q+EXEAGFksY+UwXEvK2hXQGvJ?= =?us-ascii?Q?qfCVyH+c9gOQ/kD6nVIm0wUyxP6qrD10rWiQEwUxB179/8nakPxxQsnLHB8k?= =?us-ascii?Q?zAYKRYMeVvWIkwO3F0zpCsTdOGwlhV2fRoSZlXv2G4k5nMBEQU25d5PSEAEd?= =?us-ascii?Q?Gi4l81nIuO1UudY/KgHcM+Y9o9Dh1fJEkd8UumSXyXZhQeYmSI+aiobkMOej?= =?us-ascii?Q?NRCFZlcXw6iAQRlWweiIVxsp9tVGB4v/PWTiow5xMPt0nCDg6ATViopcVmTZ?= =?us-ascii?Q?zW69NFws3jWXLLFsaDZ3kItHDrskOKqkXMXquZKY5PWo?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 3n93Ms+Bf6683cQFualCLlEhThR7mYSSxJbqZhjmw5cbdNq3FwlWNdOE+KwHq7p1CXuK5MKPloZ4emxN60TWz08BxtnGzzdFJvlwz2Qil3ExnewRhZobG+xwRunRpsP4L68JjLIP+4wnTcGB9hEB/AkQSlDXq3iMpk7HuibFyBzKtph9+ZblvOZT6hQuyYlyFwOwjZs7GOI5mw9DywbhHdoOeCBpz7pBRtgol3CZ+0iSRrf9RKWKBkuVVHqjw+slCt96EC5MRUDXJ8WoaT6Klb3pBIFRxQVZTOnauDmQ6m+NOksQ4nlxlavQvTjWJB61Ny77aLkx7+YU/YPETRot9TFLPKYRw1rxB5MvL8KBwxpCy/Tw7USKeBV3V5jUJc2yuqGM/jbr6sY42gUC6WO3xnG/K5a5DAgKzLObH74bzdPVTplKP438NKvG6/70Z1ApzFyoFqEcATceLcVk/Xl80oO4HIpyjP6JiT98LSF1PjpAx1MmSFK8gehnUi1kKkuLW6y82WRMqHR1usqTF3UXE96U25QcpR2u0jW1a98tpqhyeT0fF8pjD1X4tZCEtfFUUH1ALLF7ZvYfKnNr/TyBJizAvZchUQXVp8xergAevkM5AQiVv8qSKc/lCNBjrEY2ERNjEXF9xJ/VpsIwPeI59WunCC/ZCM9wXCsufBWeykXHUyqyy65kegJw4v35ZgDR8+2ffjCMr3XxPQWovHXGBDtCM1a1OQUjqVFtLD0LXO3OMYXsTGtu5txejm4Y2DVI3FLZ5BVCfiHoezicvfdUkCE6nTaaw2nZjpOSUt8AGOE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6754342c-0673-42ab-6deb-08db2700e3f7 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 16:01:38.2433 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XOEnu60pKIc+SJgLKpCbnIkDTblhLnxibGwks0AV5J03sFK614GHh2ErzyCQLurRiazE6lb8Cj09xk2blnWI/xGwsofSJ4E9I4LXrR39mUE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4358 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-17_10,2023-03-16_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303170107 X-Proofpoint-GUID: eEwm9e_pa2Uon4wexVnJuU6mylrbEZc7 X-Proofpoint-ORIG-GUID: eEwm9e_pa2Uon4wexVnJuU6mylrbEZc7 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Forgot to change the logic to access the reloc howto from bpf_elf_relocate_section. Problem was introduced in previous BPF commit. --- bfd/elf64-bpf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bfd/elf64-bpf.c b/bfd/elf64-bpf.c index ef34d62df01..65418d1d740 100644 --- a/bfd/elf64-bpf.c +++ b/bfd/elf64-bpf.c @@ -190,6 +190,7 @@ bpf_elf_relocate_section (bfd *output_bfd ATTRIBUTE_UNUSED, for (rel = relocs; rel < relend; rel ++) { reloc_howto_type * howto; + unsigned int howto_index; unsigned long r_symndx; Elf_Internal_Sym * sym; asection * sec; @@ -203,7 +204,9 @@ bpf_elf_relocate_section (bfd *output_bfd ATTRIBUTE_UNUSED, r_type = ELF64_R_TYPE (rel->r_info); r_symndx = ELF64_R_SYM (rel->r_info); - howto = bpf_elf_howto_table + ELF64_R_TYPE (rel->r_info); + + howto_index = bpf_index_for_rtype (ELF64_R_TYPE (rel->r_info)); + howto = &bpf_elf_howto_table[howto_index]; h = NULL; sym = NULL; sec = NULL; -- 2.30.2