From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id A3F3B3881D06 for ; Fri, 24 Mar 2023 13:36:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A3F3B3881D06 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32ODOXRA027609 for ; Fri, 24 Mar 2023 13:36:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=TLhZTIGsaEHFog5hPsDcIxclYjlzAZ4OE2u0lMFeDt4=; b=x5lTlQXkKn9fW2R+ZYSB1chfl72Z10pIg4frBq2LKxj/BatI6nmh5CctVmIPQyk1YxIB G4XDl6+8ryagfQ5fLIt7WFdtOHpF8D1pVo+pPCK+Xushrb+lxUrvL1210n9c8Eef+cSM PeYfVKJrwus6UNsM0erJmYeGJrRkUBaek7xtEmRJThwKy9wyvuSY3AGPD1qZiOEZOp5m Bxofm71hGDjlfFQYfkNPiTlIoPAMNW3Av4xOkUhyfI0YBAWYIIDwKxE7mTFmPCSqFaJY xUPTR88amQ3FB1E0FlAmS8HNZOFcZNoLsiF5eqFdEba0HDwzI9UDkprVo/R091ADNI1z Pw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3phcqe01e7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 24 Mar 2023 13:36:46 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 32OCGWfH027822 for ; Fri, 24 Mar 2023 13:36:45 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2169.outbound.protection.outlook.com [104.47.56.169]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3pgxk4a0gp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 24 Mar 2023 13:36:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dkKqlCEaHRlvsB1p4bJxM7nEIGXMVObygonpfsYLVlGB0Cl2hsz8zk/+K8bc73whXKjoJzwh0b4fQ8J973SUMPYckg9YQmg3riVipYLxX+sArn6lp3fNwy36y2ra1vABBXW1ocd5hL6RQAOP8MGWqEcoRzRKO1+psQaQ+5SGwaENIGyELqh8Oua9R6pK0pnfVBlDRQwLXmgJjjex3mbc2/KMaio2TWxNqF++Iils8Tt+rI45afkfgzocPa7K7cKcHSRzZV405/92W8JOR3mKM1SgyoAWMa2DZJghEhnJa48e4Y5zC52CeyuXcb8DDWfml8lh8g62qXOWz2Dvg1jygA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TLhZTIGsaEHFog5hPsDcIxclYjlzAZ4OE2u0lMFeDt4=; b=TJsJx/+83j17F7prn2sDUA7jfcVqB+9BzXrpkg2P2/Fn1KSPdPpDZwAZU5zha1Ef/OjGSr6Uby/v+ojV+2RJbAgtk03HrV5Fs+yZF/NsRYSjUzuuukNmmnfLItAAkmuXaK/PZ27BO4G2QQzri8gOvoJ1el4ZH4n4AUMpgBum0eJi7rV3JTN1TQQYeQ5CI/wFNPidsewP4QyV+JSpFXqTLtuY3TaDC3wc6x2BpdjCSFqHWunyH46uO+zbHg4VzeSzOdNEMFc+7ixIsh5XcTwf8w0VsM15FMalPUfSf5zz4A5EQi66tGWbGrcum+2i7oT/0x88WmGy/eUKV0ewx3GbUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TLhZTIGsaEHFog5hPsDcIxclYjlzAZ4OE2u0lMFeDt4=; b=kFYqiy8go4E8JNLRWLZQi+QHBEUBPaNlKUeT0T19tyevPd3+fV1QLsRMydimArsownRjFJz8vL6Wg+yxZfNi+6qrYYjy0ZyavHCvQKX8uU834a0je0rGtM32ydO/x/xCrgoallujQ1U9fdysulIceL+y8X4Js9uAp4ojXl1jMY0= Received: from DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) by SN7PR10MB6593.namprd10.prod.outlook.com (2603:10b6:806:2a9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 13:36:42 +0000 Received: from DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::d0f7:e4fd:bd4:b760]) by DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::d0f7:e4fd:bd4:b760%3]) with mapi id 15.20.6178.038; Fri, 24 Mar 2023 13:36:42 +0000 From: Nick Alcock To: binutils@sourceware.org Subject: [PATCH 3/4] libctf: fix a comment typo Date: Fri, 24 Mar 2023 13:36:24 +0000 Message-Id: <20230324133625.450723-3-nick.alcock@oracle.com> X-Mailer: git-send-email 2.39.1.268.g9de2f9a303 In-Reply-To: <20230324133625.450723-1-nick.alcock@oracle.com> References: <20230324133625.450723-1-nick.alcock@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0172.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::15) To DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6798:EE_|SN7PR10MB6593:EE_ X-MS-Office365-Filtering-Correlation-Id: 53b7407b-fbf1-4999-10f9-08db2c6ccda9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O3xgnJe24ZyNFjNEb5W93YX9a4GZS7oBuU6XGcqDkhd9P8I8jLMqNjYTFCfEW1Ykw0aNQlqG6JQjuZgrOElS329WUMUXn/sRjiJfew9DNOKIk2gV9h+/axXadR2BIGRxWUQ7nSVxqUgYeeoXS0qFEMQOyCCPAQ6xYLo731yFnbANxtqJXA8CFLCgZAKYa5Xpmws2B7/a57f1iwV165Z3RxjMCqqZRwgfloLQCjeg8pDQXAiDD1m/0abrJnSWcCOig6MHqvRQVCpcssI9514OqFr6KrQZzJfe8TaJDUEmX5tr+PoUcfx8ZNFhS16Y3l9VnVOAcH0k8oopmo7sRgBkHh81IZCMTaFUlxTOqVCfczS92pHA+UCGBFZvkD2ts8z//V0+uv7bR3bUtjQ9Y2Z/pW8bigi0x2YtV0oywcKmTvfo4A1DCxRKW0cbxkzdDxm5gi9DH663n/rXSgJ4nfETOBa9DlW9QfHp8iK2IohrEmYkzFkQe2jqVeMp3L9PABxRUECcp3cQ+fy6NqqspAabVXHQtmX+/gwurb+1kW9Mmh3/lgJBQciS9sQ6CseL/OnqSl63Bsje1/DLHMFB6/+akTNhZ/aOGzFl9AXO2A8rKo1XXLkZTwarC5asdUf9oC3CftAaKQSlP86FUax0SE6v7Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6798.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(136003)(396003)(376002)(346002)(451199018)(6512007)(6506007)(41300700001)(36756003)(1076003)(2616005)(44832011)(2906002)(5660300002)(38100700002)(8936002)(316002)(478600001)(186003)(83380400001)(66946007)(6486002)(8676002)(6916009)(86362001)(66476007)(66556008)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/c01NSl60sfjGnBExvgjJMghYzyYEsdGoaJgXjOoSGRK8DZz9X8/IATorIiu?= =?us-ascii?Q?PEjcQppBHdzCbUsGRC3TkVyOhEi4S8hBnrsYfZJk7HqUYw7KqaRaB/TdO24A?= =?us-ascii?Q?PpxL/Y5R6falXJvyLglpsTSLWu5p7a+il9Sw6ySIfPJCCroBIroFAVGcyphn?= =?us-ascii?Q?wdWXUxnKcf4TLIgRu2T7vkXTWtAbAXbdT/Vs7GftbSM3e52wm7nrnOmEUXXy?= =?us-ascii?Q?I54WGMzRJCYGLd1JxMwYrXtjXXHq2J8QS41x8l9zAf99O3id85GlkZk1c9Kp?= =?us-ascii?Q?Yy+RRzpXULy16PdyahlsUt6o4r+kGEMJukUkaeu9C3TnrgCXvkHm3viY7TSM?= =?us-ascii?Q?gNHiIuOStWr7AHSf8UbYVU8+mmGbzSKzf11XZOELZFKDYFKmNxBx7YNdJ3Oo?= =?us-ascii?Q?7zBZGiVoXCF/h5QnZ6CgkAiPznQy/jJLPjjUQjn0qkmv6y8b7Evny2jpZuSE?= =?us-ascii?Q?Oo6ER3anmFk0E1WU/PYsgdAqHVTFANARaKDG7B+fw7GRj7q+F/7gj/LlxuCr?= =?us-ascii?Q?d4KoG5/ZOyjSCKQSD/GS/MoWGC++w+LhMlsYm0SZXufzwOtPahV9M4/w803V?= =?us-ascii?Q?QQ0uG/Pv2ygdHVjJ2HgouuH8TYYoUa0ah5XSJwa4RRYeljsJBIIcjzZuuuzH?= =?us-ascii?Q?oslr2TM5ji84g6mGCSVOx550hEnxSfUj2tlgkim8xN6e07SkHcjzXphEoQlg?= =?us-ascii?Q?cKiaY0ujwI5uWkYWJkB3phJJQ79B/y3QDuO7Sjg1ni5HsUtYKQsMlfwz4D9c?= =?us-ascii?Q?JUrDTEjfCNnu/ZR98OBT7NSoC86NAusW19m32Bi8VW37+KXasF1LaMtVHkEs?= =?us-ascii?Q?1t1LomovA92HLmczgHHX9rIGogkVLiY/5n9h3Z+78OHo7P11r93sdqsFyo/4?= =?us-ascii?Q?umBLGHXODgp1Wgue4OxT+MK1t2F8LeEgcDLs0UrKMH384R/wkwAaV7RCloxS?= =?us-ascii?Q?6gi/FWSaa5LppKyMe4bEmhRG4ZAtVEoFYuRsxIYZ7Xwv37Fv2jL+g14Wcb8m?= =?us-ascii?Q?ScIOVN1zx+rlESOCVZ0SpMONeuqYPfbps6xo7Yr8un0NpvNZkuFlDACIuEAu?= =?us-ascii?Q?r4LkIjK0AtrqrS/QmmgJ4XmkQx+flay4IUeGZUhuv7nngexkhTl+iBoqO4OQ?= =?us-ascii?Q?B6H+gPED3yrCsWHjej9JzWPgrKse2BItO2sK5I7Nz1TvCtCn20M+vxdaXg01?= =?us-ascii?Q?fbRvSH9JDGTG6pPufK3lNJhNrhKANMkYfRkEkUlu4ngr2PHB10kLg5GVcMpd?= =?us-ascii?Q?pJ+OtGhtHlP282MKeNLpEl+b7Hn3INJdplKoJ6Ox+74Xopinu0e318aesIlq?= =?us-ascii?Q?ML5o+ouZWb9yaZSfTpKvNBLzOPfOOvZl6uk/G23M9eC/WOgWJDBXA9GFdysk?= =?us-ascii?Q?s76V2742Glk6kMGqrkRmjR9tvyorWJf0HRtCAlt0luW96HnC7XSZT9X3jP8H?= =?us-ascii?Q?nAhc+XgaGXQctv47uxiRIHYVH7sbWXEKtP0VNC0YxoJukZOk1CJIrsYe6n8N?= =?us-ascii?Q?qodMYYuVgQQr7QvVL3JhdpiQ+vdQzL/JZCzx0hE5XnTPsQyIuor8Es73C2EY?= =?us-ascii?Q?ybPPBNX6RdiRrGwhX9Bse8kwTNpzOwklWVbXboC4qM2XYWOkrSd6d4WfwshL?= =?us-ascii?Q?Lg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6TSlGMBNnihghfdWGpW6O54s55hrVeDDoZlzmecfhNsImvBk6D4+AwY8GrQsz4rOsaeBsaeRUcYXsIplqdJYjrViKyNx5Vr36UWcwwFRIED0g+sjdvJpNREhIIEq2Z0kh8ULrZAO62++53OM+REaqmA4zaOeQL07uzUlBc80Lj3gpOz23ELe/h5+BVUyLW/u9fIn6APDyN2N0V8XwBKbZaBc7OpZ5DQlESyhSnLNN7pxP1wsUzz/P3/GQtrdOmUEUmrIe4krakqUuiY6Yuu8KIoeUpVsCA8kisaxsoMvzAV494XOE0UQs9YLFvvLlLUdNTn2vpLkE+51j5al41CBF5tN5++E/w8NI9VhLeBxw50Fr2f6l9JGyRFFF4GHstyVnbDVkzsAUpiDHpIa5V8jDUwJIAWQeVbNeVLUuB2/zE0eMgGGeckTy+tKLH1kimmFIPcJ3ZTU4KJ2Vqt17yfRxWk+Y4LxoJ2QNBO3MfgkGRf9/a3Tb6i57dQxjwH0UotFzXihXKikwK4vOP77PH6sst7Rac2W2JdKOCNEyuGpIi4drjqdpQTf4PPwnRDlrWVCUeh6mFtBav18uho2w8HPfyh1uOaIahsaL5dwmY8XxB/Q9NHmX5MkxBc3TMiKuDxbfxVyCY0XLW4OBORrFeCYe99gzjEA/HxNe0BqjPodA0dCaVpdx7BoDE0TEGAazsf1+TWdFT87Cdm1HTOBtSRI3SvgI87fP6jjc9P6gWpdKbRyTLLW8whx8KZ5rUB+FFSi X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53b7407b-fbf1-4999-10f9-08db2c6ccda9 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 13:36:42.2806 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pij7XuGLnngpSrR1+Ewlp5R8SVqAb24JK+Tv71cAlscQfUfhvLCjw6/ArO4auMtrd6iNc2aS6TQ2I7lVlOH36A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6593 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_08,2023-03-24_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303240109 X-Proofpoint-GUID: 0SFqilDJinFuiMEI7hwe_NiOraIqpa5t X-Proofpoint-ORIG-GUID: 0SFqilDJinFuiMEI7hwe_NiOraIqpa5t X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: ctf_dedup's intern() function does not return a dynamically allocated string, so I just spent ten minutes auditing for obvious memory leaks that couldn't actually happen. Update the comment to note what it actually returns (a pointer into an atoms table: i.e. possibly not a new string, and not so easily leakable). libctf/ * ctf-dedup.c (intern): Update comment. --- libctf/ctf-dedup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libctf/ctf-dedup.c b/libctf/ctf-dedup.c index 6297c45c84d..5fdddfd0b54 100644 --- a/libctf/ctf-dedup.c +++ b/libctf/ctf-dedup.c @@ -412,7 +412,7 @@ intern (ctf_dict_t *fp, char *atom) /* Add an indication of the namespace to a type name in a way that is not valid for C identifiers. Used to maintain hashes of type names to other things while allowing for the four C namespaces (normal, struct, union, enum). - Return a new dynamically-allocated string. */ + Return a pointer into the cd_decorated_names atoms table. */ static const char * ctf_decorate_type_name (ctf_dict_t *fp, const char *name, int kind) { -- 2.39.1.268.g9de2f9a303