From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 0DD573858D33 for ; Wed, 19 Apr 2023 22:11:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0DD573858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33JL47Bo021790 for ; Wed, 19 Apr 2023 22:11:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-03-30; bh=TMLPjDbhkExa/RoAjx2aZyKOnahTnQRHb/99QgIIVkw=; b=Nm3V6J0P9uRMqPUvh7amfoIFgjxoA7zR8sfK684N/HnpNnsBNyRR23KF+wrH1J2rMjlL NfCezIyQl6E8rzdGuqVRc3eoYyQwmfKxpAf/QdXC4CnQ9xvAZY5t0mDHnbL4XV0Eka0x Ux9Wts9er/rw0+8h9PSoeFDY50tuOIw+WMt2INP/pEusSAEKHzPCm3mcIvhLkaeOWy4V O7qEb2k0KtWbUVyTYI7ZGQ6jclijVpjHT/dWCmz+uhkXewc/W0Zlllumahjmps2Hfx0n HFooBmjD3/wEGENA/M3SKpl33VImRUcZxD5elHXUTiVR9VzOxKgddWtotzxLetAzbFl6 OA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3pykhu1f40-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 19 Apr 2023 22:11:48 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 33JKsR9X011335 for ; Wed, 19 Apr 2023 22:11:47 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3pyjc77w3u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 19 Apr 2023 22:11:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fjbaiJTg8gH2aI/7Mo2Y5gGBT0x0AJgHzpyeAzirHykHH6MbGDXfgyhfIcmrPHMtKxUv20R5At59VyfCKIiBXa0ldoopE43It+JzrToAPXospel1KToIL0lP9km0SfTOIFIzMIqPvje3jrn6nntHMX4QIr2tIXh/XucPokc2sQJo3gO9IE2fiDteE1FOi64TxjtDbCS0HTo4aFRMtgagaGZ+gPIf8lrGCN2QIadlywrcBuvSi79UsRGnQQdZOZnumB8LS5ZYwaR5S6hP06dsmv7VdgACSj8DcvpS+bkKTeajp6S3gr9sAi9C62c7lFvKZzdImqTQlKb+6XIf023NBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TMLPjDbhkExa/RoAjx2aZyKOnahTnQRHb/99QgIIVkw=; b=geb2wqKUCRzWY+C5YIVksV9kcJf5thBtaS51aHZWCtz+H3oQ3ElWNT6yDYJx0ai1D2HXMjQNy/JqX1JSopGcXJ43phR9Xgp7LgttgwWfryzjAarlAcAV60vUCPwu0fr3t0Gjl101AmG4EKAPj5TMQeqNAOwgG7HMDwFBwgH6OiizI1sgxuvUrkP8Kuc6OPeLK8eTxHsK4h3I+ZDppfPP7U1H4PpGI+8ZwbqQHy6N9+wJyG3Ev4YejP89RuPXsx1R+bYliCvoU+vXnFTTlMb5AYVlKYSLX+yORzADp5LVGpa6tPVUgTJonjV7I1R/KNLHB7JaMh0w7A9S4pV0qzKAtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TMLPjDbhkExa/RoAjx2aZyKOnahTnQRHb/99QgIIVkw=; b=JxoUTtKATXR6T+dFMOrh1R3wN4kWWt6tT2g6l5c+iMY7qXsoQtzm0wWWmW5IGitCZTUlqoTVgokAwK67MSX2wRJtxdBAabIevEpfR+HRIB1H7SNZKCmwgKhPwfT50NacGBWOaJ41i6qaVbVMRLV/m3gL/TOvOWZQ/1Dh8BkJjeQ= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ0PR10MB4639.namprd10.prod.outlook.com (2603:10b6:a03:2db::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.20; Wed, 19 Apr 2023 22:11:45 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ff1c:f1fb:8db9:22e2]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ff1c:f1fb:8db9:22e2%7]) with mapi id 15.20.6298.045; Wed, 19 Apr 2023 22:11:45 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [COMMITTED 3/6] libsframe: use return type of bool for predicate functions Date: Wed, 19 Apr 2023 15:11:22 -0700 Message-Id: <20230419221125.502883-4-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230419221125.502883-1-indu.bhagat@oracle.com> References: <20230419221125.502883-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW4PR04CA0376.namprd04.prod.outlook.com (2603:10b6:303:81::21) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ0PR10MB4639:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c571dd5-a1f1-42c0-6ddd-08db41231030 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X6ylFLbuSJ91YIp1+7eKn89GUm1d9lf174eIIdT9oFY6EPGgFT0wPnBjEGB0xzsT6FnPJPn0b0aamX1jK4e//soWKCE4n1EtALYediMofff18Gw6/AVvf5UaVx5BSL8bWh3AqETfCToGaWLxTrCTdGQ4QVfejEOtYoqer63QooOjzYr3NYkoRXgfpn2+tW66Vq8lAuMlVGWSrvt5FWnYZFN//tKOGgU1TpMTS4PHB3SCLYXumJHU1MWSGX2Fz6YhCrkjm6ZF8/AhjnRVya70UZD+a2g1/Vf+NzYmJS/Jr0QuClLqmKwvRT1s51wzfr78/NfmhagHp1QKO2Rbj65gNEyU2YqD6ueEeda2Sd0Rqmesis2hYAubCibColEJW4OkQwRr8JsdGnaNZyD1RDL0x03rkqvLavZRXTXUj6ZpBTCYdauFNkZBmndQ7ysPvF7gqh6OiV4yB83KITVDpo5ltxdpEzaSsk3IxjSL8c585/dpvgF2c9YjgjROQbUb8lfNxCWEZuk1g0VAnvJB+F2zk/KvOJiEYlUdzP2586oOsmeAaDwNzsSDnMbabaZ0CUza X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(396003)(39860400002)(136003)(376002)(346002)(451199021)(316002)(41300700001)(4326008)(66946007)(66476007)(66556008)(6916009)(478600001)(44832011)(8936002)(8676002)(5660300002)(38100700002)(6486002)(186003)(83380400001)(2616005)(6666004)(1076003)(107886003)(6512007)(6506007)(86362001)(36756003)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BiW9TbvKlsoqRKKZCtg07HDMBsQ4Wb+qk0JDyZuUG9xiJxWKZQW0yAVAiPag?= =?us-ascii?Q?kK7KERei5/io5hDwGo33ii9SGSaKPqebqLpwjaNdDzU9AWphofIa9iBLX3OB?= =?us-ascii?Q?ROw2lyXDFwNZVHDf6IR1lDE19spkLKu1tUOIKOynp7mBuKBv+kFeVdm9l2d/?= =?us-ascii?Q?2V/TquRvoFMgOtsVi1sPpwJhN/lSzjXlmZJplEEoGkJQ2rAsA7Dru7i119BD?= =?us-ascii?Q?uDO3XNLs3525KIaTRITHf4iiMipHiHbVyO7sgngJgl30FY9be1jGAG2o5I0N?= =?us-ascii?Q?+a6lCFiE24iVp/HIqs2OI4w7X0YTANRBB/pT/xhhan4OU8wtuJE73TNTj2sK?= =?us-ascii?Q?NPFbOmS6fgfcn4xZVNJsTsUkgmj1zYEKoOj0ybAc4toIiPgXvl2ENzLWc5Ri?= =?us-ascii?Q?Zq7mHG0VIHxkO5WRZXp8PPiFgU5gAa44Bar6DPRd8sIblhgT8rXtHefgT7J9?= =?us-ascii?Q?9NJrEg958zQljbL4DtEUAE3HQ088pT/uhAwppW/jAXlrTtfE51Dri2l4sN3c?= =?us-ascii?Q?SGRRAvifzK+A+B/rHmNTnYaB6lGkZZGwpgp65wXHWK1w4LFWshqrtpFdxs2B?= =?us-ascii?Q?FiVU0/54ICo8lszfHUKbleoY6LyJ88KArZuDueY0OKBaYQtj377TjQa82STR?= =?us-ascii?Q?eId/JaHCaCdOi6XOyyUgHoqRb4aMqZQ37iqhodEFiUU4DiRGCyMYW+iWyexn?= =?us-ascii?Q?uSjYOusam9SoKcPW1iroUhLJgTLagFJPmvO7GDmLZvP3puh2xvQhRQAusl0A?= =?us-ascii?Q?XKfcHJSFE8K7lLmRI9BOtbIxUK1s/LC7aVzY6tayoJGkgC7QKXigmifXRL3I?= =?us-ascii?Q?y7dhSflJKzwZl9V6vpXi66woJH/i/Xwo6YiVDiZuOSlcRNU3u05TzP/+lQbo?= =?us-ascii?Q?qG9mVUvpe/uKfjmnysiBfTHhKC0ts8ooyQ5G/qWxyCS8ZNEA02swq04Uw0Vs?= =?us-ascii?Q?IArw60pFYdYzOVIcxML8CckNI9JqclMvV3hzQyN0yl+qzuZzLUB/dYdUHSp0?= =?us-ascii?Q?KL7k0HQ8+0JcGR7tETahyXEU8137nAKhL9VjX9NROs9zRKY5rBlirdhARE8e?= =?us-ascii?Q?sdvEB3SlL6h5L7fUJE79579HmMoC7zjyZHjWhwkfBDXbmsBj6h009zX1vvd7?= =?us-ascii?Q?a+4C2qE4k518sKy4r9LQ1KzJWpYCQ6Q4KgrkbA9tpEimM+AGQjSQSWSes/qI?= =?us-ascii?Q?xrM/7Obm6rnNTg7mnzng0FoHTgWCU0bBAZsiVR9EyZ9OlcboiRoet61vKk59?= =?us-ascii?Q?JGT15nIboM0Wx2rTk3LV1BYLBNtTfsbby04Xbyrb3wkUCK71AD5/RtpoqFiG?= =?us-ascii?Q?J9GHiBy+MQfbyTOH+KcQOAFEv4jLpD1ph8F0alYtYTX0RH+f0AYz5wbmHdVj?= =?us-ascii?Q?7hdmQtWNHgkhPGJWKsnE9YHBmVV0WVMYndznO2jSty1pAJe3WM9m877gxYjP?= =?us-ascii?Q?VbKcucgPxGxFpuVRG3ODSyUkuIuZA+3aOO+GI+4wQ/9hhkbPtxFkMRoZAHmM?= =?us-ascii?Q?9xVJh2BUkYmeweWl6sFkbFSgXZwzD07vnQfkW5EHqEoh2qqXd15p+HbMx7Sa?= =?us-ascii?Q?mLz3cXWLj3w2JNjT7H1RaWUnCupDIjZ9tbSK5iMu+CIka/d9Sn+tAK/nYNAi?= =?us-ascii?Q?cuNcNwu9L3efDVgBKvJ9CHw=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +DWA2BPaTA/pvNaio6YVkzYihDdBa6PcP/X+M4N7u537e8u0htGc7I5xRzt/Exij9VII9dzlOh+YXgSVizjmBe0KMpEicxcoZyOSM/qZAvV74U2RiOVNWf/cnL+Pr45mGrODRtUmLQ6C7hAO6WFHbNz1BBa0bNyRVOOTclVFIh6lbHoY1iqw2vVqvBdwrYMs3A3mAkKIJjv9uUDVd658G+hKwmGu9HP2UWhy6D6wV0MkVQwJSL7KPgkJUmi8CC4NbRIpIX0OnDOTWJU09s72gX9YfNC0lTEjWCPcYxE0gz6+/U4GPP8ReY41Ma72jNFs29R/g/jFPAlagz22TyWYk78DQL5yucwsE4S6UUC98YlwzweTS/8086Hr5Er/XgaVCRBAT/V4347o1h8URSB3hYAKnZHyci92cACuq/4G+s5MWi+6QYv+1q5lA6hs6h6S9wkZP/FP3mBF/nUroC4g3Er+RUOwaZ+litPEIshXUOGVNbKAOCtIE4FiH/UToPPvOXsjI6cfcJmenQgF4UeDm1XVfwPgY5v3XgTA9IHP14sTe2kINK/SXYw9s1dsfSvM7sfLOitYLzBjxx5Dcd9mEK75Ydk2mXjG72sibXkmEMakRVajs9WDY4aAoXYhVIWcNXWjgfnqGjaAxKGob/0IsZTnz25+Yp7m4RXlGmiACseR2uxhfjaowiFv9nYfczH8cHXdlt9ThoDIMU9ybUmC8X0Yz+7IEQ6x0zgbVBeAHH5gWL4ApSUQelwvYQpQVl+cMBv3eQoUsyUe/3RMHxWjVQ== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c571dd5-a1f1-42c0-6ddd-08db41231030 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2023 22:11:45.6121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lnh2dsJJxAbzv47WbtVoeACIHLycOyL3bhgEKfYACeEQJiLekF8j2CBSPAjL+nLeB2MM+ObfaQ0l1uLXYSFyyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4639 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-19_14,2023-04-18_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=907 spamscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304190191 X-Proofpoint-GUID: o4D8k-8s-Vi-v2dr3-R-r_dzA1ruyvkn X-Proofpoint-ORIG-GUID: o4D8k-8s-Vi-v2dr3-R-r_dzA1ruyvkn X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: libsframe/ * sframe.c (sframe_header_sanity_check_p): Change return type to bool. (sframe_fre_sanity_check_p): Likewise. --- libsframe/sframe.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libsframe/sframe.c b/libsframe/sframe.c index ea3169ba7aa..907214a8a89 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -201,7 +201,7 @@ flip_fde (sframe_func_desc_entry *fdep) /* Check if SFrame header has valid data. */ -static int +static bool sframe_header_sanity_check_p (sframe_header *hp) { unsigned char all_flags = SFRAME_F_FDE_SORTED | SFRAME_F_FRAME_POINTER; @@ -209,13 +209,13 @@ sframe_header_sanity_check_p (sframe_header *hp) if ((hp->sfh_preamble.sfp_magic != SFRAME_MAGIC) || (hp->sfh_preamble.sfp_version != SFRAME_VERSION) || ((hp->sfh_preamble.sfp_flags | all_flags) != all_flags)) - return 0; + return false; /* Check offsets are valid. */ if (hp->sfh_fdeoff > hp->sfh_freoff) - return 0; + return false; - return 1; + return true; } /* Flip the start address pointed to by FP. */ @@ -284,14 +284,14 @@ sframe_fre_start_addr_size (unsigned int fre_type) /* Check if the FREP has valid data. */ -static int +static bool sframe_fre_sanity_check_p (sframe_frame_row_entry *frep) { unsigned int offset_size, offset_cnt; unsigned int fre_info; if (frep == NULL) - return 0; + return false; fre_info = frep->fre_info; offset_size = sframe_fre_get_offset_size (fre_info); @@ -299,13 +299,13 @@ sframe_fre_sanity_check_p (sframe_frame_row_entry *frep) if (offset_size != SFRAME_FRE_OFFSET_1B && offset_size != SFRAME_FRE_OFFSET_2B && offset_size != SFRAME_FRE_OFFSET_4B) - return 0; + return false; offset_cnt = sframe_fre_get_offset_count (fre_info); if (offset_cnt > 3) - return 0; + return false; - return 1; + return true; } /* Get FRE_INFO's offset size in bytes. */ -- 2.39.2