From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id EF26B3858C83 for ; Fri, 21 Apr 2023 13:08:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF26B3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x135.google.com with SMTP id e9e14a558f8ab-32a7770f7d1so21223735ab.1 for ; Fri, 21 Apr 2023 06:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1682082493; x=1684674493; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=P3zLKe9+HnUGFHbXDBoSL4OJnpPgGVY2SjakSiX4lEI=; b=DPIVuVBPTI+TlFptG2grzyr3j0/KdfET819LpQ2BrQ+K9Pe1ZDvDcntvo1/6QSrITc 6ZRjF86UKSC5DP85HMue/3kWMCDnL++J8fVX+4W5mRNBxv7Y7JKH9/bcL7t8oPu3xzIU /WOkzTKBuOpFK7CfVzsrnOLr4gtkC/COWarhJ+C+oZPOtP+65dGJTuqhgFsJ7Tl1GxpX VkMVY22F4a36/W1SftNaYgJwi9YIPjhMwBbNIe19R5RM0yyKf0D5PHh5ogmIFPLt4a3y CTPdCdhQh2T88hJWgu1z+PCinzk7RQdwuUYVLqpO+pfFUxn+AQdPR3h3Qv3bER3/Yha0 3MLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682082493; x=1684674493; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P3zLKe9+HnUGFHbXDBoSL4OJnpPgGVY2SjakSiX4lEI=; b=j/9u5jtWmrQVTHsrGUzx3XjQCiplRvWCtHxDEHQ2PRJdy9zRhwK8QfshIFNiWM5vrV e52Nb426kwQFo9ePQ/PNfy8OvjWc0P52Jq53trbopB2lRK6Nk8HBMGAleXzJSeKkJxBO M/gvd6CEseOfxi0LbWjxMzT2NOt+WjX8peVYLqGn8UIqVGAZyEBM9T1qi5m81OGeqKJQ JF6aqpmzIaQUe92F2OIlry21lzbOzu7RTGSIwmwWwzpIOqbKtQv/1uNqlVKtfEwkEhrj CUZ9peLwbBNyTsACqVhuoCXjAhcwTxrRIkTQNGQ7Zxx//3l+AFgMmSMaLpXr9qkPuCc8 ym9A== X-Gm-Message-State: AAQBX9d8NPY5tancibwe/gWAnVnd1y1f9HcnPvW805WAdtn6dmAV+zRL zyBKd8EXq1KoJAaT99bvKXJ/0tMvPpRmtGi1yx+h+Q== X-Google-Smtp-Source: AKy350YuW50dpTk+9Tu+0OtJl5MdaDOnThvGYA7uk1trDpdzFNaBLTFvIBnogMFb6k/QeRBbepKjMw== X-Received: by 2002:a05:6e02:1489:b0:32b:10d:cab9 with SMTP id n9-20020a056e02148900b0032b010dcab9mr6262789ilk.11.1682082493188; Fri, 21 Apr 2023 06:08:13 -0700 (PDT) Received: from localhost.localdomain (71-211-191-82.hlrn.qwest.net. [71.211.191.82]) by smtp.gmail.com with ESMTPSA id bp22-20020a056638441600b0040f703eabb7sm1182597jab.70.2023.04.21.06.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 06:08:12 -0700 (PDT) From: Tom Tromey To: binutils@sourceware.org Cc: Jan Beulich , Tom Tromey Subject: [PATCH] Fix -Wmaybe-uninitialized warning in opcodes/i386-dis.c Date: Fri, 21 Apr 2023 07:08:02 -0600 Message-Id: <20230421130802.2964785-1-tromey@adacore.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: A recent change in opcodes/i386-dis.c caused a build failure on my x86-64 Fedora 36 system: ../../binutils-gdb/opcodes/i386-dis.c: In function ‘OP_J’: ../../binutils-gdb/opcodes/i386-dis.c:12705:22: error: ‘val’ may be used uninitialized [-Werror=maybe-uninitialized] 12705 | disp = val & 0x8000 ? val - 0x10000 : val; | ~~~~^~~~~~~~ This patch fixes the warning, but I don't know whether it's really correct -- I just copied a pattern from eariler in this function. opcodes/ChangeLog 2023-04-21 Tom Tromey * i386-dis.c (OP_J): Check result of get16. --- opcodes/ChangeLog | 4 ++++ opcodes/i386-dis.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c index 46ba01fe093..f021bdaa3e7 100644 --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -12701,7 +12701,8 @@ OP_J (instr_info *ins, int bytemode, int sizeflag) { int val; - get16 (ins, &val); + if (!get16 (ins, &val)) + return false; disp = val & 0x8000 ? val - 0x10000 : val; /* In 16bit mode, address is wrapped around at 64k within the same segment. Otherwise, a data16 prefix on a jump -- 2.39.1