From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id BDD543858C31 for ; Thu, 27 Apr 2023 13:21:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BDD543858C31 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33RD6xBN013042 for ; Thu, 27 Apr 2023 13:21:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=HU4szL03gKdIXidTVjBZpvC2wsAc2goxzmCauvkSDc8=; b=nbBkhFwB/nX7i1q5ONIJQSPuALpjlEPD6w8y+0kyU+Mr6xNAlWF2QlN4bNiRtYdebFWy p8LZXvvwmZRDwPEkiGNODLvOe6UhdXCV5cECEK8tYOXLlNDMb/5pLGCDj8tVEg2Db6vu 3wPE1/qQIPDN/2hoicn39ij2hC4Bxp0FBoJL+xf5Yc1wyN42vs69c5M2MwhLt0fRFNWN /O5Jf5Pdke8t2rn75WS9qBOs1YnnfotbA6C49DboFBI/97HDjXdtVtlmTh6xsXLLEe8C E6nl5ShpYTmRY3cQfjRqi0Np5v0otybu/YSC3WdubcUu2Vcq5lsXJZCS5y20q59Ne9f+ gg== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q7s701bqd-6 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Apr 2023 13:21:31 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33QLrc0r007999 for ; Thu, 27 Apr 2023 12:56:14 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3q47772y9q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Apr 2023 12:56:14 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33RCuAC242992016 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Apr 2023 12:56:10 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B721B20049; Thu, 27 Apr 2023 12:56:10 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 795B120040; Thu, 27 Apr 2023 12:56:10 +0000 (GMT) Received: from heavy.boeblingen.de.ibm.com (unknown [9.171.75.51]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 27 Apr 2023 12:56:10 +0000 (GMT) From: Ilya Leoshkevich To: binutils@sourceware.org Cc: Ilya Leoshkevich Subject: [PATCH] gas: fix building tc-bpf.c on s390x Date: Thu, 27 Apr 2023 14:56:07 +0200 Message-Id: <20230427125607.362035-1-iii@linux.ibm.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Uc6QplDi1wutLnQQ_ddT3L3dyHEZLJcF X-Proofpoint-ORIG-GUID: Uc6QplDi1wutLnQQ_ddT3L3dyHEZLJcF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-27_07,2023-04-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=747 impostorscore=0 phishscore=0 suspectscore=0 clxscore=1011 malwarescore=0 lowpriorityscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304270116 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: char is unsigned on s390x, so there are a lot of warnings like: gas/config/tc-bpf.c: In function 'get_token': gas/config/tc-bpf.c:900:14: error: comparison is always false due to limited range of data type [-Werror=type-limits] 900 | if (ch == EOF || len > MAX_TOKEN_SZ) | ^~ Make ch explicitly signed. There is also: gas/config/tc-bpf.c:735:30: error: 'bpf_endianness' may be used uninitialized in this function [-Werror=maybe-uninitialized] 735 | dst, be ? size[endianness - BPF_BE16] : size[endianness - BPF_LE16]); | ~~~~~~~~~~~^~~~~~~~~~ -Wmaybe-uninitialized doesn't seem to understand the FSM; just initialize bpf_endianness to silence it. --- gas/config/tc-bpf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gas/config/tc-bpf.c b/gas/config/tc-bpf.c index 171fc682806..adcf5edc645 100644 --- a/gas/config/tc-bpf.c +++ b/gas/config/tc-bpf.c @@ -885,7 +885,7 @@ get_token (const char **insn, char *token, size_t *tlen) } while (0) const char *str = *insn; - char ch, ch2 = 0; + signed char ch, ch2 = 0; enum bpf_token_type ttype = BPF_UNKNOWN; size_t len = 0; const char *expr = NULL; @@ -1362,7 +1362,7 @@ bpf_pseudoc_to_normal_syntax (const char *str, char **errmsg) } while (0) enum bpf_token_type ttype; - enum bpf_token_type bpf_endianness, + enum bpf_token_type bpf_endianness = BPF_UNKNOWN, bpf_atomic_insn; enum bpf_token_type bpf_jmp_op = BPF_JEQ; /* Arbitrary. */ enum bpf_token_type bpf_cast = BPF_CAST_U8; /* Arbitrary. */ -- 2.40.0