From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 433593857BB3 for ; Tue, 27 Jun 2023 19:52:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 433593857BB3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35REoYUu009914 for ; Tue, 27 Jun 2023 19:52:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-03-30; bh=WbwLOfle6WYLf8Q5iSne4AfG2K1Zi8LUPf62JfCEnu0=; b=G8rxgnQBC8BqLYIo7e55AZQabcxvNVpIrEccxo14QvY7wprhjI8eo/prhlJcSLQGoqAo v4QaAUP0gDVcwEWHJfYUISWpDjICvUgVS5K+8GlXQ/A9Kr/4jgjtXa643KKimShdQGYd sAabdbH2VW8vX+OFF4AyVsI/ubdx6X8IChkYc3Avl1+Q1TbVQfWtVmyoOtF6nNY2K2F1 PBsnZJZyGY3nVrqdxPq8WNsLnI3jEnq322KYfPhnlZyzJ3ZZyUSInddVXyLQN6Z+J3kW 0znYTji6riHCfJa+wunjvChSZmyv7IWIetDx2j24hue5rwwjoxNonXrUjyzjthPVnQLb aw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3rdpwddw2f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 27 Jun 2023 19:52:27 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35RJjC7D038332 for ; Tue, 27 Jun 2023 19:52:26 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2172.outbound.protection.outlook.com [104.47.59.172]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3rdpxbgj60-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 27 Jun 2023 19:52:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SfcM1aoyrotO2Nr61EkMAuZbYtA5hBBrRGwRXPWdL22evh2C44mJ25PYD5voH2otnu3FRLl4rR0QXBS1bUddkGo2k47mRPhBtOQ3JbIcLSyvhpwCHwZmUzvIdGsQiKF/VjUUFLs4WNSyDlEfjdLo/taBQG1wGYP1OYCDkSGqj49he8hQvxeN1PKok9l/hHO7pvv95skwnwa76GuZq/Qe9+tbVrbawv5phADIfIGhegkuhCwTGMNHwcVsZ7M0mxuOun86qccwkP08sepA10klMCWJU3TgMDgrv7yB9mMCQdlF7c216k2vuEgXiWq3+g/i+f08oK9p6x3V0fJBYrQRFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WbwLOfle6WYLf8Q5iSne4AfG2K1Zi8LUPf62JfCEnu0=; b=JaW8Eig7Mi92HNpkwZS3Btgb6f2SjD8c6PWF6dWdwTZYlYRG2UsOst2v6I+DlhOvrlOQpv89ecBz/jTMITGqryTqFyTIi5AsHcLXHjkBJxdT6qN/xMHDEoFdi6Z6PmnVO7iU8OqNxbLNI39zcBF8HuCg/la6V6U4d2Rj7MaKff/AipIrSAd0ofELXYsIrWrt+WiCW3bISPUOMak/43mdkJj3r38ETMNvPKnzfMqbo1HAdGkpTeAm+M+pP+xYsoYwW3ha71tZbtwHwjW3t1ABN0gCf4d69+OVNYFH0FL2R3Nw1IvbTZPCgl/658gsoscaeGAjKfpf8aEzWpj+ovc9vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WbwLOfle6WYLf8Q5iSne4AfG2K1Zi8LUPf62JfCEnu0=; b=mERJJt6J4uQ69BWswpvvA8Xr+cghU/oaAubjjvmLSlezm5FArTAecOgEWgOtENg90EL+RIFSWU9h3yTwIfqks2LZfnYeZa7qvL3BfFPOGlal32Z+ql00DByvgA8l/GU9lMUCtG/z0YvE40KK0lMFhhuQ8b8E3c3HXM4hK2k1mfA= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by BLAPR10MB5361.namprd10.prod.outlook.com (2603:10b6:208:325::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Tue, 27 Jun 2023 19:52:24 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Tue, 27 Jun 2023 19:52:24 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [COMMITTED] libsframe: use appropriate data types for args of sframe_encode Date: Tue, 27 Jun 2023 12:51:24 -0700 Message-Id: <20230627195126.1955051-10-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230627195126.1955051-1-indu.bhagat@oracle.com> References: <20230627195126.1955051-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW4PR04CA0089.namprd04.prod.outlook.com (2603:10b6:303:6b::34) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|BLAPR10MB5361:EE_ X-MS-Office365-Filtering-Correlation-Id: d469d68f-b635-4e89-eeb4-08db77480716 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nz7dIvL/BibJyNBKeO5UAHFCco10tqHWVs7snFS3BNxeBvitVCPncy1jQEYRy8sMSkorP8juXFVaM9kCjFRyyQG2E806jdOr7ibhNxfsi7UDoZTHWmDgkoLtuSaMn4t5jyUz6WTxNSRKbtR+PgvqRNhUYN3HKT7BK0aM/YFkg7VKmD8rFeOG23E1QwtmE5xGCVfOWyP61znxJ0k0QE7xc6W3EgGHphd8mkzK24/pyPm1l+Jh3mQ+qAzlb4GYhgtwQhN9wORHhFYMcqnchoyVqmAyBtgV612E0iyuYKzJU7guU2xSLn9auIwc97JF+SVHjLD5JzzeXFH55cPEBB/LW9SJ9UJ3+eXI2bYAVNsylkbzfRL2f2+QIqTBRocwoJNGAt3LiQ0/JWVqLOpYM+LMAg7Y86vLSTscTUL1fOhUwUnr7iTHMU04Fu2KLMdx/D/ULKMDDJu4b0WOZQkPv1LjvyBLQbFTUJmE9gxko6AYqeFudjl0g5NgWmjzGvMjN6fwxhhgY9i+XtF9LpWYwXYzT2SsTtR7Slu+zBTHG0z2TUZo1iWpJJwelx11xt6Dop9a X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199021)(1076003)(107886003)(6486002)(83380400001)(26005)(2906002)(2616005)(6512007)(6506007)(478600001)(186003)(5660300002)(44832011)(36756003)(38100700002)(316002)(4326008)(66946007)(66476007)(41300700001)(8936002)(8676002)(66556008)(86362001)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3ssZ412rC4/fBixbU4sDK26VibjR4nOxS1/vTckWU2ZbWAZz8b/S/yiWYHFn?= =?us-ascii?Q?eDp+mkHlL7NImeVPvHE7SckbFILTbHogIelVFKk20GVvq4g4/cLY5d8N5b93?= =?us-ascii?Q?9U2hPuElTCa9Vt53NtPEoTEeCAbCNxalklBbnOlcO0YNc74etin6c8q2MWiM?= =?us-ascii?Q?N4fOtzieTip185331by4/VAdk0qfzmGRWH4eqmY4Vh/Jo7gXywcplrjFwg/z?= =?us-ascii?Q?WSLgxMY50D8um4+89CWOO6w1ECNPXMun1SAe2KCj5rM5gMMS+i1QCjDJnUz4?= =?us-ascii?Q?XA73EuMZSwC9lNu+pCjNHpUtdXq5GRPJGX664Q1b//ANciS6nZ9SLiCqpaI0?= =?us-ascii?Q?JKC3eGKu+zgjhGaPESjhXyH9uHf5Gk45TXSWUei8oUib390HYAbG01DynEM4?= =?us-ascii?Q?ZTgxz4uibvrZC+btV1gvVN5KMsn0c/UMJw8yISfsxkd9SBzJPZBoGXtR9Rtq?= =?us-ascii?Q?XaL31VAW4qJUrc9Kii7doAa2ZZ56gQKxSRHooJTCPNz2H8magTvIJtFqrjvz?= =?us-ascii?Q?S29kX6NGmDxOiTOqfbnK/WpERHgP+bFmMS4mMH1XqmN/Iv7FhDTCwQ73kLfM?= =?us-ascii?Q?dt/fiZyIL16ajWDdQWu0FeC6A8MoGgaZHZaxF6jEe+Uyqs5oNYu/MJjQqV0X?= =?us-ascii?Q?Zd4oZIHncfNObIxmqP5e6L6x5BTISk1N8l0NcJZT+DVWV+CDe3toGnzjLoWo?= =?us-ascii?Q?k6PyGDMbXJ9hnd52cR7I2uZSf4oFgg/zW73r9JsGIR2zNi85fRY/10FWsae1?= =?us-ascii?Q?PjYCjVfIZ0UYzr9DqK+WN7g9yTEKE/YbHxEvgNgyykSye91iMbqdIgr3g+Cz?= =?us-ascii?Q?R4SPPiRRHTvKtWiubWHtgb0rel/yvxrQiP7l32VS/LqSrmjaT2Jn7HlAECTw?= =?us-ascii?Q?p0aKro77lx7jRjNSqQH0h/K+zFoX8HLUZL6hCPKtA6cDstC3287JGrGG35lB?= =?us-ascii?Q?vyjJCi7c74U9U2zEb8SyKYG8CNPuT+nc/J9jPfQRcR887s4mBoK1Zpd/JRGT?= =?us-ascii?Q?lSBzOpOza2PzObo39YXiKoCVpD7ysRgPVVhcU31P0x7z1k8MBLrJsQ7Gx5ib?= =?us-ascii?Q?CtuqVdLypwEGG7IU+K90sDuuASiOFdJmdrRovEbAaQWxF2ee8rV84Z5ZYdvB?= =?us-ascii?Q?f9raqhSqSpVWp7wFDaKErQ50D9ZjP2IUulePHPONlq51NQlb+irwdsON5Ip5?= =?us-ascii?Q?771qRn7njPbrkwneDgVPfXFUouebrHyrluYSRxyWF88NoZOuh5T7HKGPTocT?= =?us-ascii?Q?/4k/vDWE5r4zP3YA4e49YrM+7NmxkNfssiCYrjEctXi0mkeY+WDK3XyRYk9Y?= =?us-ascii?Q?hjj+DlawnwJJSeqW9f7j0uhpQiVad+5nbXkZMJkAX1vkhM8EXPMC/+ame16/?= =?us-ascii?Q?aRo2QmZQ+dWEA8tFAEZyYG32WKYiBgyDzGV6dPjlYHukXWaVxz1PDdZ1tCAX?= =?us-ascii?Q?F4oyl+qzBfPCDFs3/Nj94N95H6rnmkK3r+6Anj0WpbXpRzQadoNGU1ytNvsV?= =?us-ascii?Q?VN4wwAYJJzrfOJNbAhcz6I8Z6gOKbgLbnnKBwP5xllx9D0TFnwvOzDdBLtza?= =?us-ascii?Q?1WMzOzybqrJ+SbL8dwRypxAZQqbdsDeyzxuD1wGL?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 29WkgKUuqoU/3EwCAz2O7iepACVESdqNwSOE40cqh9jiPmWEFS8k5XaSGgvDFyj2d3Z0HF/P5rnriGarQxdLctyMVfkz+C4QgfLnR9VgEc9qWcB09xvxDWDl2PPkmeWizAboje/Ud9qnGiIs6euL4g8+VsCyJuh1l9WrrRG/Kr59iwx8rxSVLCb3kgSu3dpmKePFd6Eyrw6gmbHH+uoiOzgt0Mra99bsCk8Yq1aQgyDbPqg6lrC/p8PwojMlJj9rvl4w30d4fZC3xIAemAsJflJrYserVpyV9OtlvtvkS+ALn9gRoXa2pJms8pV2QO58YF75CkjuKslJ2VDf+jbai8BTUe8ka6hz6ZD+fz9ozHEBerVbh+l9g6UFEUJzRKWmIEL9zHmxzOtd9oFK7+qSCQAdcIV1vT+N7PUFG/wSM4Ul+/n0+4Wr1uZaVPSy728wKz8y6DM8kT3SEiG7dzCB6UtpDMgc6txWFzJOOfTFoRtkSHld8JAgtbTfRJHGiTmGIhYxOnhDuu4nyS/KyndsXg5+BKGZsCM7RJjj1GqHLMrzjYnf/Q9SmstajtiW5qSD8EV7FvAkS3z2oaqhNuCsI50ezk8OnXCJ4JxYuOUTIaZ/Ttqq/93laq6IrQVVkTD7ScoiLlILntZf5tFQGXDnqOwsZtVNFQDWnbDMfKChohVlz74uHO38zSMCidsvrfY8PKeTPW2eAyvuckS3wwioV9xa2SIf9cTQRsn/1KR0pbB1sKVTMyqy1GAyBWLAw4wk X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d469d68f-b635-4e89-eeb4-08db77480716 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 19:52:24.5515 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gPsRPMNGKJ2+25uaWaExzorydVqMzSyoetc4f0avm8m6/VKjpdgElNvoeEiWUPeneuZ8dcZxyMsH1Oc9Lqf4fQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5361 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-27_14,2023-06-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 mlxlogscore=881 malwarescore=0 phishscore=0 bulkscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306270180 X-Proofpoint-GUID: Gy6nFRPn4O6xt8Wldx6Ev01S38SIuKHx X-Proofpoint-ORIG-GUID: Gy6nFRPn4O6xt8Wldx6Ev01S38SIuKHx X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: include/ * sframe-api.h (sframe_encode): Use of uint8_t is more appropriate. libsframe/ * sframe.c (sframe_encode): Likewise. --- include/sframe-api.h | 2 +- libsframe/sframe.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/sframe-api.h b/include/sframe-api.h index 46614925c68..9cb2db0edb9 100644 --- a/include/sframe-api.h +++ b/include/sframe-api.h @@ -202,7 +202,7 @@ sframe_fre_get_ra_mangled_p (sframe_decoder_ctx *dctx, /* Create an encoder context with the given SFrame format version VER, FLAGS and ABI information. Sets errp if failure. */ extern sframe_encoder_ctx * -sframe_encode (unsigned char ver, unsigned char flags, int abi, +sframe_encode (uint8_t ver, uint8_t flags, uint8_t abi_arch, int8_t fixed_fp_offset, int8_t fixed_ra_offset, int *errp); /* Free the encoder context. */ diff --git a/libsframe/sframe.c b/libsframe/sframe.c index b885e3df5ec..40927f06933 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -1248,10 +1248,11 @@ sframe_encoder_get_funcdesc_at_index (sframe_encoder_ctx *encoder, } /* Create an encoder context with the given SFrame format version VER, FLAGS - and ABI information. Sets errp if failure. */ + and ABI information. Uses the ABI specific FIXED_FP_OFFSET and + FIXED_RA_OFFSET values as provided. Sets errp if failure. */ sframe_encoder_ctx * -sframe_encode (unsigned char ver, unsigned char flags, int abi_arch, +sframe_encode (uint8_t ver, uint8_t flags, uint8_t abi_arch, int8_t fixed_fp_offset, int8_t fixed_ra_offset, int *errp) { sframe_header *hp; -- 2.39.2