From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id E2C243858000 for ; Tue, 27 Jun 2023 19:52:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2C243858000 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35REoX3u009890 for ; Tue, 27 Jun 2023 19:52:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-03-30; bh=LQJPIpdJNsH5MBq43bNzCMQ7f8cRt+30xCqaktLOazI=; b=McCxoPdwxzihfQ7hX4EdITcYxryFzARMe7bRh6YF9+bEXvaRjVj0T3LvuPpDAOX7PQ5d IDYnavi+hpgLj3uQbwI6OoTEG52qsMoD/55Pbz7L7Mr5FdJpqYkZo0qyYWTZnUPRYds1 8mhN/6Mn4dT+Bs3OJpcPbUdJOR/1MDpPq2UpdQgqh1PzVmmMi4iWxIYITlhkD138Cl/R AMVUrGTKFB+F2yB6F7C64o8L1Z1JRrpJzrmXyLrHLgdMZdKugE5RZpInctfcHw5+TeTM 7mgiOPU5K/RctrpjgsiYClGI38Tkc6v+fZZrRdfFrDuyOUMhjN6QvHEY+F4SULvbsSsQ 0w== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3rdpwddw1k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 27 Jun 2023 19:52:02 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 35RJdJvu019959 for ; Tue, 27 Jun 2023 19:52:01 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3rdpxas25u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 27 Jun 2023 19:52:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EdiBs5FVHsYXE+vMFo8DavDOlV5AywjGgfOdFwR0ZtkQUTjSkva/Ce6+THUiOcUJmQ6L9aguUqFW/A5ROtbaI0PPl/9PPCePzya1cDWIDtvmIOupJbC0pQ8O8tjQnHCQzhdJjaydc1c49tWoWXgd1ky/A1+TR6omdSDfa028Oz6MK28mzNi9pr3a48i4xvomPzE1ZLhLPHDfBckuWPscfq97tBCJezn2A74OY339dRUB7iguuHXZxHGSbzoskFbDnof6LGEilkLeOE9HoTL+oZjBF2e6EEECRkukr+GZQCEfZMDRhWu5UavDvh6Xtrff+A/+0e+MzcmUc3YHex0LBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LQJPIpdJNsH5MBq43bNzCMQ7f8cRt+30xCqaktLOazI=; b=McqTixe4iINlypqoj+JRBdyDJGl8otqS+KwboDjZo2Hd0IHq2h2DrsPoJ8FgtH16A/4VrUVMh5AMNQ52V993bsg7cmsbZOj3RRnFzH6jd8kpuVXQ2PBi+x1UJaFnUA7yt0HcPsgXYGkDyrXsAMXTG1jLT/+X22+mQz0bfR3Q7cg0v9qP00UPh37hKtRXp+g7H6TxnplgZuZ1hkJCc3A7VTUjtEBL5eeFuPuJs9+luj4LmuXhrnlvXryDwkHXL7ectQ7u9PCGnn1MqiBQOq6f+OhjJhiaQ3it+HY0FN170nW60/Gwi1iX78t8TU2cyuoZwlg2cDKoDKRWtyKHtmAW1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LQJPIpdJNsH5MBq43bNzCMQ7f8cRt+30xCqaktLOazI=; b=kmnP36pMUC+xeF1huCCaI0kZ2ZvKU3TjaqPN6pM+3YIF/jB8lB5ofx5Js2n3GgRG/z1AhwX6ukQdLNSwyGwCyOqTlzj/W3wYAV1zBK9c4Vt92ZApDyIDRbw5cD9uP9EG60+pvCkDStlZso6IFfvnsPCikshiXZpKvu9nF3bdy8o= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CY8PR10MB6803.namprd10.prod.outlook.com (2603:10b6:930:9a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Tue, 27 Jun 2023 19:52:00 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6521.026; Tue, 27 Jun 2023 19:51:59 +0000 From: Indu Bhagat To: binutils@sourceware.org Cc: Indu Bhagat Subject: [COMMITTED] libsframe: update the semantics of sframe_fre_get_fp_offset Date: Tue, 27 Jun 2023 12:51:19 -0700 Message-Id: <20230627195126.1955051-5-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230627195126.1955051-1-indu.bhagat@oracle.com> References: <20230627195126.1955051-1-indu.bhagat@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MW4PR03CA0046.namprd03.prod.outlook.com (2603:10b6:303:8e::21) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CY8PR10MB6803:EE_ X-MS-Office365-Filtering-Correlation-Id: 722f12ca-b4e3-4cb7-473f-08db7747f873 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VGgnvMQ2fig1YQctVQHTiL8jmqmSKVRHVaVXDefQeSKfrR9Un2rS6mOSchGHT/nJvxz2NS2TF/o21wfYybNs8arvBWJyjRB/ia/zzZCltJ6dSzb/5T6jcMkmjpEuQ+THMmpuu3uyCk1h/Bb6z6FSSODsIi2GB5fRUwzCwwWIb0swY4+E2hKFx9VrWvhRhJ9f+HxL0/TfgJgVoYfXL1hqiP96VEA0/j5j9mOOST+h5XBWQAPqiTdPx3E2wc39xOrql6QaGQSgus89KxJr7E3AeHKpV8aHhHTbfKCLW7vqRMrvCDxo2eakvKSdXFZpuBl52f9Dwnj7FKyJ5UknxH3x2gjC6KUFQNIt5F/HRmk/ayNQh0iOQUf7ZbYwvjbbj2FlziYsalN7QjU0AvZja9CfmiZL1DDK0iALZ+nAtkZw1jL5m4VFmFjM3kafta992cRvcGvua5yv295MIF3OdXvKNKZJwHUrdBXJ78AkSBoZl/CrcUP25EfR2X6mxpglYWV28Ok/Sc7vKjx1AQwSw2sGMfQ28UsR8p1qxhPfD0p42hawbHPhkHOqGSTDE4a0ytBe X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(376002)(39860400002)(396003)(136003)(451199021)(2906002)(186003)(6486002)(107886003)(38100700002)(83380400001)(2616005)(6506007)(6512007)(6666004)(86362001)(26005)(1076003)(41300700001)(316002)(478600001)(36756003)(66556008)(4326008)(66946007)(6916009)(66476007)(44832011)(5660300002)(8676002)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Cp5UND5rS/ErHXk/ieATsEP2+FyCTlqEvdXbohJ1Gt7b2VF6FGcyrAzstx2R?= =?us-ascii?Q?eQepNS519lKdDZXwnz0xdsrJTLzhNLNnmWqaC/VA6DU1TAULzABuu1UXI+T7?= =?us-ascii?Q?XfVzpX421vsREEAtqxoX7hhQivyzndc62b1UYftKeWexm+imbm2rOB5LAbJu?= =?us-ascii?Q?GWUk/E0EkVpiBgyFHxWGyTqkSKa1gMbINLMfMVyBa86Axdnv3f7xCHyG5CA2?= =?us-ascii?Q?iYuanJTzVo5mNVsqYJL+1EhUVBQZSUsWMvdcA67RjTVZ5nRcRIjS0GqOEgUm?= =?us-ascii?Q?3q6fgCz7XAaTfb8klrwqqqAZSS7yWl37Sw3uLgLosbnwzdhZlCfLDFjYXxws?= =?us-ascii?Q?jaqfVSZR2YuofvFKRqSSxxHkFyCo0++DorkhWH6I/prcS6Z0sWMqH43OFwRb?= =?us-ascii?Q?ELsdZ8CHS4uZZlBMz2asY0JmqdoJWHA2KtL6AKXQNArUu4DpRWJI3cLUN8D+?= =?us-ascii?Q?mwZl8SOPTxvz7R8Uts/hF2l98pBFkWilMGuic5YmWmchzHcIIBVyuShNXGNf?= =?us-ascii?Q?Ca66DHlndmut7rovPOu6/sUNPCwcz8Ps+PI+Ho3OLjIBeDUKZK/tN1jkaYJl?= =?us-ascii?Q?LEXUdavh9cbL6i+EwN4NIM7uWqpJXKE7hLaoQzcBItryE6le6ssePkxCLTKa?= =?us-ascii?Q?DKE/dkStAh/5OzjwRMKx9a2uu+DGrtissefSarWgfhC8Th4QpYhf5cN9eV0u?= =?us-ascii?Q?GFBTRbJC6cDkX1urZH3w/mXMYYGgc8Bpueg/o/8SjN2q4FMBAksEfJCvlYpX?= =?us-ascii?Q?+fuwRV2a71MB3ioCvZ6g43DDwMaFlTnqPPMc5jG3mh09zdkj/QJ6SVTIwqQ6?= =?us-ascii?Q?Up0pu0h41LjsqoI0tHf9mi0qpJDR9UJIog9A3ZvF4IQo78au3FBIxdBH1Yb/?= =?us-ascii?Q?G0onTks2Gs3RtuNuWmERg27fKvmDjhA2P17bd8zxTQoI4nq4OzpUmazyZ5AY?= =?us-ascii?Q?n59TnyC5QXEsKdsL5JTP2mEJrjVWo5UbI0JCg4HN+5PcFqfpF2YLVHFB2B7B?= =?us-ascii?Q?Rkv+xZzH7CkN1/5CV/rN6OfxaYginQXdDHVevwbRM8LqUnC87y4UNf400wy4?= =?us-ascii?Q?k3EPBvGQWnj3anVgwyeJ9rX85OdQ3IVjue91JT8W03GJ1Sw9dJoWhw1UTfpK?= =?us-ascii?Q?vfYpuvO5LO6YOZmtGouz4+hA+2j+VLIlAjKV/Cb3kZE1I/54KNQEc3xrSsAa?= =?us-ascii?Q?waJLtXkepKU3duXpOfAEQpJgPXAf6oVRT8FPXsLXoN2/edVL18x/JjNrZOcJ?= =?us-ascii?Q?FCBU88hiDAMWGapwv0v371cxBfvfhXeXB8i2T5Qhbb9hox2iPRVEhzwilSzS?= =?us-ascii?Q?1Rb3uVBcjGDuZOXLAHJmRxvt0b0kRE83QFmzZgKp2zSykD2jwPhY4ywH7ZLA?= =?us-ascii?Q?MCGrq2WzW4/z+lMkV3rd5yd2p9SDEWH+sSymx/yjEVia6RcsdwsicJxInfgh?= =?us-ascii?Q?+TsZmFQrU9UIUySlLXgxQBBPOAntN/Pawf+oMUB0iHpk8dCLmVFidG66xYI1?= =?us-ascii?Q?Z7+Pg/+BDI5b13B5v6BVkMorXAFBRG5MFFrOcA/zFaudtw/lt58bIq1urn5Z?= =?us-ascii?Q?RRljr+TXFFqIR47TvGEQd/wxTThsQh8g0J7I2jmS?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TJmslZVFcC3QA1kM9Q2izHIRbfOQefDS/uWc0JXebTUJWx/hnfWpNZwjr/9GeReSJH2WmuTbpuHpSzmO1I7mi3ESpp6xE8lVCnmejRSZUM9GI9cG+MPLOimHXC+tuhySDQYkujKTXH5w5uOShkeInC7shtPngMZPiF0t6mr9NVFDkd/ALE5WPuZN16AN0PxecvN5Oc7vFB28/0hKOccQT8Kz0jGJOwXtD9K+19ize/C+tMScoOD7ADDbGZDxflWV2diKZBAyYzybqgM73Q4Tc9ns43y2QpRLwoYtqZhN/8sq+R4ezkoC1PXHe4BkjEgKauVGTKOkKM4lwFwIqJ5PmUqh2zpPpQq/aOsID9YgLPmXM5UuMN12h9xwLtrwnQ+BHlftAeDx7wP9NJWcAQ/Ich8ucVA8po6mispsbKsWiCMgj4nj//C4staYygjpbzyGJFlOCLZPzUfaef2U/MgnGx9stpm8/k9yeh5GcFkoHLLKdfYKyGbTMYLTuQA9PJEQJwEA6IUSqhW8Mz5pkZF1vsR9pjRhY8FD83kfRWW4AjgZmUd+amV2lnQJsIfX8h32tpB+5fQ92Q65qETAGt3ycz2wT2kweaGfoxd9J4lEQbRw0VkMWJ8ptcgAIlI6HruMZ0reHezqmHKZGS1+eMcnTQYXTm6ZPWVEEGKXIGppWzabWKcm328Gg5fbqndvKISOECh20gNxcoWxB3KtHjGH5ljdBM7R5BQZGe5vi2WINSm1/WQSNcIoVnFYEFBGVcsq X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 722f12ca-b4e3-4cb7-473f-08db7747f873 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 19:51:59.9607 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c1x9RCea6bx37tpA0JPjqw6gUMZAjF371EpIaSo1n6BJzowFX+gZ5pkW8agRRl870a0TIHWHC0y7NxlEVY4h/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6803 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-27_14,2023-06-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=815 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306270180 X-Proofpoint-GUID: TFqv5URNiafKcFVuAkwrgiiQmuoxm83y X-Proofpoint-ORIG-GUID: TFqv5URNiafKcFVuAkwrgiiQmuoxm83y X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Until now, sframe_fre_get_fp_offset () would return SFRAME_ERR_FREOFFSET_NOPRESENT if the ABI uses fixed FP offset. A stack tracer, then, would call an explicit sframe_decoder_get_fixed_fp_offset () to get the FP offset. On second look, it appears to make sense to hide these details of whether the FP offset is fixed or not in an ABI from the consumer. Now, with the changed semantics, the call to sframe_fre_get_fp_offset () will fetch the fixed FP offset if applicable, or get the FP offset from FRE when there is no fixed FP offset. This patch changes the behavior of sframe_fre_get_fp_offset (): it turns an error into non-error. This change will be included with the next release of libsframe, where all the exposed symbols will be versioned with version node LIBSFRAME_1.0 for the first time. libsframe/ * sframe.c (sframe_fre_get_fp_offset): Return the fixed offset, if applicable. Else return the FP offset from the FRE. --- libsframe/sframe.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/libsframe/sframe.c b/libsframe/sframe.c index 3d1b5575f0b..912d34352a1 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -644,16 +644,21 @@ sframe_fre_get_fp_offset (sframe_decoder_ctx *dctx, sframe_frame_row_entry *fre, int *errp) { uint32_t fp_offset_idx = 0; - sframe_header *dhp = sframe_decoder_get_header (dctx); - /* If the FP offset is not being tracked, return an error code so the caller - can gather the fixed FP offset from the SFrame header. */ - if (dhp->sfh_cfa_fixed_fp_offset != SFRAME_CFA_FIXED_FP_INVALID) - return sframe_set_errno (errp, SFRAME_ERR_FREOFFSET_NOPRESENT); + int8_t fp_offset = sframe_decoder_get_fixed_fp_offset (dctx); + /* If the FP offset is not being tracked, return the fixed FP offset + from the SFrame header. */ + if (fp_offset != SFRAME_CFA_FIXED_FP_INVALID) + { + if (errp) + *errp = 0; + return fp_offset; + } /* In some ABIs, the stack offset to recover RA (using the CFA) from is fixed (like AMD64). In such cases, the stack offset to recover FP will appear at the second index. */ - fp_offset_idx = ((dhp->sfh_cfa_fixed_ra_offset != SFRAME_CFA_FIXED_RA_INVALID) + fp_offset_idx = ((sframe_decoder_get_fixed_ra_offset (dctx) + != SFRAME_CFA_FIXED_RA_INVALID) ? SFRAME_FRE_RA_OFFSET_IDX : SFRAME_FRE_FP_OFFSET_IDX); return sframe_get_fre_offset (fre, fp_offset_idx, errp); -- 2.39.2