From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpout140.security-mail.net (smtpout140.security-mail.net [85.31.212.146]) by sourceware.org (Postfix) with ESMTPS id 472B53858CD1 for ; Wed, 26 Jul 2023 07:36:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 472B53858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=kalrayinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kalrayinc.com Received: from localhost (fx601.security-mail.net [127.0.0.1]) by fx601.security-mail.net (Postfix) with ESMTP id A1DDB349537 for ; Wed, 26 Jul 2023 09:36:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kalrayinc.com; s=sec-sig-email; t=1690356988; bh=pSVIKKoyteKRudEOhlBhYi9HkbYWRRNB4gvyBfig13E=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=UDx0D8iYbEWuVz7IhpI37+sZne3/SbodYdCr+CukMiq6M4wKiq7k7SGe8ToGKFDs2 Tnhxxx4yiGQuaPKqUUvNFDO+bK0nX+zBzg/uGkQnnyDX2OHXSvRXXFU77VC1UJsqqf 4QE6Ocj+Mdx9Qp92a9Oh1j+7LXNdteZPuwlooK2c= Received: from fx601 (fx601.security-mail.net [127.0.0.1]) by fx601.security-mail.net (Postfix) with ESMTP id 6DC2934952A; Wed, 26 Jul 2023 09:36:28 +0200 (CEST) Received: from FRA01-MR2-obe.outbound.protection.outlook.com (mail-mr2fra01on0102.outbound.protection.outlook.com [104.47.25.102]) by fx601.security-mail.net (Postfix) with ESMTPS id 499B6349343; Wed, 26 Jul 2023 09:36:27 +0200 (CEST) Received: from MR1P264MB2482.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:33::22) by PAZP264MB2990.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1f2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 07:36:25 +0000 Received: from MR1P264MB2482.FRAP264.PROD.OUTLOOK.COM ([fe80::e9ac:e14c:7ed0:228a]) by MR1P264MB2482.FRAP264.PROD.OUTLOOK.COM ([fe80::e9ac:e14c:7ed0:228a%5]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 07:36:25 +0000 X-Virus-Scanned: E-securemail Secumail-id: <17159.64c0ccfb.47d7c.0> ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SNUVEekk5vqc8nYnzqoJH8aYy1zrwAPWyOTwy6+ytvhKSK0AMa4m+YbeENbfJYZbXXkl89WiHHryr/G7A6AtHuLJrOUuWCHd4zxyUD43wyZ6sK0jgOKSvUFo9BG+jPYGgeu5OfSxrbIwmo6szD65Pjm/ZJV5/UjIoIAI4sQXzr2BFgWqApKQFlfULamXpI8/puSFEB+RdfYvtFzOrj9NN61woDCth0adxkIzEQ8mI8gHiVpcfa2MRqF6GfVB2kmmVccSL+R4T0ZZUUEgj/f37MGL/5+EG3fOn5zu1CqZRTQDJiaPHt4xqJP9nGZ8px2mauauS/aAoLkdegS0X4CC9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=044xi9yjunzsHGEaV/9Lp6wqUNHoLU2QmBkBhWqE5Yg=; b=kmCSIi1Ps0woOMTTgKiT4Zcqh/JC3zuODh/PnMkhGHbADLlkF4pQ6bHUeD5hPPKF2x958ifKeuplTCuT4skE21iH8bdz2UwOu0bxoFzzPT7dverczbylyTLYp4yFH3j1focFg4gFNzahGEQ5S5ngv5tRNPYkHwd/50SOir6l7ucaZuEbHv2sxUfRVjo0sTJMCQQ3JD93NdNsfqUdnUN9ik/eZAjvhpsx73xZxBIEfwG3q4WPaRsS8VwNzteGmr3m9PCOFE0JobQ8BezdwlKsEvnOAjoigJB5/NbtX0f35UR1/CalmQ4d1wKlNNdAHom7WXo6Y/+sdW8kv+OnmB2GQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kalrayinc.com; dmarc=pass action=none header.from=kalrayinc.com; dkim=pass header.d=kalrayinc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kalrayinc.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=044xi9yjunzsHGEaV/9Lp6wqUNHoLU2QmBkBhWqE5Yg=; b=KbCUi2B/9UhnLEawqp5+qt9QW0ZYGjLaHnIBBJLNBXeGMoBYkzZWdoI8mczvrKYAHQv7iLwH9OZJrXhwYmaY2gxZYol1aAN/YfEI2xN/PVCiizTxvvrLYXF1tBb4VBO2Z00KSqPdtMntjO8CFwtqRrqqLa9SIim8korbKuz0RyZKBBIV1nPcx0P/I2zMv99au/uuPe9sZ31IKS9jvkQNlxmXdzl9zGBRYlg9v4rdylIdNnr5ZmmQYQjLdmXN3Asdx1ZDctTVNnlcy/0fHciLhSh/AlhHf9vcMpJdbfC9QxzCBW+nx3R5a+NXhFbXkyANsvGkAl7BZmOqhVn+AWODfQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kalrayinc.com; Date: Wed, 26 Jul 2023 09:36:23 +0200 From: Paul Iannetta To: Nick Clifton Cc: binutils@sourceware.org Subject: Re: [PATCH 0/7] kvx: New port. Message-ID: <20230726073623.eaczp74zhock7dj7@ws2202.lin.mbt.kalray.eu> References: <20230721074956.7188-1-piannetta@kalrayinc.com> <7a676623-4084-c210-3dcd-37e813aeb32d@redhat.com> <20230724123338.r27dhowqkwzqgt4u@ws2202.lin.mbt.kalray.eu> <886f77cd-8cee-d530-64f0-c09cb9643a93@redhat.com> Content-Disposition: inline In-Reply-To: <886f77cd-8cee-d530-64f0-c09cb9643a93@redhat.com> User-Agent: NeoMutt/20171215 X-ClientProxiedBy: AS4P189CA0008.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5d7::9) To MR1P264MB2482.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:33::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MR1P264MB2482:EE_|PAZP264MB2990:EE_ X-MS-Office365-Filtering-Correlation-Id: b61901f6-e65e-4e6c-8114-08db8dab041e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3GL8efFcoO1QA1jTHxww9LmDDxNsM2QNeIDYBEuI+mziBAfzDisbsedoeDYvM96cuQeedJ5qSa2TdTEgKvz5K4MX/USHxQMiBFJBjhR69nflYOfLY7ae/kCdJwjmm3r8CklHpGM6/TZkF/Z2dV4OU8fsMT/TH58o6i/YqSyAEeHCLUnG8tsYg3/juEV3gGz+KZUHI3GZ1VFWm9k3t8pRXyzp0d7JK/R5gWBbW3OJWotuKX9I8wNPohBPYLSY4TLweTs7sabhLmmFUHlXVCfSg3iJazt0TyGR+KbDQkFctjuIhMhLlpMTq2DQb1GTvz8S+jXLL4oah0jq2m/7O2VxciTjKOdybLvjGmXcbIFX1pT5FH92J8+mKI0tMfmK0aG1nThRLrxP1S4YcoMbdtOWoKhEBBA6/M42rHxAe2wUthMaRj2dUANtCCsel0HLNu0hS/8EocxGBnZhfkyM6EOChlDT0Dux1rH8B7CpnTC0ShJ7vjrsF94usI39N2ZBSfLqA6g7URJjbV9AjvlXx11r0ocHarLX2l/idPQ1XUCj+SLs5xQDQ7nRjp50nnURLcZS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MR1P264MB2482.FRAP264.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(366004)(39860400002)(346002)(451199021)(9686003)(6486002)(6512007)(478600001)(66476007)(26005)(186003)(1076003)(6506007)(2906002)(66556008)(66946007)(6916009)(316002)(4326008)(8676002)(8936002)(5660300002)(41300700001)(38100700002)(86362001)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1Ucmnvn//SYLpuXh6ZFr6B9zovv9A6RtJ31PbztO6DdozmzGN44PmECI5QqcdxARMI+IP4DtTvu6pMsu+YgyLraT6cESCz60KnQ+NpoDxyda1a7ZA/2gTBf2Ie2r8POTZr3qWZ0Er+q4byV6fSUFKZbwEa0NlDCuEcC6p/cGbVCxaA3oDMZkc+4FkilkjtgZmo8hZQw9yYGH4j7wyuTvfqpdAydo+7SLmCr1nhWDXAA8vziWCeSxSLl3J2BJkEvBHzW5AXCJJGjdyPteNwTwwPNCgP2cCfQvte/01UG9+vIVGq+X0BWNJ/2m1vcVm/K1ebbZvBoihRvtS/Rv6WWxbEVc8C10cSb9Cj41b0POVwKPBUMZW2iVlYf5sv1ApM07bg1JJpxbVIg08W+TxjhK13d0veAOqI/QQW1mWm99RTYajw5xfP3QHPEgkYm0iiYNIA7xE2penvi69ZiKnKdkJPOBAUj8BdwbK9l1X8c9Zkg/7BrnCWN7M23NYB1Hv7L3l6VOC/eN3aJ7/9OdDCzKju9n5yqj8GrNfNzx1E4fn+UYSI4Z+moFABh7vkKbaTYx1vjGZQ3HAJCDph4/6+B5ZjzEizFkDtY/ClBA1YZjFfj1mO9wcGwGeIiwGHN/88uIQNva/ApdqnY2vmcRQFT1VHERzZGlvwH8uQECdyo6hOl/73uN0jJ2UknnGfeLNRbkpF/qdC96bEZSGvRtvSmjvDtxy25CuAQ8GzNDDb7CXSTn0NZRQ7n92eckYKt/QBe3lozTyNlhxm796yo6JHELZCNOxmO9TAcE5n9egqdYR20kgp4VL+qaagGz3xzRs/x4K5Is3sOKR3MCsEJHVuNaoAEjweFFPilkTjsMDT0Ac7NKOgKFRg26ukfWAJl+KE6eXJKT/2m8INg6Cgt8wbauDx+Uh54RKJ0Vnihl586TrA/B09funjCExbh9SOa5aiKi wYJDwyMByQX5GR59B1DyNR9YrkkDBVnMP73DTpf/4LAvd4kWAHpXCQNnyCN/RI0Z6qX3gRYSMYj5Dkb0+bxOkgQO7XzX53n0iw+CaCj5aLzwXxbWkm0nKb1kc+hD9kIMCGcIDRs6EDTMWLl1/vFxwDMGFB7Ks/gNTDwZXrt255u2+b09StIKuuKX9LoPWWD5eevLheUGnfa3qY1xJn28yxVQGYVUE10SKqG86nlTyJXx/e76V7wrv5LatYZuL8AD9eq9MhYM2ileDCjwi8yupSmGNd0xWnxWeLEurKzXDtardekzZM3uo4RWCIm+c2H2rO2JODHif7yCQrBtsVnQ8mITete3/Z/juz+HccuCZhYzeks6VVwzid9eCtEcDRBWYAJ3CX0fkuKPBC8jDnLugUkAlrBnMaFIfX2TFWUcsVmsmjA0irxi4mtVpwBdOqMaq+1XR/4Paxj5fpvx89QtakP5d+sF+o0FyfjO979QKePouLJkEzNsVkgv9eeEMCU77HgONUlK9lMyJmRipxpAbJkFhO9kbe0mgK4vAnyTh7+MnwC+DJKuz9Br8D+LnF2Wrf1MGNZYevblVHTU2XqVGs2JnzaTtJmb/BjQPjdovTBVUCuleK6HToEaEKL1rcB5XOzZva9RlkchtOgamg64CQ== X-OriginatorOrg: kalrayinc.com X-MS-Exchange-CrossTenant-Network-Message-Id: b61901f6-e65e-4e6c-8114-08db8dab041e X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2482.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 07:36:25.3136 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8931925d-7620-4a64-b7fe-20afd86363d3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QlHOJcf3mJhdRp9sb3pMOxybEJXL/vmTX1/0JQmTiPhg1Ciz/XIy57GtNIQOlpJMA2L/cBRpoIs6SgZlEV+WqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAZP264MB2990 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-ALTERMIMEV2_out: done X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Nick, Thank you for the review. On Tue, Jul 25, 2023 at 03:13:29PM +0100, Nick Clifton wrote: > Hi Paul, > > > > I tried compiling the binutils for a kvx-elf target with your > > > patches applied and I ran across a compile time warning/error: > > > > Yes, indeed, it was more of a convenience macro but it is not well > > supported by gcc13+, that's the only location it is used so you can > > safely comment out those lines and I will remove them as well. > > Ok, so with that down, the port compiles. But then there are some unexpected > failures in the gas testsuite: > > FAIL: .set with IFUNC > FAIL: elf type list > FAIL: elf type-2 list > > Which are all due to the fact that the kvx port does not support indirect > functions: > > gas/testsuite/gas/elf/ifunc-1.s: Assembler messages: > gas/testsuite/gas/elf/ifunc-1.s:9: Error: unrecognized symbol type "gnu_indirect_function" > > I suggest updating the list of targets-that-do-not-support-ifuncs starting > at line 237 of gas/testsuite/gas/elf/elf.exp to fix this. > > There are similar problems with the binutils testsuite: > > FAIL: nm --ifunc-chars (assembly) > FAIL: weaken STB_GNU_UNIQUE symbols > FAIL: strip on STB_GNU_UNIQUE > > Tweaks to proc supports_gnu_osabi in binutils/testsuite/lib/binutils-common.exp > and binutils/testsuite/binutils-all/nm.exp should fix these. > Indeed, we do not support indirect functions for now, I'll fix that. > Finally there are quite a few failures in the linker testsuite: > > FAIL: --export-dynamic-symbol foo archive > FAIL: -u --export-dynamic-symbol foo archive > FAIL: -u --export-dynamic-symbol "f*" archive > FAIL: --export-dynamic-symbol-list foo archive > FAIL: -u --export-dynamic-symbol-list foo bar archive > FAIL: -u --export-dynamic-symbol-list fstar archive > FAIL: pr26580-2 > FAIL: Build pr22471 > FAIL: DT_TEXTREL map file warning > FAIL: Build pr22150 > FAIL: Build pr25458 > FAIL: pr20995 > FAIL: --gc-sections with __gxx_personality > FAIL: ld-scripts/fill > > Six of these can be fixed by updating proc check_pie_support in binutils/testsuite/ > lib/binutils-common.exp. Interestingly patch 2/7 added a test to this proc, but > limited it to the kvx-*-cos target. Which is odd since it appears to be a problem > for all kvx targets. Thanks. > > Most of the remaining failures appear to be due to this error: > > error: PHDR segment not covered by LOAD segment > > Which I am guessing is due to some kind of issue with the built in linker script > for the KVX target. Although I am not sure exactly what the issue might be. > This one is due to the fact that we do not generate a PHDR at all since we only support a very primitive form of dynamic loading (only through calls to dlopen/dlsym), we do not need a PHDR. I'll could add one if needed. We have also been using the `--enable-warn-rwx-segments=no' switch. But I don't think it will be a problem for the testsuite. > > All of which is to say - please could you submit a v2 patch series with these > issues resolved and your other updates integrated, and then I will have another > go at reviewing them. Thanks. > I'll reach back to you as soon as I've fixed everything above. > Cheers > Nick > Thanks, Paul